From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: processor_throttling: remove variable count
Date: Fri, 28 Oct 2022 19:03:49 +0200 [thread overview]
Message-ID: <CAJZ5v0jJPHrfUpY4ZxJYhNR334XZC_iUvetYgRGZW+iLgGrUzg@mail.gmail.com> (raw)
In-Reply-To: <20221024133258.2158083-1-colin.i.king@gmail.com>
On Mon, Oct 24, 2022 at 3:33 PM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> Variable count is just being incremented and it's never used
> anywhere else. The variable and the increment are redundant so
> remove it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/acpi/processor_throttling.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/processor_throttling.c b/drivers/acpi/processor_throttling.c
> index a822fe410dda..00d045e5f524 100644
> --- a/drivers/acpi/processor_throttling.c
> +++ b/drivers/acpi/processor_throttling.c
> @@ -50,7 +50,7 @@ static int __acpi_processor_set_throttling(struct acpi_processor *pr,
>
> static int acpi_processor_update_tsd_coord(void)
> {
> - int count, count_target;
> + int count_target;
> int retval = 0;
> unsigned int i, j;
> cpumask_var_t covered_cpus;
> @@ -107,7 +107,6 @@ static int acpi_processor_update_tsd_coord(void)
>
> /* Validate the Domain info */
> count_target = pdomain->num_processors;
> - count = 1;
>
> for_each_possible_cpu(j) {
> if (i == j)
> @@ -140,7 +139,6 @@ static int acpi_processor_update_tsd_coord(void)
>
> cpumask_set_cpu(j, covered_cpus);
> cpumask_set_cpu(j, pthrottling->shared_cpu_map);
> - count++;
> }
> for_each_possible_cpu(j) {
> if (i == j)
> --
Applied as 6.2 material, thanks!
prev parent reply other threads:[~2022-10-28 17:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 13:32 [PATCH] ACPI: processor_throttling: remove variable count Colin Ian King
2022-10-28 17:03 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0jJPHrfUpY4ZxJYhNR334XZC_iUvetYgRGZW+iLgGrUzg@mail.gmail.com \
--to=rafael@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).