From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Furquan Shaikh <furquan@google.com>, Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rajat Jain <rajatja@google.com>
Subject: Re: [PATCH] ACPI: PM: Clear wake-up device GPEs before enabling
Date: Fri, 14 Jun 2019 15:27:26 +0200 [thread overview]
Message-ID: <CAJZ5v0jRoajC=P9nGvi1bF8EwO5yShpeqtFSpdEm5aftFoLRqQ@mail.gmail.com> (raw)
In-Reply-To: <20190614104511.GC2640@lahna.fi.intel.com>
On Fri, Jun 14, 2019 at 12:45 PM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> On Thu, Jun 13, 2019 at 10:24:41PM +0200, Rafael J. Wysocki wrote:
> > This patch may cause events to be missed if the GPE. I guess what you reall mean is
> > something like the patch below.
> >
> > This should allow the kernel to see the events generated before the GPEs are
> > implicitly enabled, but it should clear them for the explicit users of acpi_enable_gpe().
> >
> > Mika, what do you think?
>
> Looks good to me. I also tested this with two TBT systems (Skull Canyon
> NUC and Dell XPS 9370) using ACPI hotplug and it did not cause any
> problems if I boot the system with device connected.
Awesome, thanks!
I'll add a changelog to it and post a full version over the weekend or
early next week.
prev parent reply other threads:[~2019-06-14 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 19:36 [PATCH] ACPI: PM: Clear wake-up device GPEs before enabling Furquan Shaikh
2019-06-13 20:24 ` Rafael J. Wysocki
2019-06-14 0:58 ` Furquan Shaikh
2019-06-14 10:45 ` Mika Westerberg
2019-06-14 13:27 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0jRoajC=P9nGvi1bF8EwO5yShpeqtFSpdEm5aftFoLRqQ@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=furquan@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rajatja@google.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).