From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6A30C433EF for ; Wed, 29 Sep 2021 12:08:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BE7C610A2 for ; Wed, 29 Sep 2021 12:08:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245233AbhI2MJo (ORCPT ); Wed, 29 Sep 2021 08:09:44 -0400 Received: from mail-ot1-f53.google.com ([209.85.210.53]:37557 "EHLO mail-ot1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244801AbhI2MJo (ORCPT ); Wed, 29 Sep 2021 08:09:44 -0400 Received: by mail-ot1-f53.google.com with SMTP id r43-20020a05683044ab00b0054716b40005so2557841otv.4; Wed, 29 Sep 2021 05:08:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lOD2JGNZk8v+mRUWU6qCnLPxFm8GKCd1aSiNdnVC1UI=; b=FHQYjSxzrwaYU1HDc0bhjTGseA+05QJLQBAnmIu9ZSS+OZgNQo8YcU5Y2aTgUNKuZB lUnF3S8q2YT1UYdKEXcG8kiQHK8mN5xhLxYAjpB+CCAE93BWIgY+LiHa+SskcduJCSAd X2J09mC+VuQNpZYy+nCU6W8S9kLMbV3AXN9hZmqbSM/tVXDiV27I9WSWN7cLwtbZySKk M3iS/Zdo1YJny8zF4H7cVRhbxDOmq6cECFLHZQV/dyQGOmjdJ8qGFM4uKTORnlesPWj5 RH+gPf2Cyy2VlgNAJAlf9jBPCsC355ansJ8lDjkB6YerZriqgauYeAOrak1ND6+3ihj4 HGvw== X-Gm-Message-State: AOAM530hltOVEEXPa/9A18qho6Q2PmiPjT9VKhzpDaGfVNtEvspkBIyn mX68Kkq9eIHLP0FzbgY7HbNNZJN0ARvWneO+XEM= X-Google-Smtp-Source: ABdhPJxMVCyh+TLDn+QjO1ONDrrdMlbRvA0UkC+rzTXfgidJEc2fjRlS01Q/3WWpPPHZkX8qGU1k9FzfRNmCVT4nNBM= X-Received: by 2002:a05:6830:2784:: with SMTP id x4mr10087198otu.86.1632917283115; Wed, 29 Sep 2021 05:08:03 -0700 (PDT) MIME-Version: 1.0 References: <20210929104625.1112192-1-qtxuning1999@sjtu.edu.cn> In-Reply-To: <20210929104625.1112192-1-qtxuning1999@sjtu.edu.cn> From: "Rafael J. Wysocki" Date: Wed, 29 Sep 2021 14:07:51 +0200 Message-ID: Subject: Re: [PATCH] acpi/processor_idle.c: Fix kernel pointer leak To: Guo Zhi Cc: "Rafael J. Wysocki" , Len Brown , ACPI Devel Maling List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Sep 29, 2021 at 12:56 PM Guo Zhi wrote: > > Pointers should be printed with %p or %px rather than > cast to 'long' and pinted with %ld. > Change %ld to %p to print the secured pointer. In this particular case, id->driver_data represents a proper integer, not an address, although technically it is a pointer data type. It shouldn't be printed with %p and the patch is incorrect. > > Signed-off-by: Guo Zhi > --- > drivers/acpi/processor_idle.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c > index f37fba9e5ba0..a9f4ab072583 100644 > --- a/drivers/acpi/processor_idle.c > +++ b/drivers/acpi/processor_idle.c > @@ -73,9 +73,9 @@ static int set_max_cstate(const struct dmi_system_id *id) > if (max_cstate > ACPI_PROCESSOR_MAX_POWER) > return 0; > > - pr_notice("%s detected - limiting to C%ld max_cstate." > + pr_notice("%s detected - limiting to C%p max_cstate." > " Override with \"processor.max_cstate=%d\"\n", id->ident, > - (long)id->driver_data, ACPI_PROCESSOR_MAX_POWER + 1); > + id->driver_data, ACPI_PROCESSOR_MAX_POWER + 1); > > max_cstate = (long)id->driver_data; > > -- > 2.33.0 >