From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Zhang Rui <rui.zhang@intel.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH] ACPI: fan: Initialize performance state sysfs attribute
Date: Mon, 16 Nov 2020 15:19:43 +0100 [thread overview]
Message-ID: <CAJZ5v0j_FCn=G0tUhBnYTtcxE-GL-LDyq9fOa8Dk4WV7uXBHcg@mail.gmail.com> (raw)
In-Reply-To: <20201110235201.76981-1-linux@roeck-us.net>
On Wed, Nov 11, 2020 at 12:52 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> The following warning is reported if lock debugging is enabled.
>
> DEBUG_LOCKS_WARN_ON(1)
> WARNING: CPU: 1 PID: 1 at kernel/locking/lockdep.c:4617 lockdep_init_map_waits+0x141/0x222
> ...
> Call Trace:
> __kernfs_create_file+0x7a/0xd8
> sysfs_add_file_mode_ns+0x135/0x189
> sysfs_create_file_ns+0x70/0xa0
> acpi_fan_probe+0x547/0x621
> platform_drv_probe+0x67/0x8b
> ...
>
> Dynamically allocated sysfs attributes need to be initialized to avoid
> the warning.
>
> Fixes: d19e470b6605 ("ACPI: fan: Expose fan performance state information")
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/acpi/fan.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c
> index 62873388b24f..9cbe58e394d0 100644
> --- a/drivers/acpi/fan.c
> +++ b/drivers/acpi/fan.c
> @@ -351,6 +351,7 @@ static int acpi_fan_get_fps(struct acpi_device *device)
> struct acpi_fan_fps *fps = &fan->fps[i];
>
> snprintf(fps->name, ACPI_FPS_NAME_LEN, "state%d", i);
> + sysfs_attr_init(&fps->dev_attr.attr);
> fps->dev_attr.show = show_state;
> fps->dev_attr.store = NULL;
> fps->dev_attr.attr.name = fps->name;
> --
Applied as 5.11 material, thanks!
prev parent reply other threads:[~2020-11-16 14:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 23:52 [PATCH] ACPI: fan: Initialize performance state sysfs attribute Guenter Roeck
2020-11-16 14:19 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0j_FCn=G0tUhBnYTtcxE-GL-LDyq9fOa8Dk4WV7uXBHcg@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rafael.j.wysocki@intel.com \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).