From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7159FC2D0DB for ; Tue, 28 Jan 2020 22:31:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 39DC72467E for ; Tue, 28 Jan 2020 22:31:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580250661; bh=THipx5y+1yaixzy/DSmGvU7xmHofOeETzLgJQrD7ULQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=F4nxVA/lbzM5xQT7qp0KjQnz7XJwfwsoXMxy+YZ9wtag5og9H5hzkhhNvb0lHAcuO GpvZErL6NyAKuZd5zhu4vKr+5oBhPEoqxua+pgmRsWtLUMYkuf71DZDmespbynzurz oE2qrrLDdOlKv10F4QiUAi06z7f0nTYEjo0De4X0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726257AbgA1WbA (ORCPT ); Tue, 28 Jan 2020 17:31:00 -0500 Received: from mail-ot1-f68.google.com ([209.85.210.68]:34417 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726211AbgA1WbA (ORCPT ); Tue, 28 Jan 2020 17:31:00 -0500 Received: by mail-ot1-f68.google.com with SMTP id a15so13675414otf.1; Tue, 28 Jan 2020 14:31:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iX2V9T24wEabMeqlN5Cam7uCTsFLrLNLsDKY3xVe4h4=; b=W158dTfG1Kag4hB030mDOlfLaMBoFl0ivZTNeoxoAjhtPESVt272+iwTZp6By+XMo5 K+Bldk80KimNMr/atmJTiju0kZqfSHrZvG2ZSNwy3VstY3Y5q4VXRE0HcSGl/h3covXJ nwaLJkK8Ngw1ixR4li+kAKYnYDVpk8xRqKQM9hnDNaZqnBrqtjWyKR5WKScikvEOYlom bLu5EWsYN+iaVHVjKgx8PsZbMV0OCCDBCfQ28g+98wz3FbLFy6OM4l2UelNIwQbgPNrO l8oAAFXm5DpP7o/JSdxD9JEPojH6xF9PI9DxW5Zt6yyeTzQvpcYzM7/YbuQokGE5FBNA ariw== X-Gm-Message-State: APjAAAUjmqblSRxQTXAoy9YrU2AG4rRdIju+xWO0nhls2PQKGgFduK/0 bXBPus2/I5pCWEFGLYINzAZCC2sVsCvi2T8VqEM= X-Google-Smtp-Source: APXvYqwGxKHqpIKx0p0HtWL/2AntxlhWrFJg6cZnB3vFs65wxLJRTCzWHYF5xUPi3qJz56SLgzHqLM6lwO6EnUxqlT4= X-Received: by 2002:a9d:7559:: with SMTP id b25mr2289937otl.189.1580250659687; Tue, 28 Jan 2020 14:30:59 -0800 (PST) MIME-Version: 1.0 References: <1580210059-199540-1-git-send-email-john.garry@huawei.com> <1580210059-199540-3-git-send-email-john.garry@huawei.com> <4c6462e3-e368-bd9f-260f-e8351c85bcc2@huawei.com> In-Reply-To: From: "Rafael J. Wysocki" Date: Tue, 28 Jan 2020 23:30:48 +0100 Message-ID: Subject: Re: [PATCH RFC 2/2] soc: Add a basic ACPI generic driver To: John Garry Cc: "Rafael J. Wysocki" , Olof Johansson , "Rafael J. Wysocki" , Len Brown , Jeremy Linton , Arnd Bergmann , Linux Kernel Mailing List , ACPI Devel Maling List , Hanjun Guo , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Jan 28, 2020 at 8:28 PM John Garry wrote: > > > >>>> > >>>> Signed-off-by: John Garry > >>>> --- > >>>> drivers/soc/Makefile | 1 + > >>>> drivers/soc/acpi_generic.c | 102 +++++++++++++++++++++++++++++++++++++ > >>>> 2 files changed, 103 insertions(+) > >>>> create mode 100644 drivers/soc/acpi_generic.c > >>>> > >>>> diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile > >>>> index 8b49d782a1ab..2a59a30a22cd 100644 > >>>> --- a/drivers/soc/Makefile > >>>> +++ b/drivers/soc/Makefile > >>>> @@ -3,6 +3,7 @@ > >>>> # Makefile for the Linux Kernel SOC specific device drivers. > >>>> # > >>>> > >>>> +obj-$(CONFIG_ACPI_PPTT) += acpi_generic.o > >>>> obj-$(CONFIG_ARCH_ACTIONS) += actions/ > >>>> obj-$(CONFIG_SOC_ASPEED) += aspeed/ > >>>> obj-$(CONFIG_ARCH_AT91) += atmel/ > >>> > >>> Based on everything I've seen so far, this should go under drivers/acpi instead. > >> > >> soc drivers seem to live in drivers/soc (non-arm32, anyway), so I > >> decided on this location. But drivers/acpi would also seem reasonable now. > > > > Hi Rafael, > > > Any reasons for not putting it into drivers/acpi/pptt.c specifically? > > . > > I don't think so. > > One thing is that the code does a one-time scan of the PPTT to find all > processor package nodes with ID structures to register the soc devices - > so we would need some new call from from acpi_init() for that. Or an extra initcall or similar. [Calls from acpi_init() are basically for things that need to be strictly ordered in a specific way for some reason.] Why would that be a problem?