From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Chuanhong Guo <gch981213@gmail.com>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Tighe Donnelly <tighe.donnelly@protonmail.com>,
Mario Limonciello <mario.limonciello@amd.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6] ACPI: skip IRQ override on AMD Zen platforms
Date: Thu, 14 Jul 2022 20:35:39 +0200 [thread overview]
Message-ID: <CAJZ5v0jjyvWniC8ReZqAgnaoaRm4cr_Vs3pXhddKf9B6+zONLw@mail.gmail.com> (raw)
In-Reply-To: <20220712020058.90374-1-gch981213@gmail.com>
On Tue, Jul 12, 2022 at 4:01 AM Chuanhong Guo <gch981213@gmail.com> wrote:
>
> IRQ override isn't needed on modern AMD Zen systems.
> There's an active low keyboard IRQ on AMD Ryzen 6000 and it will stay
> this way on newer platforms. This IRQ override breaks keyboards for
> almost all Ryzen 6000 laptops currently on the market.
>
> Skip this IRQ override for all AMD Zen platforms because this IRQ
> override is supposed to be a workaround for buggy ACPI DSDT and we can't
> have a long list of all future AMD CPUs/Laptops in the kernel code.
> If a device with buggy ACPI DSDT shows up, a separated list containing
> just them should be created.
>
> Suggested-by: Mario Limonciello <mario.limonciello@amd.com>
> Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
I need an ACK from Mario here.
> ---
> Change sice v5: reworked
>
> drivers/acpi/resource.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index c2d494784425..510cdec375c4 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -416,6 +416,16 @@ static bool acpi_dev_irq_override(u32 gsi, u8 triggering, u8 polarity,
> {
> int i;
>
> +#ifdef CONFIG_X86
> + /*
> + * IRQ override isn't needed on modern AMD Zen systems and
> + * this override breaks active low IRQs on AMD Ryzen 6000 and
> + * newer systems. Skip it.
> + */
> + if (boot_cpu_has(X86_FEATURE_ZEN))
> + return false;
> +#endif
> +
> for (i = 0; i < ARRAY_SIZE(skip_override_table); i++) {
> const struct irq_override_cmp *entry = &skip_override_table[i];
>
> --
> 2.36.1
>
next prev parent reply other threads:[~2022-07-14 18:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 2:00 [PATCH v6] ACPI: skip IRQ override on AMD Zen platforms Chuanhong Guo
2022-07-14 18:35 ` Rafael J. Wysocki [this message]
2022-07-14 19:59 ` Limonciello, Mario
2022-07-18 15:39 ` Limonciello, Mario
2022-07-21 15:12 ` Rafael J. Wysocki
2022-09-28 6:20 ` Jiri Slaby
2022-09-28 8:31 ` Jiri Slaby
2022-09-28 8:57 ` Jiri Slaby
2022-09-30 2:45 ` Chuanhong Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0jjyvWniC8ReZqAgnaoaRm4cr_Vs3pXhddKf9B6+zONLw@mail.gmail.com \
--to=rafael@kernel.org \
--cc=gch981213@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=tighe.donnelly@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).