From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97742C35240 for ; Fri, 31 Jan 2020 12:02:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61E2E20707 for ; Fri, 31 Jan 2020 12:02:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mYoMDYgf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728428AbgAaMCH (ORCPT ); Fri, 31 Jan 2020 07:02:07 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:36875 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728442AbgAaMCH (ORCPT ); Fri, 31 Jan 2020 07:02:07 -0500 Received: by mail-wm1-f67.google.com with SMTP id f129so8387386wmf.2 for ; Fri, 31 Jan 2020 04:02:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mbDxoFJm2oj+qhmVC/5UqLWBu4cSJFdbmCZh1//SVQ4=; b=mYoMDYgfxsoqJFWW3pc1GvButWs7I+ctO4pZCarC+mZtnIJe0Gdqgy27ddJxZxcrz7 SVx7e5lutA81dKlggkTmmmtmSVncGLDGm0cC6fKfjlA0u6DzPGaoLKOEdiEu8oIvwOUT +1x0QGJQD7mIOcsV4HkaPQeHYUxlekwTim81WrJ50UNbhnGtjcOSdsxF8V5n9g7ndF4C 74zpfo3MZvg3Z8jbr0DqnZXLAoAU+CLGgVQmrV2UUQaaNtSZy204apfDLTeEZ9JAzQQw pEXULMN0WgEbIONtu00fIhLezf5FgM3nUMS84Vj5W2qW+vA+qYnJE4psO6bRKgt8WDHH 9sRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mbDxoFJm2oj+qhmVC/5UqLWBu4cSJFdbmCZh1//SVQ4=; b=R84YdYPry/YWa3wjJUrjAar8ttRXPvTbf9nks5ck91Do5D/NYPotAUDSom6p53Xsvz z+MdBoElz0anoKhd5aCL4ww1g1mukhnvhaQwCnCMgjpHAc+aTi37WJ3YS/HyGAOy9qny XsONpgJSb/EodJ31cY5HuudSjOwG6T90aPQwX+cmtxXmCY73515wUyFQ9lj97OcSwUcF L5fXXPRNLRfh+vcC5St6S+a/wkXUykL6L33aFVxbhO2bsgvnNAuKebFi2nejaRmi63PN 3H1n/+vn12P536fDgf6tgY7Do0MeRmYXVdbgxe+HRTr4Yv9o7NILznjNmOsPVfAd750G 436w== X-Gm-Message-State: APjAAAUAef6Mfvoraa257dLGcKyZcof0ZxbuPHTwCD3qLGWaV93hZSb7 g6Q1fhy8PyBbJ+Z2Zu2RSq/AiJT6IwsDjtDkALrRWA== X-Google-Smtp-Source: APXvYqyLtANt7wYq0lzcfnJ4oPim2jg3zsq8GEIuplfKm8PZP6V4fWF6UhT0UKkmPz3Joc4FOM6mQXP4R6uiWrkIJbw= X-Received: by 2002:a05:600c:248:: with SMTP id 8mr11681147wmj.1.1580472123485; Fri, 31 Jan 2020 04:02:03 -0800 (PST) MIME-Version: 1.0 References: <1580198925-50411-1-git-send-email-makarand.pawagi@nxp.com> <20200128110916.GA491@e121166-lin.cambridge.arm.com> <12531d6c569c7e14dffe8e288d9f4a0b@kernel.org> In-Reply-To: <12531d6c569c7e14dffe8e288d9f4a0b@kernel.org> From: Ard Biesheuvel Date: Fri, 31 Jan 2020 13:01:51 +0100 Message-ID: Subject: Re: [EXT] Re: [PATCH] bus: fsl-mc: Add ACPI support for fsl-mc To: Marc Zyngier Cc: Makarand Pawagi , Calvin Johnson , stuyoder@gmail.com, nleeder@codeaurora.org, Ioana Ciornei , Cristi Sovaiala , Hanjun Guo , Will Deacon , Lorenzo Pieralisi , Pankaj Bansal , jon@solid-run.com, Russell King , ACPI Devel Maling List , Len Brown , Jason Cooper , Andy Wang , Varun Sethi , Thomas Gleixner , linux-arm-kernel , Laurentiu Tudor , Paul Yang , "" , "Rafael J. Wysocki" , Linux Kernel Mailing List , Shameerali Kolothum Thodi , Sudeep Holla , Robin Murphy Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, 31 Jan 2020 at 12:06, Marc Zyngier wrote: > > On 2020-01-31 10:35, Makarand Pawagi wrote: > >> -----Original Message----- > >> From: Lorenzo Pieralisi > >> Sent: Tuesday, January 28, 2020 4:39 PM > >> To: Makarand Pawagi > >> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > >> kernel@lists.infradead.org; linux-acpi@vger.kernel.org; > >> linux@armlinux.org.uk; > >> jon@solid-run.com; Cristi Sovaiala ; > >> Laurentiu > >> Tudor ; Ioana Ciornei > >> ; > >> Varun Sethi ; Calvin Johnson > >> ; > >> Pankaj Bansal ; guohanjun@huawei.com; > >> sudeep.holla@arm.com; rjw@rjwysocki.net; lenb@kernel.org; > >> stuyoder@gmail.com; tglx@linutronix.de; jason@lakedaemon.net; > >> maz@kernel.org; shameerali.kolothum.thodi@huawei.com; will@kernel.org; > >> robin.murphy@arm.com; nleeder@codeaurora.org > >> Subject: [EXT] Re: [PATCH] bus: fsl-mc: Add ACPI support for fsl-mc > >> > >> Caution: EXT Email > >> > >> On Tue, Jan 28, 2020 at 01:38:45PM +0530, Makarand Pawagi wrote: > >> > ACPI support is added in the fsl-mc driver. Driver will parse MC DSDT > >> > table to extract memory and other resorces. > >> > > >> > Interrupt (GIC ITS) information will be extracted from MADT table by > >> > drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c. > >> > > >> > IORT table will be parsed to configure DMA. > >> > > >> > Signed-off-by: Makarand Pawagi > >> > --- > >> > drivers/acpi/arm64/iort.c | 53 +++++++++++++++++++++ > >> > drivers/bus/fsl-mc/dprc-driver.c | 3 +- > >> > drivers/bus/fsl-mc/fsl-mc-bus.c | 48 +++++++++++++------ > >> > drivers/bus/fsl-mc/fsl-mc-msi.c | 10 +++- > >> > drivers/bus/fsl-mc/fsl-mc-private.h | 4 +- > >> > drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c | 71 > >> ++++++++++++++++++++++++++++- > >> > include/linux/acpi_iort.h | 5 ++ > >> > 7 files changed, 174 insertions(+), 20 deletions(-) > >> > > >> > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > >> > index 33f7198..beb9cd5 100644 > >> > --- a/drivers/acpi/arm64/iort.c > >> > +++ b/drivers/acpi/arm64/iort.c > >> > @@ -15,6 +15,7 @@ > >> > #include > >> > #include > >> > #include > >> > +#include > >> > #include > >> > #include > >> > > >> > @@ -622,6 +623,29 @@ static int iort_dev_find_its_id(struct device > >> > *dev, u32 req_id, } > >> > > >> > /** > >> > + * iort_get_fsl_mc_device_domain() - Find MSI domain related to a > >> > +device > >> > + * @dev: The device. > >> > + * @mc_icid: ICID for the fsl_mc device. > >> > + * > >> > + * Returns: the MSI domain for this device, NULL otherwise */ struct > >> > +irq_domain *iort_get_fsl_mc_device_domain(struct device *dev, > >> > + u32 mc_icid) { > >> > + struct fwnode_handle *handle; > >> > + int its_id; > >> > + > >> > + if (iort_dev_find_its_id(dev, mc_icid, 0, &its_id)) > >> > + return NULL; > >> > + > >> > + handle = iort_find_domain_token(its_id); > >> > + if (!handle) > >> > + return NULL; > >> > + > >> > + return irq_find_matching_fwnode(handle, DOMAIN_BUS_FSL_MC_MSI); > >> > +} > >> > >> NAK > >> > >> I am not willing to take platform specific code in the generic IORT > >> layer. > >> > >> ACPI on ARM64 works on platforms that comply with SBSA/SBBR > >> guidelines: > >> > >> > >> https://developer.arm.com/architectures/platform-design/server-systems > >> > >> Deviating from those requires butchering ACPI specifications (ie IORT) > >> and > >> related kernel code which goes totally against what ACPI is meant for > >> on ARM64 > >> systems, so there is no upstream pathway for this code I am afraid. > >> > > Reason of adding this platform specific function in the generic IORT > > layer is > > That iort_get_device_domain() only deals with PCI bus > > (DOMAIN_BUS_PCI_MSI). > > > > fsl-mc objects when probed, need to find irq_domain which is associated > > with > > the fsl-mc bus (DOMAIN_BUS_FSL_MC_MSI). It will not be possible to do > > that > > if we do not add this function because there are no other suitable APIs > > exported > > by IORT layer to do the job. > > I think we all understood the patch. What both Lorenzo and myself are > saying is > that we do not want non-PCI support in IORT. > IORT supports platform devices (aka named components) as well, and there is some support for platform MSIs in the GIC layer. So it may be possible to hide your exotic bus from the OS entirely, and make the firmware instantiate a DSDT with device objects and associated IORT nodes that describe whatever lives on that bus as named components. That way, you will not have to change the OS at all, so your hardware will not only be supported in linux v5.7+, it will also be supported by OSes that commercial distro vendors are shipping today. *That* is the whole point of using ACPI. If you are going to bother and modify the OS, you lose this advantage, and ACPI gives you no benefit over DT at all.