From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: Re: [RFC PATCH] gpio/acpi: set direction for ACPI OpRegion GPIOs
Date: Wed, 29 May 2019 12:50:51 +0200 [thread overview]
Message-ID: <CAKv+Gu_N2OC6mMcpvmz+gqa2cNaCf+ALe-tc0z+s4kDDi1RK3w@mail.gmail.com> (raw)
In-Reply-To: <20190529102747.GI2781@lahna.fi.intel.com>
On Wed, 29 May 2019 at 12:27, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> On Wed, May 29, 2019 at 12:13:42PM +0200, Ard Biesheuvel wrote:
> > The ACPI GPIO OpRegion code never sets the direction for GPIOs that
> > it configures from scratch, leaving unconfigured GPIOs to be left
> > at the default direction, which is typically input not output.
>
> The code does:
>
> enum gpiod_flags flags = acpi_gpio_to_gpiod_flags(agpio);
>
> before it requests the GPIO. Isn't that sufficient?
Yes, it works if I set the PullXxx value explicitly in the GpioIo() resource.
prev parent reply other threads:[~2019-05-29 10:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 10:13 [RFC PATCH] gpio/acpi: set direction for ACPI OpRegion GPIOs Ard Biesheuvel
2019-05-29 10:27 ` Mika Westerberg
2019-05-29 10:50 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu_N2OC6mMcpvmz+gqa2cNaCf+ALe-tc0z+s4kDDi1RK3w@mail.gmail.com \
--to=ard.biesheuvel@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).