From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8A81C433FE for ; Tue, 11 Oct 2022 16:43:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229638AbiJKQnx (ORCPT ); Tue, 11 Oct 2022 12:43:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbiJKQnw (ORCPT ); Tue, 11 Oct 2022 12:43:52 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BED4DA2A9B for ; Tue, 11 Oct 2022 09:43:50 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id i3so14016691pfk.9 for ; Tue, 11 Oct 2022 09:43:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4cQLsLHBibKCXET80IomNLXe7aKtZBxMhsEFPZH1Ilw=; b=NbElJqk8KLlSeynJnSBpTuSUqK+dlJYSfjhESozbJipfngxmf7ra2Ycw3zm/u4nHA6 6vCmS1QuGcgLscl9XWSAOOAwqpHu/sLmhW/XVhKgvzGBGCZ/qhUBgWEvOkoBPtK0lkaY TMu10prmH3kqlnb2mx2V7ssj2qI05plyUVofdlecVN79yA09z/4j3zgJcZzp6D9Hr0dI rUsUQb27ndeQNA1LLQbIerUw2VZwNwoNuYbuV0t3igIjp6CvQF3wICa0zY+8b3t2v294 7w9WckZyZtFM/7TCDHn64q6XmEv9WMw7LtNZaQjYoBUCG2PPyTAhNC8AgCrhRQWhI1Ok U1dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4cQLsLHBibKCXET80IomNLXe7aKtZBxMhsEFPZH1Ilw=; b=514jEufQT6FLZAVgBUkFlTp/FlYPynD6ENw0vBt7nOP/8Ju1sihmtEKDcHOF4nH48N 5wiO85B4oQp9DwNOyUu3yKygiQGljxTdoZZffmkgwUMVuEX+bgUPWYQlZhb8Zm/tS9Vf rancT3wvHwQQzOr5a4ekCZNO1GvoOYLfGAKWKs0XpOmch6Mg7BBpdB7CcRKqkkbdPOls dVHd0Djy94vujcdlfgmxqBIiF4LQPHyC82GpwK7DLAVUk4yyTNS6F8YPbaKWXZ2LhXkn DQ3kXdOyMYsxaIMchE8KATGP7YV0c050TzUXlAU5hzOfQKduik90VuhlUzZBhiYfPYUs 0pbg== X-Gm-Message-State: ACrzQf21aQt6M4SSDP43R4xP8xYaR7EYWwyjPTtX+bn/7iPqUHsvIW0h nYrsCXIrHO7VtyFWiJzJ99Yn18BU1r11fVx73/Hz7Q== X-Google-Smtp-Source: AMsMyM4rvA/2n5H3Zcyx4WXYAkabqtuxLr5z5RO3dT1uqSNjwxQckRtR8KJxEieT2UD4Lcinf1i3GQzKzRSuDjeW99o= X-Received: by 2002:a05:6a00:1748:b0:563:8346:12ea with SMTP id j8-20020a056a00174800b00563834612eamr8498810pfc.23.1665506629981; Tue, 11 Oct 2022 09:43:49 -0700 (PDT) MIME-Version: 1.0 References: <20221011031843.960217-1-masahiroy@kernel.org> <08db7754-ecd8-4425-875b-4f2b44497f6b@app.fastmail.com> In-Reply-To: <08db7754-ecd8-4425-875b-4f2b44497f6b@app.fastmail.com> From: Nick Desaulniers Date: Tue, 11 Oct 2022 09:43:38 -0700 Message-ID: Subject: Re: [RFC PATCH] Remove Intel compiler support To: Arnd Bergmann , Masahiro Yamada Cc: Linus Torvalds , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Greg Kroah-Hartman , linux-ia64@vger.kernel.org, Miguel Ojeda , Len Brown , Nathan Chancellor , Nick Terrell , "Rafael J. Wysocki" , Robert Moore , Tom Rix , devel@acpica.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Oct 11, 2022 at 8:18 AM Arnd Bergmann wrote: > > On Tue, Oct 11, 2022, at 5:18 AM, Masahiro Yamada wrote: > > include/linux/compiler-intel.h had no update in the past 3 years. > > > > We often forget about the third C compiler to build the kernel. > > > > For example, commit a0a12c3ed057 ("asm goto: eradicate CC_HAS_ASM_GOTO") > > only mentioned GCC and Clang. > > > > init/Kconfig defines CC_IS_GCC and CC_IS_CLANG but not CC_IS_ICC, > > and nobody has reported any issue. > > > > I guess the Intel Compiler support is broken, and nobody is caring > > about it. > > > > Signed-off-by: Masahiro Yamada > > --- > > > > I am sending this to Linus and the x86 maintainers with RFC. > > If somebody is still using ICC, please speak up! > > Acked-by: Arnd Bergmann > > > I had the same thought a while back and tried to show that it as > already broken, but I never managed to actually download the compiler > at the time. > > It appears that in the meantime, Intel have completely dropped their > old codebase and moved to using LLVM[1], so my guess is that with the > current releases it will behave the same as clang. It might help > to verify that this is indeed the case if you want to add that > to the changelog text. This is my thought, too. I'm happy to help folks working on icx to get icx up and running for kernel builds, if there's interest. Change LGTM; there's probably some refactoring we might be able to do as a result of this; we might be able to move more common definitions out of include/linux/compiler-gcc.h and include/linux/compiler-clang.h into include/linux/compiler_types.h, but that can wait until after this change. Reviewed-by: Nick Desaulniers > > Arnd > > [1] https://www.intel.com/content/www/us/en/developer/articles/technical/adoption-of-llvm-complete-icx.html -- Thanks, ~Nick Desaulniers