From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1AC3C433E7 for ; Thu, 8 Oct 2020 16:35:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57720221FE for ; Thu, 8 Oct 2020 16:35:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602174922; bh=Qlahj53lYVNiYg7AJ2rpRjvr+jIGD1GKJKKVML4NVdo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=SyWtdixzfqtX5pe79DS7aqBHjAtRgmDXZCtjZsbGpdYI0iatRskWJhQs+4qMWG2Df qFngwb9cNICUSqaTyxQY6XzPmipqFzhF1TnEZK02R/udrMYTzzxarhZKdhjpqqV7/8 6V+ypYqpU7nQq/fIvDxxQvBz7bYhq7L+mtYh7IzE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728421AbgJHQfV (ORCPT ); Thu, 8 Oct 2020 12:35:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:57234 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726029AbgJHQfT (ORCPT ); Thu, 8 Oct 2020 12:35:19 -0400 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0103E221FE; Thu, 8 Oct 2020 16:35:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602174919; bh=Qlahj53lYVNiYg7AJ2rpRjvr+jIGD1GKJKKVML4NVdo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JVjGIr/dcnN1xksiqNbG+5EbegsU/oIDX9jUBqAS8FdCiPm8u2/qWXBDB5A5SPFTI BT867zshbo4KKSkX6On8oFk14J9agHw/y0p3/tUCfKwANiGzETo77Iy2nIexDbM5qM XppPODIVfAmfdTX/Ba5zWmqqdjewjp/z+lEODdI8= Received: by mail-ot1-f51.google.com with SMTP id f37so6007514otf.12; Thu, 08 Oct 2020 09:35:18 -0700 (PDT) X-Gm-Message-State: AOAM5308ejA7VVCA00+mx+0sroV9fwEpwbzYWpWLV5uN5ahWHAnVE86b dUjU8i1XFHZM0WrdY7mp/KRXwgjhtFWTsRO6Xw== X-Google-Smtp-Source: ABdhPJzz60BjsjQ+DWcXVfNZRYE1T6Qcp8v32Xy9DdbXcoosuL4xmpiD0xFSdwduI7ZjY+c1MvZxTW+StDleIYmrSl8= X-Received: by 2002:a9d:1c90:: with SMTP id l16mr5952657ota.192.1602174918204; Thu, 08 Oct 2020 09:35:18 -0700 (PDT) MIME-Version: 1.0 References: <20201008144706.8212-1-calvin.johnson@oss.nxp.com> In-Reply-To: <20201008144706.8212-1-calvin.johnson@oss.nxp.com> From: Rob Herring Date: Thu, 8 Oct 2020 11:35:07 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [net-next PATCH v1] net: phy: Move of_mdio from drivers/of to drivers/net/mdio To: Calvin Johnson Cc: Florian Fainelli , Grant Likely , Jeremy Linton , Andrew Lunn , Andy Shevchenko , Russell King - ARM Linux admin , Cristi Sovaiala , Florin Laurentiu Chiculita , Ioana Ciornei , Madalin Bucur , Heikki Krogerus , Diana Madalina Craciun , netdev , Laurentiu Tudor , linux-arm-kernel , "linux-kernel@vger.kernel.org" , "open list:ACPI FOR ARM64 (ACPI/arm64)" , linux.cj@gmail.com, "David S. Miller" , Frank Rowand , Heiner Kallweit , Jakub Kicinski , Mauro Carvalho Chehab , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Oct 8, 2020 at 9:47 AM Calvin Johnson wrote: > > Better place for of_mdio.c is drivers/net/mdio. > Move of_mdio.c from drivers/of to drivers/net/mdio One thing off my todo list. I'd started this ages ago[1]. > > Signed-off-by: Calvin Johnson > --- > > MAINTAINERS | 2 +- > drivers/net/mdio/Kconfig | 8 ++++++++ > drivers/net/mdio/Makefile | 2 ++ > drivers/{of => net/mdio}/of_mdio.c | 0 > drivers/of/Kconfig | 7 ------- > drivers/of/Makefile | 1 - > 6 files changed, 11 insertions(+), 9 deletions(-) > rename drivers/{of => net/mdio}/of_mdio.c (100%) of_mdio.c is really a combination of mdio and phylib functions, so it should be split up IMO. With that, I think you can get rid of CONFIG_OF_MDIO. See my branch[1] for what I had in mind. But that can be done after this if the net maintainers prefer. Acked-by: Rob Herring Rob [1] git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git dt/move-net