From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FE10C38A2A for ; Thu, 7 May 2020 13:49:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECF7E2073A for ; Thu, 7 May 2020 13:49:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588859360; bh=Y80LahXgKe9aD4SesvsSscumeX54TGslpdqTZX/bqZQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=pSzAQfQnx4vz3/exfCy+eH2JAkRp4x+9pHcvz5EXffvB2hPPtLPyhP8iysFoS1ZII qd7cIJaXn7B2decgval6mJec+g3r+P6Nxh0rbfRohhGHvebnmYa36HeWJE/cZrKqR6 vyRUtB050+7nyMlSLuSsranysr1vBAFX96pnO+ac= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725939AbgEGNtT (ORCPT ); Thu, 7 May 2020 09:49:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:53378 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725914AbgEGNtR (ORCPT ); Thu, 7 May 2020 09:49:17 -0400 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5F6732083B for ; Thu, 7 May 2020 13:49:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588859356; bh=Y80LahXgKe9aD4SesvsSscumeX54TGslpdqTZX/bqZQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=1BTed9ewcsXvnnDDcVvEElouNM72YH7BTToCr9y3v6Ch4jsDHMmG3XPaurACgCHWz FHC7eR7WU0fjyk46TlW49pQv1yYsHynYW/uhtzJkJeiT1RVXlZ/XyEBumKLe698v2C cXvsOhMOpr8FVDfSvJbPjB1j1EyNcQWiTXMxQKGQ= Received: by mail-io1-f51.google.com with SMTP id i19so3865679ioh.12 for ; Thu, 07 May 2020 06:49:16 -0700 (PDT) X-Gm-Message-State: AGi0PuZDfNWRuMy/aXFM4JzJ1ZXfLc4f/5/EGqhei/Rs0LZfoWAe73UP 4uDdPnM0Tin16BALs0byoqNYl2bs+s6VEx782O8= X-Google-Smtp-Source: APiQypL2NHEgs2rvwfrzhTk58JvNGGA087lX1dAPFABa6q/geCppW4/1rQCT4O5DS9ilqochTzOQyzniC1V91BeoMEE= X-Received: by 2002:a6b:ef03:: with SMTP id k3mr14013067ioh.203.1588859355786; Thu, 07 May 2020 06:49:15 -0700 (PDT) MIME-Version: 1.0 References: <1588858868-18039-1-git-send-email-guohanjun@huawei.com> In-Reply-To: <1588858868-18039-1-git-send-email-guohanjun@huawei.com> From: Ard Biesheuvel Date: Thu, 7 May 2020 15:49:04 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ACPI: IORT: Add extra message "applying workaround" for off-by-1 issue To: Hanjun Guo Cc: Lorenzo Pieralisi , "Rafael J. Wysocki" , Sudeep Holla , Will Deacon , ACPI Devel Maling List , Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, 7 May 2020 at 15:47, Hanjun Guo wrote: > > As we already applied a workaround for the off-by-1 issue, > it's good to add extra message "applying workaround" to > make people less uneasy to see such message in the boot log. > > Signed-off-by: Hanjun Guo Hi Hanjun, > --- > > Based on top of for-next/acpi branch of ARM64 repo > > drivers/acpi/arm64/iort.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > index b011d25..f3d492a 100644 > --- a/drivers/acpi/arm64/iort.c > +++ b/drivers/acpi/arm64/iort.c > @@ -328,7 +328,7 @@ static int iort_id_map(struct acpi_iort_id_mapping *map, u8 type, u32 rid_in, > * Otherwise, things are *really* broken, and we just disregard > * duplicate matches entirely to retain compatibility. > */ > - pr_err(FW_BUG "[map %p] conflicting mapping for input ID 0x%x\n", > + pr_err(FW_BUG "[map %p] conflicting mapping for input ID 0x%x, applying workaround\n", This is not correct. The workaround is only applied if rid_in == map->input_base, so better to print a second line after the 'return' below that is only reached in that particular case. > map, rid_in); > if (rid_in != map->input_base) > return -ENXIO; > -- > 1.7.12.4 >