From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-i2c <linux-i2c@vger.kernel.org>,
Wolfram Sang <wsa@the-dreams.de>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rajmohan Mani <rajmohan.mani@intel.com>,
Tomasz Figa <tfiga@chromium.org>,
Bingbu Cao <bingbu.cao@intel.com>,
Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>,
Hyungwoo Yang <hyungwoo.yang@intel.com>,
linux-media <linux-media@vger.kernel.org>
Subject: Re: [PATCH v10 7/7] at24: Support probing while off
Date: Mon, 8 Feb 2021 17:44:17 +0100 [thread overview]
Message-ID: <CAMpxmJU7J9JBSwCN+GLDpuOL=iZ1PH=oZZuGiAyovuf2TQ=o9A@mail.gmail.com> (raw)
In-Reply-To: <20210205132505.20173-8-sakari.ailus@linux.intel.com>
On Fri, Feb 5, 2021 at 2:25 PM Sakari Ailus
<sakari.ailus@linux.intel.com> wrote:
>
> In certain use cases (where the chip is part of a camera module, and the
> camera module is wired together with a camera privacy LED), powering on
> the device during probe is undesirable. Add support for the at24 to
> execute probe while being powered off. For this to happen, a hint in form
> of a device property is required from the firmware.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Reviewed-by: Tomasz Figa <tfiga@chromium.org>
> ---
I'll ack this but I still claim that the name
acpi_dev_state_low_power() is super misleading for this use-case and
I've been saying that for 10 versions now with everyone just ignoring
my remarks. :/
Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
next prev parent reply other threads:[~2021-02-08 16:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 13:24 [PATCH v10 0/7] Support running driver's probe for a device powered off Sakari Ailus
2021-02-05 13:24 ` [PATCH v10 1/7] ACPI: scan: Obtain device's desired enumeration power state Sakari Ailus
2021-02-05 13:25 ` [PATCH v10 2/7] i2c: Allow an ACPI driver to manage the device's power state during probe Sakari Ailus
2021-02-09 21:04 ` Wolfram Sang
2021-02-10 20:46 ` Sakari Ailus
2021-02-10 22:27 ` Sakari Ailus
2021-02-12 7:18 ` Wolfram Sang
2021-02-05 13:25 ` [PATCH v10 3/7] Documentation: ACPI: Document _DSE object usage for enum power state Sakari Ailus
2021-02-06 0:56 ` Randy Dunlap
2021-02-08 8:01 ` Sakari Ailus
2021-02-08 15:52 ` Randy Dunlap
2021-02-05 13:25 ` [PATCH v10 4/7] ACPI: Add a convenience function to tell a device is in low " Sakari Ailus
2021-02-05 13:25 ` [PATCH v10 5/7] ov5670: Support probe whilst the device is in a " Sakari Ailus
2021-02-05 13:25 ` [PATCH v10 6/7] media: i2c: imx319: Support probe while the device is off Sakari Ailus
2021-02-05 13:25 ` [PATCH v10 7/7] at24: Support probing while off Sakari Ailus
2021-02-08 16:44 ` Bartosz Golaszewski [this message]
2021-02-08 16:54 ` Rafael J. Wysocki
2021-02-09 15:49 ` Bartosz Golaszewski
2021-02-09 16:23 ` Sakari Ailus
2021-02-09 16:42 ` Rafael J. Wysocki
2021-02-09 16:54 ` Sakari Ailus
2021-02-09 16:58 ` Rafael J. Wysocki
2021-02-10 8:41 ` Sakari Ailus
2021-02-10 12:26 ` Bartosz Golaszewski
2021-02-10 20:46 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMpxmJU7J9JBSwCN+GLDpuOL=iZ1PH=oZZuGiAyovuf2TQ=o9A@mail.gmail.com' \
--to=bgolaszewski@baylibre.com \
--cc=bingbu.cao@intel.com \
--cc=chiranjeevi.rapolu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hyungwoo.yang@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rajmohan.mani@intel.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).