From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FD8CC433E6 for ; Tue, 16 Feb 2021 12:59:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D32364E04 for ; Tue, 16 Feb 2021 12:59:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229912AbhBPM7e (ORCPT ); Tue, 16 Feb 2021 07:59:34 -0500 Received: from mail-oo1-f44.google.com ([209.85.161.44]:33618 "EHLO mail-oo1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229790AbhBPM7b (ORCPT ); Tue, 16 Feb 2021 07:59:31 -0500 Received: by mail-oo1-f44.google.com with SMTP id f1so2260750oou.0; Tue, 16 Feb 2021 04:59:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TVzLBkqKt0MyMwotNPEi8xMZ2SypGbVfWBR5eQRTmO0=; b=TSrlLp/dLEvzVgYJtBCOI3GotDN81ZyYyNXCWTYNpHQgk7Li5hOwwdA5DI2aVSvN9u QICOgn7PbSKOcD4TmUPyNR7oKuxBs3DRmjIHypg4EVgbNimg6pKuT5bwMw7moz4dwLlL gjdt7k5aWaERMGI3+fJDXSrlHu2OJ9hawJ1IIJ519xcScgkh+VYkKXqvBJEeJYysa/jh YXE+7Ldl1Zi4IScqJWUOTLySBilR7SJVmtB2c1olcSBMQ1p5so5ih9WB4v9f2GCIdtQX 90JznuDtxze58Ae7oSVog6crOzMwV4EJrKQef2q+3GOVSCtmHuJyt0kO8hHSu38Bx9ch Kc3w== X-Gm-Message-State: AOAM533dFVUWMFTeNpqtYrlApLDE2W6QZi7whbG0yNmAx4DrvYCjd2vI GNT/Gs4D//cYdXj1Xg9+ht5WAUkYOp5oeLp67ns= X-Google-Smtp-Source: ABdhPJxqORgG+iXS2MUSd76bl5TBZKlc/qcbt9O7R3tRFXJ0lESsAEHwXxj7DFW88YmAQPIcXwkV95yEjue34nqZXjY= X-Received: by 2002:a4a:ab08:: with SMTP id i8mr13952968oon.40.1613480328418; Tue, 16 Feb 2021 04:58:48 -0800 (PST) MIME-Version: 1.0 References: <20210205222644.2357303-1-saravanak@google.com> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 16 Feb 2021 13:58:37 +0100 Message-ID: Subject: Re: [PATCH v4 0/8] Make fw_devlink=on more forgiving To: Saravana Kannan Cc: Jonathan Corbet , Greg Kroah-Hartman , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , Len Brown , Len Brown , Pavel Machek , Michael Turquette , Stephen Boyd , Rob Herring , Frank Rowand , Marc Zyngier , Thomas Gleixner , "open list:DOCUMENTATION" , Linux Kernel Mailing List , Linux PM list , linux-clk , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , ACPI Devel Maling List , Marek Szyprowski , Android Kernel Team , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi Saravana, On Mon, Feb 15, 2021 at 10:57 PM Saravana Kannan wrote: > On Mon, Feb 15, 2021 at 7:16 AM Geert Uytterhoeven wrote: > > On Fri, Feb 12, 2021 at 4:00 AM Saravana Kannan wrote: > > > On Thu, Feb 11, 2021 at 5:00 AM Geert Uytterhoeven wrote: > > > > 1. R-Car Gen2 (Koelsch), R-Car Gen3 (Salvator-X(S), Ebisu). > > > > > > > > - Commit 2dfc564bda4a31bc ("soc: renesas: rcar-sysc: Mark device > > > > node OF_POPULATED after init") is no longer needed (but already > > > > queued for v5.12 anyway) > > > > > > Rob doesn't like the proliferation of OF_POPULATED and we don't need > > > it anymore, so maybe work it out with him? It's a balance between some > > > wasted memory (struct device(s)) vs not proliferating OF_POPULATED. > > > > > > 2. SH/R-Mobile AG5 (kzm9g), APE6 (ape6evm), A1 (armadillo800-eva) > > > > > > > > - "PATCH] soc: renesas: rmobile-sysc: Set OF_POPULATED and absorb > > > > reset handling" is no longer needed > > > > https://lore.kernel.org/linux-arm-kernel/20210205133319.1921108-1-geert+renesas@glider.be/ > > > > > > Good to see more evidence that this series is fixing things at a more > > > generic level. > > > > I spoke too soon: if CONFIG_POWER_RESET_RMOBILE=n, > > booting fails again, as everything is waiting on the system controller, > > which never becomes available. > > Rcar-sysc doesn't suffer from this problem, cfr. above. > > Perhaps because the rmobile-sysc bindings use a hierarchical instead > > of a linear PM domain description, and thus consumers point to the > > children of the system controller node? > > Cfr. system-controller@e6180000 in arch/arm/boot/dts/r8a7740.dtsi. > > Ok, I see what's going on. The problem is that the "power domain" > fwnode being registered is not the node that contains the "compatible" > property and becomes a device. So this patch[1] is not helping here. > Fix is to do something like this (to avoid using OF_POPULATED flag and > breaking reset): > > diff --git a/drivers/soc/renesas/rmobile-sysc.c > b/drivers/soc/renesas/rmobile-sysc.c > index 9046b8c933cb..b7e66139ef7d 100644 > --- a/drivers/soc/renesas/rmobile-sysc.c > +++ b/drivers/soc/renesas/rmobile-sysc.c > @@ -344,6 +344,7 @@ static int __init rmobile_init_pm_domains(void) > of_node_put(np); > break; > } > + fwnode_dev_initialized(&np->fwnode, true); > } > > put_special_pds(); > > Can you give it a shot? Thanks, works. Patch sent "[PATCH v2] soc: renesas: rmobile-sysc: Mark fwnode when PM domain is added" https://lore.kernel.org/linux-arm-kernel/20210216123958.3180014-1-geert+renesas@glider.be/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds