From: Dan Williams <dan.j.williams@intel.com>
To: Jia He <justin.he@arm.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
Linux NVDIMM <nvdimm@lists.linux.dev>,
Linux ACPI <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] ACPI: NFIT: Use fallback node id when numa info in NFIT table is incorrect
Date: Wed, 22 Sep 2021 11:02:32 -0700 [thread overview]
Message-ID: <CAPcyv4giSfXxf-GzmvKBvUExfuYZTjfjOSzK74PzQb3jmv6H=w@mail.gmail.com> (raw)
In-Reply-To: <20210922152919.6940-1-justin.he@arm.com>
On Wed, Sep 22, 2021 at 8:29 AM Jia He <justin.he@arm.com> wrote:
>
> When ACPI NFIT table is failing to populate correct numa information
> on arm64, dax_kmem will get NUMA_NO_NODE from the NFIT driver.
>
> Without this patch, pmem can't be probed as RAM devices on arm64 guest:
> $ndctl create-namespace -fe namespace0.0 --mode=devdax --map=dev -s 1g -a 128M
> kmem dax0.0: rejecting DAX region [mem 0x240400000-0x2bfffffff] with invalid node: -1
> kmem: probe of dax0.0 failed with error -22
>
I'll add:
Cc: <stable@vger.kernel.org>
Fixes: c221c0b0308f ("device-dax: "Hotplug" persistent memory for use
like normal RAM")
...other than that, looks good to me.
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Jia He <justin.he@arm.com>
> ---
> drivers/acpi/nfit/core.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index a3ef6cce644c..7dd80acf92c7 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -3007,6 +3007,18 @@ static int acpi_nfit_register_region(struct acpi_nfit_desc *acpi_desc,
> ndr_desc->target_node = NUMA_NO_NODE;
> }
>
> + /* Fallback to address based numa information if node lookup failed */
> + if (ndr_desc->numa_node == NUMA_NO_NODE) {
> + ndr_desc->numa_node = memory_add_physaddr_to_nid(spa->address);
> + dev_info(acpi_desc->dev, "changing numa node from %d to %d for nfit region [%pa-%pa]",
> + NUMA_NO_NODE, ndr_desc->numa_node, &res.start, &res.end);
> + }
> + if (ndr_desc->target_node == NUMA_NO_NODE) {
> + ndr_desc->target_node = phys_to_target_node(spa->address);
> + dev_info(acpi_desc->dev, "changing target node from %d to %d for nfit region [%pa-%pa]",
> + NUMA_NO_NODE, ndr_desc->numa_node, &res.start, &res.end);
> + }
> +
> /*
> * Persistence domain bits are hierarchical, if
> * ACPI_NFIT_CAPABILITY_CACHE_FLUSH is set then
> --
> 2.17.1
>
prev parent reply other threads:[~2021-09-22 18:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 15:29 [PATCH] ACPI: NFIT: Use fallback node id when numa info in NFIT table is incorrect Jia He
2021-09-22 18:02 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4giSfXxf-GzmvKBvUExfuYZTjfjOSzK74PzQb3jmv6H=w@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=justin.he@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).