From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93B49C433DF for ; Mon, 18 May 2020 17:20:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 709E5207FB for ; Mon, 18 May 2020 17:20:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="PuiVlzFg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728280AbgERRUg (ORCPT ); Mon, 18 May 2020 13:20:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727020AbgERRUg (ORCPT ); Mon, 18 May 2020 13:20:36 -0400 Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D277EC05BD0A for ; Mon, 18 May 2020 10:20:35 -0700 (PDT) Received: by mail-ed1-x541.google.com with SMTP id e10so9152369edq.0 for ; Mon, 18 May 2020 10:20:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GgTcEd+caanrx1t1o1gL/Ypc50CeCw/F8i23bYyVrUw=; b=PuiVlzFghkrRKLS1pILHxv+676poFWDYeHwwBLU2TzTknD+dFYLk0xk+5TDy5pgW64 qhuwEWP7J2W6vsJz9bxByoo2dcZ36iMpyHBw7XLV0g5MUF4S816ICg1DZOwDObAlCM3l jlS2qNoPNiw16Z9LbJPF9al5A655ElOJAWZCiLcMB/bVFyCP105iTKNVuysDuncWhyKd BhtMjOTMlylTNZO9ZnTXwTC3GcHLAoPHCQ+Rc0wCdFGDFSgZbzPR0IlAhtNd6yFRaXUC QFTeTJBaBJG91RBZss95qPo8+kfKyS7kah/YxohaMXsSe2dPgCxaCsSp+E0yeuj4kHg4 cGjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GgTcEd+caanrx1t1o1gL/Ypc50CeCw/F8i23bYyVrUw=; b=hL7XJk345mJcoQD43/i/Fb37rj4tzG7r2Wp7oGPCffOCyklcvumr+SA11KjeZwwzW7 qJQWd6Qz9RBRC26SfhU29LzJEVHAzXrsHCFOFlz1uciltaCh5Ebhxyrs1Mq7EdnPIFy+ OcKeVTRHhUVpXfgxixlLKemYf9Q9jDB+42BPyXYv1YX/E2IcYrkQI7Z46ds9gCh82mbd B0rbLeNdoPMu4Cm/88dasxwJ07QwI4Lgj4XGMablBzKl0UwZEmZtDXZqpzKnnLEhqwFN epD8qB9/faGHDlPc96ewfGhEqpfujUtPpc8KrqUBBweVFG6lxD9C/mj7328kd//pZPwi hNjg== X-Gm-Message-State: AOAM532r7N5VWyEamhAqZXctkCUP1BB5smor2Zo8wcj5lIVyAfStiiRj 2TFpIS23xebaExbK7hm+tvDLg5dvgM5ilFFAgONI+g== X-Google-Smtp-Source: ABdhPJz5bmBALzw+D9Jia6d4zvkIV02xWwFo/oM2e8pEt1WN25M6AUsNVPV+EY0iKhYAw1fQk4Bl1vsVwJ4nmUApjn8= X-Received: by 2002:a05:6402:1c1e:: with SMTP id ck30mr14064996edb.154.1589822434411; Mon, 18 May 2020 10:20:34 -0700 (PDT) MIME-Version: 1.0 References: <20200428003214.3764-1-david.e.box@linux.intel.com> <20200428051312.GB17146@lst.de> <20200428142247.GB5439@lst.de> <296064bbcf702744bf603932c9d849307db2e5b7.camel@intel.com> In-Reply-To: From: Dan Williams Date: Mon, 18 May 2020 10:20:23 -0700 Message-ID: Subject: Re: [PATCH 0/2] Add support for StorageD3Enable _DSD property To: David Woodhouse Cc: "hch@lst.de" , "david.e.box@linux.intel.com" , "linux-nvme@lists.infradead.org" , "sagi@grimberg.me" , "lenb@kernel.org" , "rjw@rjwysocki.net" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-pci@vger.kernel.org" , "axboe@fb.com" , "kbusch@kernel.org" , "bhelgaas@google.com" Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, May 18, 2020 at 6:52 AM David Woodhouse wrote: > > On Wed, 2020-04-29 at 05:20 +0000, Williams, Dan J wrote: > > The *patch* is not trying to overrule NVME, and the best I can say is > > that the Intel Linux team was not in the loop when this was being > > decided between the platform BIOS implemenation and whomever thought > > they could just publish random ACPI properties that impacted NVME > > operation [1]. > > > > So now David is trying to get these platform unbroken because they are > > already shipping with this b0rkage. > > This is what we have WARN_TAINT() for though, right? It can suitably > warn users when such breakage is detected in the platform. > I see WARN_TAINT() as "BIOS implemented its specification wrong". This case is BIOS "implemented a mechanism in the wrong specification".