From: Asmaa Mnebhi <asmaa@nvidia.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"niyas.sait@linaro.org" <niyas.sait@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: RE: [PATCH v5 2/2] pinctrl: pinctrl-mlxbf: Add pinctrl driver support
Date: Wed, 15 Mar 2023 21:45:06 +0000 [thread overview]
Message-ID: <CH2PR12MB38951C5F7140436C118EFD77D7BF9@CH2PR12MB3895.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAHp75VeMWvywh1PmA5SxStqM17e4KjU1voPr2rdYCyZVdEsRPA@mail.gmail.com>
> > +struct mlxbf3_pinctrl {
> > + void __iomem *fw_ctrl_set0;
> > + void __iomem *fw_ctrl_clr0;
> > + void __iomem *fw_ctrl_set1;
> > + void __iomem *fw_ctrl_clr1;
>
> > + struct device *dev;
> > + struct pinctrl_dev *pctl;
>
> Depending on what is used more often in the code you can shuffle the order
> and save a few bytes in the generated code. You may play with bloat-o-
> meter to check.
I moved around some of the structs above and it hasn’t changed the size of the struct. I also played around
With bloat-o-meter to compare the generated .o files and I don’t see a difference.
next prev parent reply other threads:[~2023-03-15 21:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 22:16 [PATCH v5 0/2] Support Nvidia BlueField-3 GPIO driver and pin controller Asmaa Mnebhi
2023-03-14 22:16 ` [PATCH v5 1/2] gpio: gpio-mlxbf3: Add gpio driver support Asmaa Mnebhi
2023-03-15 9:15 ` Andy Shevchenko
2023-03-15 9:24 ` Andy Shevchenko
2023-03-14 22:16 ` [PATCH v5 2/2] pinctrl: pinctrl-mlxbf: Add pinctrl " Asmaa Mnebhi
2023-03-15 9:21 ` Andy Shevchenko
2023-03-15 9:23 ` Andy Shevchenko
2023-03-15 21:45 ` Asmaa Mnebhi [this message]
2023-03-15 9:22 ` [PATCH v5 0/2] Support Nvidia BlueField-3 GPIO driver and pin controller Andy Shevchenko
2023-03-15 10:12 ` Linus Walleij
2023-03-15 13:11 ` Asmaa Mnebhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH2PR12MB38951C5F7140436C118EFD77D7BF9@CH2PR12MB3895.namprd12.prod.outlook.com \
--to=asmaa@nvidia.com \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niyas.sait@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).