Linux-ACPI Archive on lore.kernel.org
 help / color / Atom feed
* [RESEND PATCH] acpi: Add NHLT table signature
@ 2020-03-20 19:27 Cezary Rojewski
  2020-03-21 10:35 ` Rafael J. Wysocki
  0 siblings, 1 reply; 3+ messages in thread
From: Cezary Rojewski @ 2020-03-20 19:27 UTC (permalink / raw)
  To: linux-acpi
  Cc: linux-kernel, erik.schmauss, lenb, rafael, Cezary Rojewski,
	Erik Kaneda, Robert Moore, Rafael J . Wysocki

NHLT (Non-HDAudio Link Table) provides configuration of audio
endpoints for Intel SST (Smart Sound Technology) DSP products. Similarly
to other ACPI tables, data provided by BIOS may not describe it
correctly, thus overriding is required.

ACPI override mechanism checks for unknown signature before proceeding.
Update known signatures array to support NHLT.

Cc: Erik Kaneda <erik.kaneda@intel.com>
Cc: Robert Moore <robert.moore@intel.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
 drivers/acpi/tables.c | 2 +-
 include/acpi/actbl2.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index 180ac4329763..0e905c3d1645 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -501,7 +501,7 @@ static const char * const table_sigs[] = {
 	ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
 	ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
 	ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
-	NULL };
+	ACPI_SIG_NHLT, NULL };
 
 #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
 
diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h
index e45ced27f4c3..876ccf50ec36 100644
--- a/include/acpi/actbl2.h
+++ b/include/acpi/actbl2.h
@@ -43,6 +43,7 @@
 #define ACPI_SIG_SBST           "SBST"	/* Smart Battery Specification Table */
 #define ACPI_SIG_SDEI           "SDEI"	/* Software Delegated Exception Interface Table */
 #define ACPI_SIG_SDEV           "SDEV"	/* Secure Devices table */
+#define ACPI_SIG_NHLT           "NHLT"	/* Non-HDAudio Link Table */
 
 /*
  * All tables must be byte-packed to match the ACPI specification, since
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RESEND PATCH] acpi: Add NHLT table signature
  2020-03-20 19:27 [RESEND PATCH] acpi: Add NHLT table signature Cezary Rojewski
@ 2020-03-21 10:35 ` Rafael J. Wysocki
  2020-03-23 16:36   ` Kaneda, Erik
  0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2020-03-21 10:35 UTC (permalink / raw)
  To: Cezary Rojewski
  Cc: linux-acpi, linux-kernel, erik.schmauss, lenb, rafael,
	Erik Kaneda, Robert Moore, Rafael J . Wysocki

On Friday, March 20, 2020 8:27:27 PM CET Cezary Rojewski wrote:
> NHLT (Non-HDAudio Link Table) provides configuration of audio
> endpoints for Intel SST (Smart Sound Technology) DSP products. Similarly
> to other ACPI tables, data provided by BIOS may not describe it
> correctly, thus overriding is required.
> 
> ACPI override mechanism checks for unknown signature before proceeding.
> Update known signatures array to support NHLT.
> 
> Cc: Erik Kaneda <erik.kaneda@intel.com>
> Cc: Robert Moore <robert.moore@intel.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
> ---
>  drivers/acpi/tables.c | 2 +-
>  include/acpi/actbl2.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> index 180ac4329763..0e905c3d1645 100644
> --- a/drivers/acpi/tables.c
> +++ b/drivers/acpi/tables.c
> @@ -501,7 +501,7 @@ static const char * const table_sigs[] = {
>  	ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
>  	ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
>  	ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
> -	NULL };
> +	ACPI_SIG_NHLT, NULL };
>  
>  #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
>  
> diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h
> index e45ced27f4c3..876ccf50ec36 100644
> --- a/include/acpi/actbl2.h
> +++ b/include/acpi/actbl2.h
> @@ -43,6 +43,7 @@
>  #define ACPI_SIG_SBST           "SBST"	/* Smart Battery Specification Table */
>  #define ACPI_SIG_SDEI           "SDEI"	/* Software Delegated Exception Interface Table */
>  #define ACPI_SIG_SDEV           "SDEV"	/* Secure Devices table */
> +#define ACPI_SIG_NHLT           "NHLT"	/* Non-HDAudio Link Table */
>  
>  /*
>   * All tables must be byte-packed to match the ACPI specification, since
> 

This should go in through the ACPICA upstream IMO.





^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [RESEND PATCH] acpi: Add NHLT table signature
  2020-03-21 10:35 ` Rafael J. Wysocki
@ 2020-03-23 16:36   ` Kaneda, Erik
  0 siblings, 0 replies; 3+ messages in thread
From: Kaneda, Erik @ 2020-03-23 16:36 UTC (permalink / raw)
  To: Rafael J. Wysocki, Rojewski, Cezary
  Cc: linux-acpi, linux-kernel, lenb, rafael, Moore, Robert, Wysocki, Rafael J



> -----Original Message-----
> From: linux-acpi-owner@vger.kernel.org <linux-acpi-
> owner@vger.kernel.org> On Behalf Of Rafael J. Wysocki
> Sent: Saturday, March 21, 2020 3:36 AM
> To: Rojewski, Cezary <cezary.rojewski@intel.com>
> Cc: linux-acpi@vger.kernel.org; linux-kernel@vger.kernel.org; Kaneda, Erik
> <erik.kaneda@intel.com>; lenb@kernel.org; rafael@kernel.org; Kaneda, Erik
> <erik.kaneda@intel.com>; Moore, Robert <robert.moore@intel.com>;
> Wysocki, Rafael J <rafael.j.wysocki@intel.com>
> Subject: Re: [RESEND PATCH] acpi: Add NHLT table signature
> 
> On Friday, March 20, 2020 8:27:27 PM CET Cezary Rojewski wrote:
> > NHLT (Non-HDAudio Link Table) provides configuration of audio
> > endpoints for Intel SST (Smart Sound Technology) DSP products.
> > Similarly to other ACPI tables, data provided by BIOS may not describe
> > it correctly, thus overriding is required.
> >
> > ACPI override mechanism checks for unknown signature before
> proceeding.
> > Update known signatures array to support NHLT.
> >
> > Cc: Erik Kaneda <erik.kaneda@intel.com>
> > Cc: Robert Moore <robert.moore@intel.com>
> > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
> > ---
> >  drivers/acpi/tables.c | 2 +-
> >  include/acpi/actbl2.h | 1 +
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c index
> > 180ac4329763..0e905c3d1645 100644
> > --- a/drivers/acpi/tables.c
> > +++ b/drivers/acpi/tables.c
> > @@ -501,7 +501,7 @@ static const char * const table_sigs[] = {
> >  	ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT,
> ACPI_SIG_FADT,
> >  	ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
> >  	ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
> > -	NULL };
> > +	ACPI_SIG_NHLT, NULL };
> >
> >  #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
> >
> > diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h index
> > e45ced27f4c3..876ccf50ec36 100644
> > --- a/include/acpi/actbl2.h
> > +++ b/include/acpi/actbl2.h
> > @@ -43,6 +43,7 @@
> >  #define ACPI_SIG_SBST           "SBST"	/* Smart Battery Specification Table
> */
> >  #define ACPI_SIG_SDEI           "SDEI"	/* Software Delegated Exception
> Interface Table */
> >  #define ACPI_SIG_SDEV           "SDEV"	/* Secure Devices table */
> > +#define ACPI_SIG_NHLT           "NHLT"	/* Non-HDAudio Link Table */
> >
> >  /*
> >   * All tables must be byte-packed to match the ACPI specification,
> > since
> >
> 
> This should go in through the ACPICA upstream IMO.
> 
I'll add this to ACPICA for now and we'll work on implementing table compiler support for ACPICA in the near future.

Erik
> 
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-20 19:27 [RESEND PATCH] acpi: Add NHLT table signature Cezary Rojewski
2020-03-21 10:35 ` Rafael J. Wysocki
2020-03-23 16:36   ` Kaneda, Erik

Linux-ACPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \
		linux-acpi@vger.kernel.org
	public-inbox-index linux-acpi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git