RE: [PATCH v7 3/8] EDAC:ghes: Move ghes_edac.force_load to ghes module parameter

[Justin He <Justin.He@arm.com>]

> -----Original Message-----
> From: Borislav Petkov <bp@alien8.de>
> Sent: Wednesday, October 5, 2022 11:14 PM
> To: Justin He <Justin.He@arm.com>
> Cc: Len Brown <lenb@kernel.org>; James Morse <James.Morse@arm.com>;
> Tony Luck <tony.luck@intel.com>; Mauro Carvalho Chehab
> <mchehab@kernel.org>; Robert Richter <rric@kernel.org>; Robert Moore
> <robert.moore@intel.com>; Qiuxu Zhuo <qiuxu.zhuo@intel.com>; Yazen
> Ghannam <yazen.ghannam@amd.com>; Jan Luebbe <jlu@pengutronix.de>;
> Khuong Dinh <khuong@os.amperecomputing.com>; Kani Toshi
> <toshi.kani@hpe.com>; Ard Biesheuvel <ardb@kernel.org>;
> linux-acpi@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-edac@vger.kernel.org; devel@acpica.org; Rafael J . Wysocki
> <rafael@kernel.org>; Shuai Xue <xueshuai@linux.alibaba.com>; Jarkko
> Sakkinen <jarkko@kernel.org>; linux-efi@vger.kernel.org; nd <nd@arm.com>
> Subject: Re: [PATCH v7 3/8] EDAC:ghes: Move ghes_edac.force_load to ghes
> module parameter
> 
> On Thu, Sep 29, 2022 at 02:37:21AM +0000, Jia He wrote:
> > ghes_edac_register() is too late to set this module flag ghes_edac.force_load.
> > Also, other edac drivers should not be able to control this flag.
> >
> > Move this flag to the module parameter in ghes instead.
> >
> > Suggested-by: Toshi Kani <toshi.kani@hpe.com>
> > Signed-off-by: Jia He <justin.he@arm.com>
> > Reviewed-by: Toshi Kani <toshi.kani@hpe.com>
> > ---
> >  drivers/acpi/apei/ghes.c |  8 ++++++++  drivers/edac/ghes_edac.c | 10
> > +++-------
> >  include/acpi/apei.h      |  2 ++
> >  3 files changed, 13 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index
> > 8cb65f757d06..b0a6445c6da2 100644
> > --- a/drivers/acpi/apei/ghes.c
> > +++ b/drivers/acpi/apei/ghes.c
> > @@ -109,6 +109,14 @@ static inline bool is_hest_type_generic_v2(struct
> > ghes *ghes)  bool ghes_disable;  module_param_named(disable,
> > ghes_disable, bool, 0);
> >
> > +/*
> > + * "ghes.edac_force_enable" forcibly enables ghes_edac and skips the
> > +platform
> > + * check.
> > + */
> > +bool ghes_edac_force_enable;
> > +EXPORT_SYMBOL(ghes_edac_force_enable);
> > +module_param_named(edac_force_enable, ghes_edac_force_enable, bool,
> > +0);
> 
> Why is this exported?
> 
> In the exemplary patch I sent you, that thing is static.
Sorry for the carelessness 


--
Cheers,
Justin (Jia He)