From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FREEMAIL_REPLYTO_END_DIGIT,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A6B9C433ED for ; Wed, 14 Apr 2021 12:35:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19DC76117A for ; Wed, 14 Apr 2021 12:35:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350929AbhDNMgN (ORCPT ); Wed, 14 Apr 2021 08:36:13 -0400 Received: from mail-02.mail-europe.com ([51.89.119.103]:50690 "EHLO mail-02.mail-europe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229765AbhDNMgM (ORCPT ); Wed, 14 Apr 2021 08:36:12 -0400 Date: Wed, 14 Apr 2021 12:35:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1618403747; bh=LBjI5Lfie9IfkopTYu8hIHm2MPYXBjYl387JLU+7p6o=; h=Date:To:From:Cc:Reply-To:Subject:From; b=ujQI1iniE56dRsjfjt1M+1ia3ALoGd6YuwOk955EO/YxeXWXJKF8qSFgSKRMQ5Qoa Y6Oi5q7yaV2N51xFABWBg11LdpvZmsQLes1NkB+dT5c3dSFlgUGvAUWqhLLsrwPzWg T3SpNc5RYdfc4qvO3AqHnrccTbwk1KVt++V7GQBQ= To: "rjw@rjwysocki.net" From: w4v3 Cc: "linux-acpi@vger.kernel.org" Reply-To: w4v3 Subject: Calling _WAK on boot Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi everyone, As I understand ACPI spec =C2=A716.3.3, the _WAK method should also be called when waking up from S5. Currently this doesn't seem to be the case. On my device (Lenovo Yoga 7i), the brightness hotkeys depend on initialization carried out in _WAK, so they currently only work after resuming from S3 or S4 sleep, but not after booting normally. I really don't know what would be the right way to do this, but as an example, patching the acpi_init function as follows seems to work fine. --- linux-pm.orig/drivers/acpi/bus.c +++ linux-pm/drivers/acpi/bus.c @@ -1094,6 +1094,7 @@ =09acpi_debugfs_init(); =09acpi_sleep_proc_init(); =09acpi_wakeup_device_init(); + acpi_leave_sleep_state(ACPI_STATE_S5); =09return 0; }