From: "Limonciello, Mario" <Mario.Limonciello@amd.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
Chuanhong Guo <gch981213@gmail.com>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Stable <stable@vger.kernel.org>,
Tighe Donnelly <tighe.donnelly@protonmail.com>,
Kent Hou Man <knthmn0@gmail.com>, Len Brown <lenb@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v5] ACPI: skip IRQ1 override on 3 Ryzen 6000 laptops
Date: Tue, 5 Jul 2022 18:27:50 +0000 [thread overview]
Message-ID: <MN0PR12MB61010151CDD4D74F75619684E2819@MN0PR12MB6101.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAJZ5v0g7JOcYTwwLxPws38abn_EVGjG0+QY9E+qpM=guhF11tA@mail.gmail.com>
[Public]
> -----Original Message-----
> From: Rafael J. Wysocki <rafael@kernel.org>
> Sent: Tuesday, July 5, 2022 13:24
> To: Chuanhong Guo <gch981213@gmail.com>
> Cc: Rafael J. Wysocki <rafael@kernel.org>; Limonciello, Mario
> <Mario.Limonciello@amd.com>; ACPI Devel Maling List <linux-
> acpi@vger.kernel.org>; Stable <stable@vger.kernel.org>; Tighe Donnelly
> <tighe.donnelly@protonmail.com>; Kent Hou Man <knthmn0@gmail.com>;
> Len Brown <lenb@kernel.org>; open list <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH v5] ACPI: skip IRQ1 override on 3 Ryzen 6000 laptops
>
> On Fri, Jul 1, 2022 at 2:45 PM Chuanhong Guo <gch981213@gmail.com>
> wrote:
> >
> > On Fri, Jul 1, 2022 at 4:12 AM Limonciello, Mario
> > <mario.limonciello@amd.com> wrote:
> > > However I do want to point out that Windows doesn't care about legacy
> > > format or not. This bug where keyboard doesn't work only popped up on
> > > Linux.
> > >
> > > Given the number of systems with the bug is appearing to grow I wonder
> > > if the right answer is actually a new heuristic that doesn't apply the
> > > kernel override for polarity inversion anymore. Maybe if the system is
> > > 2022 or newer? Or on the ACPI version?
> >
> > The previous attempt to limit the scope of IRQ override ends up
> > breaking some other buggy devices:
> >
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> hwork.kernel.org%2Fproject%2Flinux-
> acpi%2Fpatch%2F20210728151958.15205-1-
> hui.wang%40canonical.com%2F&data=05%7C01%7Cmario.limonciello%4
> 0amd.com%7C106955e4611344d3bc3808da5eb3971d%7C3dd8961fe4884e608
> e11a82d994e183d%7C0%7C0%7C637926422673112765%7CUnknown%7CTWF
> pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV
> CI6Mn0%3D%7C3000%7C%7C%7C&sdata=xOaRbkCv9EMhpLO%2BGAP
> mDjEhQ78xjYFBvehLZdg1k1I%3D&reserved=0
> >
> > It's unfortunate that the original author of this IRQ override doesn't
> > limit the scope to their exact devices.
> >
> > Hi, Rafael! What do you think? should we skip this IRQ override
> > one-by-one or add a different matching logic to check the bios date
> > instead?
>
> It would be better to find something precise enough to identify the
> machines in question without pulling in the others and use that for
> skipping the override instead of listing them all one by one in the
> blocklist.
How about using the CPU family/model in this case?
next prev parent reply other threads:[~2022-07-05 18:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 2:23 [PATCH v5] ACPI: skip IRQ1 override on 3 Ryzen 6000 laptops Chuanhong Guo
2022-06-30 20:12 ` Limonciello, Mario
2022-07-01 12:44 ` Chuanhong Guo
2022-07-05 18:24 ` Rafael J. Wysocki
2022-07-05 18:27 ` Limonciello, Mario [this message]
2022-07-05 18:31 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN0PR12MB61010151CDD4D74F75619684E2819@MN0PR12MB6101.namprd12.prod.outlook.com \
--to=mario.limonciello@amd.com \
--cc=gch981213@gmail.com \
--cc=knthmn0@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tighe.donnelly@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).