Linux-ACPI Archive on lore.kernel.org
 help / color / Atom feed
From: "Kaneda, Erik" <erik.kaneda@intel.com>
To: "Fabian Wüthrich" <me@fabwu.ch>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
	"ACPI Devel Maling List" <linux-acpi@vger.kernel.org>,
	"open list:ACPI COMPONENT ARCHITECTURE (ACPICA)"
	<devel@acpica.org>, Jacopo Mondi <jacopo@jmondi.org>,
	"Zhi, Yong" <yong.zhi@intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	"Cao, Bingbu" <bingbu.cao@intel.com>,
	Dan Scally <djrscally@gmail.com>,
	"Qiu, Tian Shu" <tian.shu.qiu@intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	"Moore, Robert" <robert.moore@intel.com>,
	"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
	Len Brown <lenb@kernel.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>
Subject: RE: [PATCH v3 1/2] ACPI: Add _PLD panel positions
Date: Fri, 14 May 2021 17:32:43 +0000
Message-ID: <MWHPR11MB1599FF3DE5721065D8DB640AF0509@MWHPR11MB1599.namprd11.prod.outlook.com> (raw)
In-Reply-To: <9cd3609d-238c-afb1-5976-8fb5577c8a3d@fabwu.ch>



> -----Original Message-----
> From: Fabian Wüthrich <me@fabwu.ch>
> Sent: Sunday, May 9, 2021 9:29 AM
> To: Kaneda, Erik <erik.kaneda@intel.com>
> Cc: Linux Media Mailing List <linux-media@vger.kernel.org>; ACPI Devel
> Maling List <linux-acpi@vger.kernel.org>; open list:ACPI COMPONENT
> ARCHITECTURE (ACPICA) <devel@acpica.org>; Jacopo Mondi
> <jacopo@jmondi.org>; Zhi, Yong <yong.zhi@intel.com>; Sakari Ailus
> <sakari.ailus@linux.intel.com>; Cao, Bingbu <bingbu.cao@intel.com>; Dan
> Scally <djrscally@gmail.com>; Qiu, Tian Shu <tian.shu.qiu@intel.com>;
> Mauro Carvalho Chehab <mchehab@kernel.org>; Moore, Robert
> <robert.moore@intel.com>; Wysocki, Rafael J <rafael.j.wysocki@intel.com>;
> Len Brown <lenb@kernel.org>; Andy Shevchenko
> <andy.shevchenko@gmail.com>; Rafael J. Wysocki <rafael@kernel.org>
> Subject: Re: [PATCH v3 1/2] ACPI: Add _PLD panel positions
> 
> Hi Erik,
> 
Hi Fabian,

> Do I need to add anything to this patch or is it fine like that?

Sorry about the late response. I submitted a pull request on your behalf for ACPICA upstream here: https://github.com/acpica/acpica/pull/689

I'll port it to Linux and circulate on this mailing list after ACPICA does a release (usually about once per month).

Thanks,
Erik
> 
> Thanks,
> Fabian
> 
> On 14.04.21 15:50, Rafael J. Wysocki wrote:
> > On Wed, Apr 14, 2021 at 10:30 AM Fabian Wüthrich <me@fabwu.ch>
> wrote:
> >>
> >> The ACPI specification v6.3 defines the panel positions in chapter 6.1.8
> >> "_PLD (Physical Location of Device)"
> >>
> >> Signed-off-by: Fabian Wüthrich <me@fabwu.ch>
> >> Reviewed-by: Daniel Scally <djrscally@gmail.com>
> >> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> >
> > This is ACPICA material.
> >
> > Erik, can you pick up this one, please?
> >
> >> ---
> >>  include/acpi/acbuffer.h | 9 +++++++++
> >>  1 file changed, 9 insertions(+)
> >>
> >> diff --git a/include/acpi/acbuffer.h b/include/acpi/acbuffer.h
> >> index 18197c16149f..d42e82a82852 100644
> >> --- a/include/acpi/acbuffer.h
> >> +++ b/include/acpi/acbuffer.h
> >> @@ -207,4 +207,13 @@ struct acpi_pld_info {
> >>  #define ACPI_PLD_GET_HORIZ_OFFSET(dword)        ACPI_GET_BITS
> (dword, 16, ACPI_16BIT_MASK)
> >>  #define ACPI_PLD_SET_HORIZ_OFFSET(dword,value)  ACPI_SET_BITS
> (dword, 16, ACPI_16BIT_MASK, value)      /* Offset 128+16=144, Len 16 */
> >>
> >> +/* Panel position defined in _PLD section of ACPI Specification 6.3 */
> >> +#define ACPI_PLD_PANEL_TOP                     0
> >> +#define ACPI_PLD_PANEL_BOTTOM                  1
> >> +#define ACPI_PLD_PANEL_LEFT                    2
> >> +#define ACPI_PLD_PANEL_RIGHT                   3
> >> +#define ACPI_PLD_PANEL_FRONT                   4
> >> +#define ACPI_PLD_PANEL_BACK                    5
> >> +#define ACPI_PLD_PANEL_UNKNOWN                 6
> >> +
> >>  #endif                         /* ACBUFFER_H */
> >> --
> >> 2.31.1
> >>

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2090a4ab-bb07-140a-f794-764f18969854@fabwu.ch>
2021-04-13  6:34 ` [PATCH v2] ipu3-cio2: Parse sensor orientation and rotation Fabian Wüthrich
2021-04-13 15:15   ` Andy Shevchenko
2021-04-14  8:30   ` [PATCH v3 0/2] " Fabian Wüthrich
2021-04-14  8:30     ` [PATCH v3 1/2] ACPI: Add _PLD panel positions Fabian Wüthrich
2021-04-14 13:50       ` Rafael J. Wysocki
2021-05-09 16:29         ` Fabian Wüthrich
2021-05-14 17:32           ` Kaneda, Erik [this message]
2021-04-14  8:30     ` [PATCH v3 2/2] ipu3-cio2: Parse sensor orientation and rotation Fabian Wüthrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB1599FF3DE5721065D8DB640AF0509@MWHPR11MB1599.namprd11.prod.outlook.com \
    --to=erik.kaneda@intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=bingbu.cao@intel.com \
    --cc=devel@acpica.org \
    --cc=djrscally@gmail.com \
    --cc=jacopo@jmondi.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=me@fabwu.ch \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rafael@kernel.org \
    --cc=robert.moore@intel.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tian.shu.qiu@intel.com \
    --cc=yong.zhi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ACPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \
		linux-acpi@vger.kernel.org
	public-inbox-index linux-acpi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git