From: Jonathan Woithe <jwoithe@just42.net>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: "David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Jonathan Corbet" <corbet@lwn.net>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Len Brown" <lenb@kernel.org>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
"Lee, Chun-Yi" <jlee@suse.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Mark Gross" <markgross@kernel.org>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Cezary Jackiewicz" <cezary.jackiewicz@gmail.com>,
"Matthew Garrett" <mjg59@srcf.ucam.org>,
"Pali Rohár" <pali@kernel.org>,
"Ike Panhc" <ike.pan@canonical.com>,
"Daniel Dadap" <ddadap@nvidia.com>,
"Kenneth Chan" <kenneth.t.chan@gmail.com>,
"Mattia Dongili" <malattia@linux.it>,
"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
"Azael Avalos" <coproscefalo@gmail.com>,
"Lee Jones" <lee@kernel.org>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Helge Deller" <deller@gmx.de>,
"Robert Moore" <robert.moore@intel.com>,
dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
intel-gfx@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org,
acpi4asus-user@lists.sourceforge.net,
ibm-acpi-devel@lists.sourceforge.net,
linux-fbdev@vger.kernel.org, devel@acpica.org
Subject: Re: [PATCH 09/22] platform/x86: fujitsu-laptop: Use acpi_video_get_backlight_types()
Date: Tue, 25 Oct 2022 08:54:40 +1030 [thread overview]
Message-ID: <Y1cQqG2eiISdKv0S@marvin.atrad.com.au> (raw)
In-Reply-To: <20221024113513.5205-10-akihiko.odaki@daynix.com>
On Mon, Oct 24, 2022 at 08:35:00PM +0900, Akihiko Odaki wrote:
> acpi_video_get_backlight_type() is now deprecated.
The practical impact of this patch series on fujitsu-laptop is obviously
very minor assuming the new acpi_video_get_backlight_types() function
functions as advertised. Accordingly, as maintainer of fujitsu-laptop I
will defer to the opinions of others who maintain the lower level
infrastructure which is more substantially affected by the bulk of the
changes in this series.
I note that Hans has naked the series and I'm happy to go along with that.
Regards
jonathan
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> drivers/platform/x86/fujitsu-laptop.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index b543d117b12c..e820de39cb68 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -387,7 +387,7 @@ static int acpi_fujitsu_bl_add(struct acpi_device *device)
> struct fujitsu_bl *priv;
> int ret;
>
> - if (acpi_video_get_backlight_type() != acpi_backlight_vendor)
> + if (!(acpi_video_get_backlight_types() & ACPI_BACKLIGHT_VENDOR))
> return -ENODEV;
>
> priv = devm_kzalloc(&device->dev, sizeof(*priv), GFP_KERNEL);
> @@ -819,7 +819,7 @@ static int acpi_fujitsu_laptop_add(struct acpi_device *device)
>
> /* Sync backlight power status */
> if (fujitsu_bl && fujitsu_bl->bl_device &&
> - acpi_video_get_backlight_type() == acpi_backlight_vendor) {
> + (acpi_video_get_backlight_types() & ACPI_BACKLIGHT_VENDOR)) {
> if (call_fext_func(fext, FUNC_BACKLIGHT, 0x2,
> BACKLIGHT_PARAM_POWER, 0x0) == BACKLIGHT_OFF)
> fujitsu_bl->bl_device->props.power = FB_BLANK_POWERDOWN;
> --
> 2.37.3
next prev parent reply other threads:[~2022-10-25 1:03 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 11:34 [PATCH 00/22] Fallback to native backlight Akihiko Odaki
2022-10-24 11:34 ` [PATCH 01/22] drm/i915/opregion: Improve backlight request condition Akihiko Odaki
2022-10-24 11:34 ` [PATCH 02/22] ACPI: video: Introduce acpi_video_get_backlight_types() Akihiko Odaki
2022-10-24 11:34 ` [PATCH 03/22] LoongArch: Use acpi_video_get_backlight_types() Akihiko Odaki
2022-10-24 11:34 ` [PATCH 04/22] platform/x86: acer-wmi: " Akihiko Odaki
2022-10-24 11:34 ` [PATCH 05/22] platform/x86: asus-laptop: " Akihiko Odaki
2022-10-24 11:34 ` [PATCH 06/22] platform/x86: asus-wmi: " Akihiko Odaki
2022-10-24 11:34 ` [PATCH 07/22] platform/x86: compal-laptop: " Akihiko Odaki
2022-10-24 11:34 ` [PATCH 08/22] platform/x86: eeepc-laptop: " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 09/22] platform/x86: fujitsu-laptop: " Akihiko Odaki
2022-10-24 22:24 ` Jonathan Woithe [this message]
2022-10-24 11:35 ` [PATCH 10/22] platform/x86: ideapad-laptop: " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 11/22] platform/x86: msi-laptop: " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 12/22] platform/x86: msi-wmi: " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 13/22] platform/x86: nvidia-wmi-ec-backlight: " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 14/22] platform/x86: panasonic-laptop: " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 15/22] platform/x86: samsung-laptop: " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 16/22] platform/x86: sony-laptop: " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 17/22] platform/x86: thinkpad_acpi: " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 18/22] platform/x86: toshiba_acpi: " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 19/22] platform/x86: dell-laptop: " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 20/22] platform/x86: intel_oaktrail: " Akihiko Odaki
2022-10-24 11:35 ` [PATCH 21/22] ACPI: video: Remove acpi_video_get_backlight_type() Akihiko Odaki
2022-10-24 11:35 ` [PATCH 22/22] ACPI: video: Fallback to native backlight Akihiko Odaki
2022-10-24 11:48 ` [PATCH 00/22] " Jani Nikula
2022-10-24 11:56 ` Akihiko Odaki
2022-10-24 12:00 ` Hans de Goede
2022-10-24 11:53 ` Hans de Goede
2022-10-24 12:58 ` Akihiko Odaki
2022-10-24 13:14 ` Pali Rohár
2022-10-24 13:23 ` Hans de Goede
2022-10-24 13:21 ` Hans de Goede
2022-10-24 14:06 ` Akihiko Odaki
2022-10-24 14:31 ` Akihiko Odaki
2022-10-24 14:37 ` Hans de Goede
2022-10-24 15:00 ` Akihiko Odaki
2022-10-24 18:11 ` Jani Nikula
2022-10-25 3:23 ` Akihiko Odaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1cQqG2eiISdKv0S@marvin.atrad.com.au \
--to=jwoithe@just42.net \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=airlied@gmail.com \
--cc=akihiko.odaki@daynix.com \
--cc=cezary.jackiewicz@gmail.com \
--cc=coproscefalo@gmail.com \
--cc=corbet@lwn.net \
--cc=corentin.chary@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=ddadap@nvidia.com \
--cc=deller@gmx.de \
--cc=devel@acpica.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ike.pan@canonical.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jingoohan1@gmail.com \
--cc=jlee@suse.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kenneth.t.chan@gmail.com \
--cc=lee@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=malattia@linux.it \
--cc=markgross@kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=mripard@kernel.org \
--cc=pali@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).