From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB167C43331 for ; Sun, 7 Mar 2021 01:19:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C51964E13 for ; Sun, 7 Mar 2021 01:19:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230056AbhCGBSS (ORCPT ); Sat, 6 Mar 2021 20:18:18 -0500 Received: from mail-qt1-f172.google.com ([209.85.160.172]:43156 "EHLO mail-qt1-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230053AbhCGBSF (ORCPT ); Sat, 6 Mar 2021 20:18:05 -0500 Received: by mail-qt1-f172.google.com with SMTP id l14so2185207qtr.10; Sat, 06 Mar 2021 17:18:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=L2b25z/IaYQj4qXr6EBnNHfy1oGsb8L5IXw+1eFrXEk=; b=XTP4IOcwoXIxOSTQuW0ZpPuIVWmZ4lK7dEAy7BAWlIYo+5RZ7a5JHlorIozbMKTplE HEZfAiOxi8OV17vlKSQc7YZQ6hc/4eYL5CrQ3kH4sZyb4cWA+7CqH9uQniugvrjM3nWP SyFBUW1nNPVCFK5P2PEKeXhEKL859bDNeqWWXPNA7EE4d/JZYZZl54t++07zkPb8Ib72 gu4tbCR26nV2hNKuwjb1g+YZOrkpAj+1v+hlqHggzVgCsxLp+mlWDJPw8TVab63owwOY B02ehUIQ8JzY9+Hr8XND4kHi6HgkfCiylkDbF/kpkJ6NxYjGYqnaZVoANuA4EWUY9PP7 M3PA== X-Gm-Message-State: AOAM531R8x4dUFUgkS/K8e7Cqmiu2NqDHbuy6Dh2DqGfZbvLnrhjSPen FMgvI4bnggoh78sMBwKPg/k+KoARMrJsZYEW X-Google-Smtp-Source: ABdhPJy5UpugTBIUvUPYV+bKOYYknMsymvxTPXUqPw3z+eGIJp30YlXptyA+8RfSAwhv2ay9u7DmGQ== X-Received: by 2002:ac8:b4b:: with SMTP id m11mr15714636qti.254.1615079884953; Sat, 06 Mar 2021 17:18:04 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id r67sm4799808qkd.93.2021.03.06.17.18.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Mar 2021 17:18:04 -0800 (PST) Date: Sun, 7 Mar 2021 02:18:01 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: chakravarthikulkarni Cc: "Rafael J. Wysocki" , Len Brown , Bjorn Helgaas , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: acpiphp: Fixed coding style Message-ID: References: <20210301072145.19018-1-chakravarthikulkarni2021@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210301072145.19018-1-chakravarthikulkarni2021@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, Thank you for sending the patch over. Few suggestions below. There seem to be an extra space in the subject line. > In this commit fixed coding style for braces and comments. Where these coding style changes suggested by a tool? For example, was it something like checkpatch.pl? If so, then it would be prudent to mention that the script found these for future reference. [...] > - struct list_head funcs; /* one slot may have different > - objects (i.e. for each function) */ > + struct list_head funcs; /* one slot may have different */ > + /* objects (i.e. for each function) */ [...] Above would be a single line commit that has been made to with within the line length rules, as otherwise the line would be too long. This is not necessarily something that we ought to fix, see for example: https://elixir.bootlin.com/linux/v5.11.3/source/include/linux/pci.h [...] > -struct acpiphp_attention_info > -{ > +struct acpiphp_attention_info { > int (*set_attn)(struct hotplug_slot *slot, u8 status); > int (*get_attn)(struct hotplug_slot *slot, u8 *status); > struct module *owner; [...] Nice catch! Generally, you would also need to your full name when providing your "Signed-off-by:" following the style that has been widely accepted. See git log for how it would normally look like, and also have a look at the following for some general guidance on how to submit patches: https://www.kernel.org/doc/html/latest/process/submitting-patches.html Krzysztof