From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBF83C433B4 for ; Thu, 8 Apr 2021 14:50:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B184561107 for ; Thu, 8 Apr 2021 14:50:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231630AbhDHOvH (ORCPT ); Thu, 8 Apr 2021 10:51:07 -0400 Received: from mga14.intel.com ([192.55.52.115]:55774 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231370AbhDHOvG (ORCPT ); Thu, 8 Apr 2021 10:51:06 -0400 IronPort-SDR: PyfR4KSRMWhwIODmzjvS2Ds8ZZmESnEeetwQV1Twb/Y+VQy5/9pN9fkvwzNfFks15IExRVhGW5 1SA7FPuNHQAw== X-IronPort-AV: E=McAfee;i="6000,8403,9948"; a="193098223" X-IronPort-AV: E=Sophos;i="5.82,206,1613462400"; d="scan'208";a="193098223" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2021 07:50:54 -0700 IronPort-SDR: BS4SlAfK9CZiY//qxN6ZKNqI5YZNfe0ydolQv7hV/Jlm95wCYH1X2Wh1rWiwOuB1a+8dzJ0y3r 5FT64U57HTrg== X-IronPort-AV: E=Sophos;i="5.82,206,1613462400"; d="scan'208";a="381748717" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2021 07:50:51 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lUVzc-002JWc-BM; Thu, 08 Apr 2021 17:50:48 +0300 Date: Thu, 8 Apr 2021 17:50:48 +0300 From: Andy Shevchenko To: "Rafael J. Wysocki" Cc: Heikki Krogerus , Daniel Scally , Linux Kernel Mailing List , Linux Media Mailing List , ACPI Devel Maling List , Greg Kroah-Hartman , Yong Zhi , Sakari Ailus , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab Subject: Re: [PATCH v2 1/6] software node: Free resources explicitly when swnode_register() fails Message-ID: References: <20210329151207.36619-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Apr 08, 2021 at 04:15:37PM +0200, Rafael J. Wysocki wrote: > On Wed, Mar 31, 2021 at 1:06 PM Heikki Krogerus > wrote: > > > > On Mon, Mar 29, 2021 at 06:12:02PM +0300, Andy Shevchenko wrote: > > > Currently we have a slightly twisted logic in swnode_register(). > > > It frees resources that it doesn't allocate on error path and > > > in once case it relies on the ->release() implementation. > > > > > > Untwist the logic by freeing resources explicitly when swnode_register() > > > fails. Currently it happens only in fwnode_create_software_node(). > > > > > > Signed-off-by: Andy Shevchenko > > > > It all looks OK to me. FWIW, for the whole series: > > > > Reviewed-by: Heikki Krogerus > > Whole series applied (with some minor changelog edits) as 5.13 material, thanks! It seems Greg applied it already. Was it dropped there? -- With Best Regards, Andy Shevchenko