From: Borislav Petkov <bp@alien8.de>
To: Vasyl Gomonovych <vgomonovych@marvell.com>
Cc: "rafael@kernel.org" <rafael@kernel.org>,
"lenb@kernel.org" <lenb@kernel.org>,
"james.morse@arm.com" <james.morse@arm.com>,
Tony Luck <tony.luck@intel.com>,
Randy Dunlap <rdunlap@infradead.org>,
Yazen Ghannam <yazen.ghannam@amd.com>,
Robert Richter <rrichter@amd.com>,
Tom Saeger <tom.saeger@oracle.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI: APEI: Check NULL argument in exported symbol
Date: Fri, 24 Sep 2021 18:11:05 +0200 [thread overview]
Message-ID: <YU34mQzQVVSghDvT@zn.tnic> (raw)
In-Reply-To: <SJ0PR18MB3900EC8E9BCB9EF18FE18C74A1A49@SJ0PR18MB3900.namprd18.prod.outlook.com>
On Fri, Sep 24, 2021 at 03:25:03PM +0000, Vasyl Gomonovych wrote:
> I found apei_hest_parse() useful API to access the HEST table.
# hexdump -C /sys/firmware/acpi/tables/HEST
doesn't work for you?
Or you want to access it with an out-of-tree driver?
> I think RAS development should increase the number of users of
> apei_hest_parse(). With this API we can read HEST and modify it. Read
> example is to get a count of errors sources from HEST tables from the
> external driver and use that counter for driver data allocation.
Aha, so with external drivers my suggestion would be is to get it
upstream. The upstream kernel doesn't care about out-of-tree users so
I'd strongly suggest you try to get that functionality upstream because
otherwise that unused export will get removed.
HTH.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-09-24 16:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 15:25 [PATCH] ACPI: APEI: Check NULL argument in exported symbol Vasyl Gomonovych
2021-09-24 16:11 ` Borislav Petkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-09-23 19:56 Vasyl Gomonovych
2021-09-23 20:48 ` Borislav Petkov
2021-09-23 21:03 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YU34mQzQVVSghDvT@zn.tnic \
--to=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rrichter@amd.com \
--cc=tom.saeger@oracle.com \
--cc=tony.luck@intel.com \
--cc=vgomonovych@marvell.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).