From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: "Clément Léger" <clement.leger@bootlin.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] software node: fix wrong node passed to find nargs_prop
Date: Wed, 22 Dec 2021 13:19:27 +0200 [thread overview]
Message-ID: <YcMJv3TvqZkrGSMG@kuha.fi.intel.com> (raw)
In-Reply-To: <20211220210533.3578678-1-clement.leger@bootlin.com>
On Mon, Dec 20, 2021 at 10:05:33PM +0100, Clément Léger wrote:
> nargs_prop refers to a property located in the reference that is found
> within the nargs property. Use the correct reference node in call to
> property_entry_read_int_array() to retrieve the correct nargs value.
>
> Fixes: b06184acf751 ("software node: Add software_node_get_reference_args()")
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/base/swnode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
> index 4debcea4fb12..0a482212c7e8 100644
> --- a/drivers/base/swnode.c
> +++ b/drivers/base/swnode.c
> @@ -529,7 +529,7 @@ software_node_get_reference_args(const struct fwnode_handle *fwnode,
> return -ENOENT;
>
> if (nargs_prop) {
> - error = property_entry_read_int_array(swnode->node->properties,
> + error = property_entry_read_int_array(ref->node->properties,
> nargs_prop, sizeof(u32),
> &nargs_prop_val, 1);
> if (error)
> --
> 2.34.1
--
heikki
next prev parent reply other threads:[~2021-12-22 11:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 21:05 [PATCH] software node: fix wrong node passed to find nargs_prop Clément Léger
[not found] ` <CAHp75Vf+F2L4EFmokRYD+-M9hSuz+SbiiWnqHvFZttRyfKS-mg@mail.gmail.com>
2021-12-20 23:37 ` Daniel Scally
2021-12-21 9:34 ` Greg Kroah-Hartman
2021-12-21 9:45 ` Sakari Ailus
2021-12-21 22:09 ` Daniel Scally
2021-12-22 9:34 ` Sakari Ailus
2021-12-21 9:46 ` Clément Léger
2021-12-21 22:08 ` Daniel Scally
2021-12-21 11:52 ` Sakari Ailus
2021-12-22 11:19 ` Heikki Krogerus [this message]
2021-12-22 17:27 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcMJv3TvqZkrGSMG@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=clement.leger@bootlin.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).