From: Ionela Voinescu <ionela.voinescu@arm.com>
To: Yicong Yang <yangyicong@huawei.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Giovanni Gherdovich <ggherdovich@suse.cz>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Valentin Schneider <valentin.schneider@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Sean Kelley <skelley@nvidia.com>,
yangyicong@hisilicon.com, Pierre Gondois <pierre.gondois@arm.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/3] arch_topology: obtain cpu capacity using information from CPPC
Date: Wed, 9 Mar 2022 15:37:49 +0000 [thread overview]
Message-ID: <YijJzekA1nFEs3nz@arm.com> (raw)
In-Reply-To: <4283eacf-6eab-b2f5-07f2-d19fad134277@huawei.com>
Hi Yicong,
On Wednesday 09 Mar 2022 at 18:21:30 (+0800), Yicong Yang wrote:
> Hi Ionela,
>
> On 2022/3/3 2:09, Ionela Voinescu wrote:
> > Define topology_init_cpu_capacity_cppc() to use highest performance
> > values from _CPC objects to obtain and set maximum capacity information
> > for each CPU. acpi_cppc_processor_probe() is a good point at which to
> > trigger the initialization of CPU (u-arch) capacity values, as at this
> > point the highest performance values can be obtained from each CPU's
> > _CPC objects. Architectures can therefore use this functionality
> > through arch_init_invariance_cppc().
> >
> > The performance scale used by CPPC is a unified scale for all CPUs in
> > the system. Therefore, by obtaining the raw highest performance values
> > from the _CPC objects, and normalizing them on the [0, 1024] capacity
> > scale, used by the task scheduler, we obtain the CPU capacity of each
> > CPU.
> >
>
> So we're going to use highest performance rather than nominal performance,
> and I checked the discussion in v2 [1]. Maybe we should also document this
> in sched-capacity.rst that where scheduler get the capacity from on ACPI
> based system? Currently we only have DT part but after this patch it's
> also supported on ACPI based system.
>
It's a very good point. I'll send a separate patch for this with added
information in "3.1 CPU capacity" in sched-capacity.rst. I'll send this
separate and not with the rebase that Rafael requested to avoid
confusing things.
> Out of curiosity, since we have raw capacity now on ACPI system, seems we
> are able to scale the capacity with freq_factor now? looked into
> register_cpufreq_notifier().
>
The freq_factor is only used for DT systems where one provides
"capacity-dmips-mhz" in DT. This entry actually represents DMIPS/MHz.
So the freq_factor, set to:
per_cpu(freq_factor, cpu) = policy->cpuinfo.max_freq / 1000;
is used to obtain the performance at the maximum frequency, basically
DMIPS = (Dhrystone) million instructions per second, by multiplying this
raw value from DT with the freq_factor. After this, all these value for
each CPU type are normalized on a scale [0, 1024], resulting in what we
call CPU capacity.
For ACPI systems freq_factor will have the default value of 1 when we
call topology_normalize_cpu_scale(), as the performance value obtained
from _CPC is already representative for the highest frequency of the CPU
and not performance/Hz as we get from DT. Therefore, we are not and
should not use a freq_factor here.
Hopefully I understood your question correctly.
Thanks,
Ionela.
> [1] https://lore.kernel.org/lkml/Yh5OAsYVBWWko+CH@arm.com/
>
> Thanks,
> Yicong
next prev parent reply other threads:[~2022-03-09 15:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 18:09 [PATCH v3 0/3] arch_topology, ACPI: populate cpu capacity from CPPC Ionela Voinescu
2022-03-02 18:09 ` [PATCH v3 1/3] x86, ACPI: rename init_freq_invariance_cppc to arch_init_invariance_cppc Ionela Voinescu
2022-03-08 18:05 ` Rafael J. Wysocki
2022-03-08 18:22 ` Rafael J. Wysocki
2022-03-09 9:30 ` Ionela Voinescu
2022-03-02 18:09 ` [PATCH v3 2/3] arch_topology: obtain cpu capacity using information from CPPC Ionela Voinescu
2022-03-09 9:54 ` Sudeep Holla
2022-03-09 10:21 ` Yicong Yang
2022-03-09 15:37 ` Ionela Voinescu [this message]
2022-03-10 6:39 ` Yicong Yang
2022-03-10 15:08 ` Ionela Voinescu
2022-03-11 8:42 ` Yicong Yang
2022-03-02 18:09 ` [PATCH v3 3/3] arm64, topology: enable use of init_cpu_capacity_cppc() Ionela Voinescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YijJzekA1nFEs3nz@arm.com \
--to=ionela.voinescu@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=ggherdovich@suse.cz \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pierre.gondois@arm.com \
--cc=rjw@rjwysocki.net \
--cc=skelley@nvidia.com \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=valentin.schneider@arm.com \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).