From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52F67C433F5 for ; Thu, 10 Mar 2022 12:45:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236870AbiCJMqK (ORCPT ); Thu, 10 Mar 2022 07:46:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234267AbiCJMqK (ORCPT ); Thu, 10 Mar 2022 07:46:10 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79A1C148910; Thu, 10 Mar 2022 04:45:09 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 29E83B825E4; Thu, 10 Mar 2022 12:45:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FD73C340E8; Thu, 10 Mar 2022 12:45:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1646916306; bh=NhveL9GbO79lXmWFb4s9ZAEreNJ3S053NM7eM4/wvgA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r9ywGDbzukXLuT04mv7fRbXjfMuUphqJvnZ18p+CqfAFe/iL1vs15RF1Rku04ZNtG Y3fqlGExnSU0nqS82lUuTLR8pZP2nfP+hRo01WytaQfEoORMGwP0mFYC0YwHv3bGOP pVZyO4o9Av3K16kmL8w49KDJYhhfndvCGMmWDoc8= Date: Thu, 10 Mar 2022 13:45:03 +0100 From: Greg Kroah-Hartman To: "Rafael J. Wysocki" Cc: Sasha Levin , stable@vger.kernel.org, ACPI Devel Maling List , Hans de Goede , "Thorsten Leemhuis (regressions address)" Subject: Re: Please revert commit 4287509b4d21e34dc492 from 5.16.y Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Mar 10, 2022 at 01:26:16PM +0100, Rafael J. Wysocki wrote: > Hi Greg & Sasha, > > Commit 4287509b4d21e34dc492 that went into 5.16.y as a backport of > mainline commit dc0075ba7f38 ("ACPI: PM: s2idle: Cancel wakeup before > dispatching EC GPE") is causing trouble in 5.16.y, but 5.17-rc7 > including the original commit is fine. > > This is most likely due to some other changes that commit dc0075ba7f38 > turns out to depend on which have not been backported, but because it > is not an essential fix (and it was backported, because it carried a > Fixes tag and not because it was marked for backporting), IMV it is > better to revert it from 5.16.y than to try to pull all of the > dependencies in (and risk missing any of them), so please do that. > > Please see this thread: > > https://lore.kernel.org/linux-pm/31b9d1cd-6a67-218b-4ada-12f72e6f00dc@redhat.com/ Odd that this is only showing up in 5.16 as this commit also is in 5.4 and 5.10 and 5.15. Should I drop it from there as well? thanks, greg k-h