From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04068C433EF for ; Wed, 23 Mar 2022 06:17:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241673AbiCWGTA (ORCPT ); Wed, 23 Mar 2022 02:19:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232627AbiCWGS7 (ORCPT ); Wed, 23 Mar 2022 02:18:59 -0400 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9286C710E4; Tue, 22 Mar 2022 23:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648016248; x=1679552248; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8vzD92UhHfMzrQ/OOVyGmFmDcRcFc7OySsWTT7LpWT4=; b=NPKSS7DoayzTvRCnMWnIdrtpnWUgWstqMFR+IwGnt4P0wNlkkgAEJUI1 mJGE3rXxuYk/W8RoHw63BD9scav+gkWNrHN/gos0pUyfp/07R33QsijS8 3IU8nS0vKFfp8dWYPTzA4AJDHzVs8MxVRLXW19GJ5RKqAADpcU3RJ2CnH frlyEl/VdMrYHOVEiN6MKWYzSoP6EMyDqQZEznBGJNu7Gl/2k3dNuAIJy /Wn3223S9+gKfdTMEWG4nDcJ/kiPQvUp7nFjw0jnk4mC4wjhwCQHI6Yd9 xzzjouvBD3s3iF1ZT82/5dUcebdlUFXQKq1PLHw4KNnjFXe72lv/YSDuu Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10294"; a="318741628" X-IronPort-AV: E=Sophos;i="5.90,203,1643702400"; d="scan'208";a="318741628" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2022 23:17:28 -0700 X-IronPort-AV: E=Sophos;i="5.90,203,1643702400"; d="scan'208";a="692833797" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.162]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2022 23:17:22 -0700 Received: by lahna (sSMTP sendmail emulation); Wed, 23 Mar 2022 08:16:15 +0200 Date: Wed, 23 Mar 2022 08:16:15 +0200 From: Mika Westerberg To: Rajat Jain Cc: "Rafael J. Wysocki" , Christoph Hellwig , Len Brown , Linux PCI , Greg Kroah-Hartman , Bjorn Helgaas , Bjorn Helgaas , ACPI Devel Maling List , Linux Kernel Mailing List , Rajat Jain , Dmitry Torokhov , Jesse Barnes , Jean-Philippe Brucker , Pavel Machek , Oliver O'Halloran , Joerg Roedel , Will Deacon , David Woodhouse , Lu Baolu , "open list:AMD IOMMU (AMD-VI)" Subject: Re: [PATCH v4 1/2] PCI: Rename "pci_dev->untrusted" to "pci_dev->poses_dma_risk" Message-ID: References: <20220320062907.3272903-1-rajatja@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Mar 22, 2022 at 01:09:55PM -0700, Rajat Jain wrote: > On Tue, Mar 22, 2022 at 4:12 AM Rafael J. Wysocki wrote: > > > > On Tue, Mar 22, 2022 at 10:02 AM Christoph Hellwig wrote: > > > > > > On Sat, Mar 19, 2022 at 11:29:05PM -0700, Rajat Jain wrote: > > > > Rename the field to make it more clear, that the device can execute DMA > > > > attacks on the system, and thus the system may need protection from > > > > such attacks from this device. > > > > > > > > No functional change intended. > > > > > > > > Signed-off-by: Rajat Jain > > > > --- > > > > v4: Initial version, created based on comments on other patch > > > > > > What a horrible name. Why not untrusted_dma which captures the > > > intent much better? > > > > FWIW, I like this one much better too. > > Sure, no problems. I can change the name to "untrusted_dma". > > Mika, can I carry forward your "Reviewed-by" tag with this name change too? Sure :)