From: Darren Hart <darren@os.amperecomputing.com>
To: Tony Luck <tony.luck@intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Len Brown <lenb@kernel.org>, James Morse <james.morse@arm.com>,
Borislav Petkov <bp@alien8.de>,
Doug Rady <dcrady@os.amperecomputing.com>
Subject: Re: [PATCH] ACPI/APEI: Better fix to avoid spamming the console with old error logs
Date: Mon, 27 Jun 2022 14:15:17 -0700 [thread overview]
Message-ID: <Yrod5bc5JCz03wH3@fedora> (raw)
In-Reply-To: <20220622170906.33759-1-tony.luck@intel.com>
On Wed, Jun 22, 2022 at 10:09:06AM -0700, Tony Luck wrote:
> The fix in commit 3f8dec116210 ("ACPI/APEI: Limit printable size of BERT
> table data") does not work as intended on systems where the BIOS has a
> fixed size block of memory for the BERT table, relying on s/w to quit
> when it finds a record with estatus->block_status == 0. On these systems
> all errors are suppressed because the check:
>
> if (region_len < ACPI_BERT_PRINT_MAX_LEN)
>
> always fails.
>
> New scheme skips individual CPER records that are too large, and also
> limits the total number of records that will be printed to 5.
Apologies for the delay.
This seems like a reasonable approach. Working to confirm new behavior on Ampere
Altra systems (specifically how region_len and estatus_len are related).
--
Darren Hart
Ampere Computing / OS and Kernel
next prev parent reply other threads:[~2022-06-27 21:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 18:50 [PATCH] ACPI/APEI: Limit printable size of BERT table data Darren Hart
2022-03-09 18:42 ` Rafael J. Wysocki
2022-06-15 22:06 ` Luck, Tony
2022-06-22 17:09 ` [PATCH] ACPI/APEI: Better fix to avoid spamming the console with old error logs Tony Luck
2022-06-27 21:15 ` Darren Hart [this message]
2022-06-29 17:56 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yrod5bc5JCz03wH3@fedora \
--to=darren@os.amperecomputing.com \
--cc=bp@alien8.de \
--cc=dcrady@os.amperecomputing.com \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).