From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Bjorn Andersson <andersson@kernel.org>,
Prashant Malani <pmalani@chromium.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, Daniel Scally <djrscally@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v2 1/5] device property: Keep dev_fwnode() and dev_fwnode_const() separate
Date: Tue, 4 Oct 2022 11:14:14 +0300 [thread overview]
Message-ID: <YzvrVoJ3BBhZmaZT@smile.fi.intel.com> (raw)
In-Reply-To: <Yzvm6XF0Ar35XZvT@kroah.com>
On Tue, Oct 04, 2022 at 09:55:21AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Oct 03, 2022 at 08:08:58PM +0000, Sakari Ailus wrote:
> > On Mon, Oct 03, 2022 at 06:17:17PM +0200, Greg Kroah-Hartman wrote:
...
> > #define kobj_to_dev(kobj) \
> > (_Generic((kobj), \
> > const struct kobject *: __kobj_to_dev_const, \
> > struct kobject *: __kobj_to_dev)(kobj))
>
> Ah, doh! I had the (kobj) part in the wrong place, thanks for that
> fix...
>
> Ok, this looks better, let me see how well the build breaks with some of
> these changes
I believe I can rewrite my patch like this and then it will be much nicer since
we may constify all the rest without calling __dev_fwnode_const() directly.
Are you agree?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-10-04 8:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 10:57 [PATCH v2 0/5] device property: Consitify a few APIs and correct dev_fwnode() Andy Shevchenko
2022-09-28 10:57 ` [PATCH v2 1/5] device property: Keep dev_fwnode() and dev_fwnode_const() separate Andy Shevchenko
2022-09-28 11:05 ` Greg Kroah-Hartman
2022-09-30 14:30 ` Sakari Ailus
2022-09-30 14:43 ` Greg Kroah-Hartman
2022-10-03 11:02 ` Sakari Ailus
2022-10-03 15:07 ` Greg Kroah-Hartman
2022-10-03 16:17 ` Greg Kroah-Hartman
2022-10-03 20:08 ` Sakari Ailus
2022-10-04 7:55 ` Greg Kroah-Hartman
2022-10-04 8:14 ` Andy Shevchenko [this message]
2022-10-04 8:24 ` Greg Kroah-Hartman
2022-10-04 8:25 ` Andy Shevchenko
2022-10-04 9:21 ` Andy Shevchenko
2022-10-04 9:15 ` Sakari Ailus
2022-10-03 11:54 ` Rafael J. Wysocki
2022-10-03 12:00 ` Sakari Ailus
2022-10-03 15:05 ` Greg Kroah-Hartman
2022-09-28 10:57 ` [PATCH v2 2/5] device property: Constify fwnode connection match APIs Andy Shevchenko
2022-09-28 10:57 ` [PATCH v2 3/5] device property: Constify parameter in fwnode_graph_is_endpoint() Andy Shevchenko
2022-09-28 10:57 ` [PATCH v2 4/5] device property: Constify device child node APIs Andy Shevchenko
2022-09-28 10:57 ` [PATCH v2 5/5] device property: Constify parameter in device_dma_supported() and device_get_dma_attr() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzvrVoJ3BBhZmaZT@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andersson@kernel.org \
--cc=djrscally@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).