From: Hans de Goede <hdegoede@redhat.com>
To: Armin Wolf <W_Armin@gmx.de>, markgross@kernel.org
Cc: andriy.shevchenko@intel.com, rafael@kernel.org, lenb@kernel.org,
hmh@hmh.eng.br, matan@svgalib.org, corentin.chary@gmail.com,
jeremy@system76.com, productdev@system76.com,
mario.limonciello@amd.com, pobrn@protonmail.com,
coproscefalo@gmail.com, platform-driver-x86@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: dell-ddv: Minor style fixes
Date: Mon, 24 Oct 2022 15:47:37 +0200 [thread overview]
Message-ID: <a70f951c-98d2-5b48-e8c0-08067a7a535c@redhat.com> (raw)
In-Reply-To: <20220928221501.3823-1-W_Armin@gmx.de>
Hi,
On 9/29/22 00:15, Armin Wolf wrote:
> Fix some style issues found during review to improve
> code maintainability, no functional changes.
>
> Tested on a Dell Inspiron 3505.
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> Changes in v2:
> - change commit message
> ---
> drivers/platform/x86/dell/dell-wmi-ddv.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/dell/dell-wmi-ddv.c b/drivers/platform/x86/dell/dell-wmi-ddv.c
> index 6ccce90f475d..699feae3c435 100644
> --- a/drivers/platform/x86/dell/dell-wmi-ddv.c
> +++ b/drivers/platform/x86/dell/dell-wmi-ddv.c
> @@ -1,13 +1,12 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> - * dell-wmi-ddv.c -- Linux driver for WMI sensor information on Dell notebooks.
> + * Linux driver for WMI sensor information on Dell notebooks.
> *
> * Copyright (C) 2022 Armin Wolf <W_Armin@gmx.de>
> */
>
> #define pr_format(fmt) KBUILD_MODNAME ": " fmt
>
> -#include <acpi/battery.h>
> #include <linux/acpi.h>
> #include <linux/debugfs.h>
> #include <linux/device.h>
> @@ -21,6 +20,8 @@
> #include <linux/sysfs.h>
> #include <linux/wmi.h>
>
> +#include <acpi/battery.h>
> +
> #define DRIVER_NAME "dell-wmi-ddv"
>
> #define DELL_DDV_SUPPORTED_INTERFACE 2
> @@ -52,7 +53,8 @@ enum dell_ddv_method {
>
> struct dell_wmi_ddv_data {
> struct acpi_battery_hook hook;
> - struct device_attribute temp_attr, eppid_attr;
> + struct device_attribute temp_attr;
> + struct device_attribute eppid_attr;
> struct wmi_device *wdev;
> };
>
> @@ -153,8 +155,9 @@ static int dell_wmi_ddv_query_string(struct wmi_device *wdev, enum dell_ddv_meth
>
> static int dell_wmi_ddv_battery_index(struct acpi_device *acpi_dev, u32 *index)
> {
> - const char *uid_str = acpi_device_uid(acpi_dev);
> + const char *uid_str;
>
> + uid_str = acpi_device_uid(acpi_dev);
> if (!uid_str)
> return -ENODEV;
>
> --
> 2.30.2
>
prev parent reply other threads:[~2022-10-24 21:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 22:15 [PATCH v2] platform/x86: dell-ddv: Minor style fixes Armin Wolf
2022-09-29 9:54 ` Andy Shevchenko
2022-10-24 13:47 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a70f951c-98d2-5b48-e8c0-08067a7a535c@redhat.com \
--to=hdegoede@redhat.com \
--cc=W_Armin@gmx.de \
--cc=andriy.shevchenko@intel.com \
--cc=coproscefalo@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=jeremy@system76.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=markgross@kernel.org \
--cc=matan@svgalib.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pobrn@protonmail.com \
--cc=productdev@system76.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).