From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22E47C0650F for ; Mon, 5 Aug 2019 09:31:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D83AB20665 for ; Mon, 5 Aug 2019 09:31:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727158AbfHEJbb (ORCPT ); Mon, 5 Aug 2019 05:31:31 -0400 Received: from mail.steuer-voss.de ([85.183.69.95]:50056 "EHLO mail.steuer-voss.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726423AbfHEJbb (ORCPT ); Mon, 5 Aug 2019 05:31:31 -0400 X-Virus-Scanned: Debian amavisd-new at mail.steuer-voss.de Received: by mail.steuer-voss.de (Postfix, from userid 1000) id A084D4D4DE; Mon, 5 Aug 2019 11:31:27 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.steuer-voss.de (Postfix) with ESMTP id 9C2AB4D4BC; Mon, 5 Aug 2019 11:31:27 +0200 (CEST) Date: Mon, 5 Aug 2019 11:31:27 +0200 (CEST) From: Nikolaus Voss X-X-Sender: nv@fox.voss.local To: Hans de Goede cc: Thierry Reding , Andy Shevchenko , "linux-pwm@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "youling257@gmail.com" , nikolaus.voss@loewensteinmedical.de Subject: Re: [PATCH 5.3 regression fix] pwm: Fallback to the static lookup-list when acpi_pwm_get fails In-Reply-To: <20190730154848.5164-1-hdegoede@redhat.com> Message-ID: References: <20190730154848.5164-1-hdegoede@redhat.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi Hans, On Tue, 30 Jul 2019, Hans de Goede wrote: > Commit 4a6ef8e37c4d ("pwm: Add support referencing PWMs from ACPI") > made pwm_get unconditionally return the acpi_pwm_get return value if > the device passed to pwm_get has an ACPI fwnode. > > But even if the passed in device has an ACPI fwnode, it does not > necessarily have the necessary ACPI package defining its pwm bindings, > especially since the binding / API of this ACPI package has only been > introduced very recently. > > Up until now X86/ACPI devices which use a separate pwm controller for > controlling their LCD screen's backlight brightness have been relying > on the static lookup-list to get their pwm. > > pwm_get unconditionally returning the acpi_pwm_get return value breaks > this, breaking backlight control on these devices. > > This commit fixes this by making pwm_get fall back to the static > lookup-list if acpi_pwm_get returns -ENOENT. Ok, I didn't find any pwm_add_table() calls in the x86 directory, so I thought the fallback matching is only for non-DT/non-ACPI systems. If it is used for ACPI nodes without PWM controller binding, it maybe should apply to DT nodes without PWM controller binding, too? It would be structurally cleaner as DT and ACPI handling was symmetrical. Niko > > BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=96571 > Reported-by: youling257@gmail.com > Fixes: 4a6ef8e37c4d ("pwm: Add support referencing PWMs from ACPI") > Cc: Nikolaus Voss > Signed-off-by: Hans de Goede > --- > drivers/pwm/core.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c > index c3ab07ab31a9..8edfac17364e 100644 > --- a/drivers/pwm/core.c > +++ b/drivers/pwm/core.c > @@ -882,8 +882,11 @@ struct pwm_device *pwm_get(struct device *dev, const char *con_id) > return of_pwm_get(dev, dev->of_node, con_id); > > /* then lookup via ACPI */ > - if (dev && is_acpi_node(dev->fwnode)) > - return acpi_pwm_get(dev->fwnode); > + if (dev && is_acpi_node(dev->fwnode)) { > + pwm = acpi_pwm_get(dev->fwnode); > + if (!IS_ERR(pwm) || PTR_ERR(pwm) != -ENOENT) > + return pwm; > + } > > /* > * We look up the provider in the static table typically provided by > -- > 2.21.0 > >