* [PATCH v2 1/2] ACPI / APD: Add clock frequency for Hisilicon Hip08-Lite I2C controller
@ 2020-02-03 1:36 Hanjun Guo
2020-02-03 1:36 ` [PATCH v2 2/2] i2c: designware: Add ACPI HID " Hanjun Guo
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Hanjun Guo @ 2020-02-03 1:36 UTC (permalink / raw)
To: Rafael J. Wysocki, Jarkko Nikula, Andy Shevchenko, Mika Westerberg
Cc: linux-i2c, linux-acpi, linuxarm, Sheng Feng, Hanjun Guo
I2C clock frequency of Designware ip for Hisilicon Hip08 Lite
is 125M, use a new ACPI HID to enable it.
Tested-by: Sheng Feng <fengsheng5@huawei.com>
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
v2:
- Reverse the order of the two patches suggested by Andy;
drivers/acpi/acpi_apd.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
index 71511ae..ba2612e 100644
--- a/drivers/acpi/acpi_apd.c
+++ b/drivers/acpi/acpi_apd.c
@@ -161,6 +161,11 @@ static int st_misc_setup(struct apd_private_data *pdata)
.fixed_clk_rate = 250000000,
};
+static const struct apd_device_desc hip08_lite_i2c_desc = {
+ .setup = acpi_apd_setup,
+ .fixed_clk_rate = 125000000,
+};
+
static const struct apd_device_desc thunderx2_i2c_desc = {
.setup = acpi_apd_setup,
.fixed_clk_rate = 125000000,
@@ -243,6 +248,7 @@ static int acpi_apd_create_device(struct acpi_device *adev,
{ "CAV9007", APD_ADDR(thunderx2_i2c_desc) },
{ "HISI02A1", APD_ADDR(hip07_i2c_desc) },
{ "HISI02A2", APD_ADDR(hip08_i2c_desc) },
+ { "HISI02A3", APD_ADDR(hip08_lite_i2c_desc) },
{ "HISI0173", APD_ADDR(hip08_spi_desc) },
{ "NXP0001", APD_ADDR(nxp_i2c_desc) },
#endif
--
1.7.12.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] i2c: designware: Add ACPI HID for Hisilicon Hip08-Lite I2C controller
2020-02-03 1:36 [PATCH v2 1/2] ACPI / APD: Add clock frequency for Hisilicon Hip08-Lite I2C controller Hanjun Guo
@ 2020-02-03 1:36 ` Hanjun Guo
2020-02-03 9:01 ` Jarkko Nikula
2020-02-03 9:23 ` Andy Shevchenko
2020-02-03 9:00 ` [PATCH v2 1/2] ACPI / APD: Add clock frequency " Jarkko Nikula
2020-02-03 11:04 ` Rafael J. Wysocki
2 siblings, 2 replies; 6+ messages in thread
From: Hanjun Guo @ 2020-02-03 1:36 UTC (permalink / raw)
To: Rafael J. Wysocki, Jarkko Nikula, Andy Shevchenko, Mika Westerberg
Cc: linux-i2c, linux-acpi, linuxarm, Sheng Feng, Hanjun Guo
Add ACPI HID HISI02A3 for Hisilicon Hip08 Lite, which has different
clock frequency from Hip08 for I2C controller.
Tested-by: Sheng Feng <fengsheng5@huawei.com>
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index 16dd338..3b7d58c 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -130,6 +130,7 @@ static int dw_i2c_acpi_configure(struct platform_device *pdev)
{ "APMC0D0F", 0 },
{ "HISI02A1", 0 },
{ "HISI02A2", 0 },
+ { "HISI02A3", 0 },
{ }
};
MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
--
1.7.12.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] ACPI / APD: Add clock frequency for Hisilicon Hip08-Lite I2C controller
2020-02-03 1:36 [PATCH v2 1/2] ACPI / APD: Add clock frequency for Hisilicon Hip08-Lite I2C controller Hanjun Guo
2020-02-03 1:36 ` [PATCH v2 2/2] i2c: designware: Add ACPI HID " Hanjun Guo
@ 2020-02-03 9:00 ` Jarkko Nikula
2020-02-03 11:04 ` Rafael J. Wysocki
2 siblings, 0 replies; 6+ messages in thread
From: Jarkko Nikula @ 2020-02-03 9:00 UTC (permalink / raw)
To: Hanjun Guo, Rafael J. Wysocki, Andy Shevchenko, Mika Westerberg
Cc: linux-i2c, linux-acpi, linuxarm, Sheng Feng
On 2/3/20 3:36 AM, Hanjun Guo wrote:
> I2C clock frequency of Designware ip for Hisilicon Hip08 Lite
> is 125M, use a new ACPI HID to enable it.
>
> Tested-by: Sheng Feng <fengsheng5@huawei.com>
> Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
> ---
>
> v2:
> - Reverse the order of the two patches suggested by Andy;
>
> drivers/acpi/acpi_apd.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] i2c: designware: Add ACPI HID for Hisilicon Hip08-Lite I2C controller
2020-02-03 1:36 ` [PATCH v2 2/2] i2c: designware: Add ACPI HID " Hanjun Guo
@ 2020-02-03 9:01 ` Jarkko Nikula
2020-02-03 9:23 ` Andy Shevchenko
1 sibling, 0 replies; 6+ messages in thread
From: Jarkko Nikula @ 2020-02-03 9:01 UTC (permalink / raw)
To: Hanjun Guo, Rafael J. Wysocki, Andy Shevchenko, Mika Westerberg
Cc: linux-i2c, linux-acpi, linuxarm, Sheng Feng
On 2/3/20 3:36 AM, Hanjun Guo wrote:
> Add ACPI HID HISI02A3 for Hisilicon Hip08 Lite, which has different
> clock frequency from Hip08 for I2C controller.
>
> Tested-by: Sheng Feng <fengsheng5@huawei.com>
> Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
> ---
> drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index 16dd338..3b7d58c 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -130,6 +130,7 @@ static int dw_i2c_acpi_configure(struct platform_device *pdev)
> { "APMC0D0F", 0 },
> { "HISI02A1", 0 },
> { "HISI02A2", 0 },
> + { "HISI02A3", 0 },
> { }
> };
> MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
> --
Acked-by: Nikula <jarkko.nikula@linux.intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] i2c: designware: Add ACPI HID for Hisilicon Hip08-Lite I2C controller
2020-02-03 1:36 ` [PATCH v2 2/2] i2c: designware: Add ACPI HID " Hanjun Guo
2020-02-03 9:01 ` Jarkko Nikula
@ 2020-02-03 9:23 ` Andy Shevchenko
1 sibling, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2020-02-03 9:23 UTC (permalink / raw)
To: Hanjun Guo
Cc: Rafael J. Wysocki, Jarkko Nikula, Mika Westerberg, linux-i2c,
linux-acpi, linuxarm, Sheng Feng
On Mon, Feb 03, 2020 at 09:36:07AM +0800, Hanjun Guo wrote:
> Add ACPI HID HISI02A3 for Hisilicon Hip08 Lite, which has different
> clock frequency from Hip08 for I2C controller.
>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Tested-by: Sheng Feng <fengsheng5@huawei.com>
> Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
> ---
> drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index 16dd338..3b7d58c 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -130,6 +130,7 @@ static int dw_i2c_acpi_configure(struct platform_device *pdev)
> { "APMC0D0F", 0 },
> { "HISI02A1", 0 },
> { "HISI02A2", 0 },
> + { "HISI02A3", 0 },
> { }
> };
> MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
> --
> 1.7.12.4
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] ACPI / APD: Add clock frequency for Hisilicon Hip08-Lite I2C controller
2020-02-03 1:36 [PATCH v2 1/2] ACPI / APD: Add clock frequency for Hisilicon Hip08-Lite I2C controller Hanjun Guo
2020-02-03 1:36 ` [PATCH v2 2/2] i2c: designware: Add ACPI HID " Hanjun Guo
2020-02-03 9:00 ` [PATCH v2 1/2] ACPI / APD: Add clock frequency " Jarkko Nikula
@ 2020-02-03 11:04 ` Rafael J. Wysocki
2 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2020-02-03 11:04 UTC (permalink / raw)
To: Hanjun Guo
Cc: Rafael J. Wysocki, Jarkko Nikula, Andy Shevchenko,
Mika Westerberg, linux-i2c, ACPI Devel Maling List, Linuxarm,
Sheng Feng
On Mon, Feb 3, 2020 at 2:41 AM Hanjun Guo <guohanjun@huawei.com> wrote:
>
> I2C clock frequency of Designware ip for Hisilicon Hip08 Lite
> is 125M, use a new ACPI HID to enable it.
>
> Tested-by: Sheng Feng <fengsheng5@huawei.com>
> Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
> ---
>
> v2:
> - Reverse the order of the two patches suggested by Andy;
>
> drivers/acpi/acpi_apd.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> index 71511ae..ba2612e 100644
> --- a/drivers/acpi/acpi_apd.c
> +++ b/drivers/acpi/acpi_apd.c
> @@ -161,6 +161,11 @@ static int st_misc_setup(struct apd_private_data *pdata)
> .fixed_clk_rate = 250000000,
> };
>
> +static const struct apd_device_desc hip08_lite_i2c_desc = {
> + .setup = acpi_apd_setup,
> + .fixed_clk_rate = 125000000,
> +};
> +
> static const struct apd_device_desc thunderx2_i2c_desc = {
> .setup = acpi_apd_setup,
> .fixed_clk_rate = 125000000,
> @@ -243,6 +248,7 @@ static int acpi_apd_create_device(struct acpi_device *adev,
> { "CAV9007", APD_ADDR(thunderx2_i2c_desc) },
> { "HISI02A1", APD_ADDR(hip07_i2c_desc) },
> { "HISI02A2", APD_ADDR(hip08_i2c_desc) },
> + { "HISI02A3", APD_ADDR(hip08_lite_i2c_desc) },
> { "HISI0173", APD_ADDR(hip08_spi_desc) },
> { "NXP0001", APD_ADDR(nxp_i2c_desc) },
> #endif
> --
Both patches in the series applied as 5.6 material, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-03 11:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-03 1:36 [PATCH v2 1/2] ACPI / APD: Add clock frequency for Hisilicon Hip08-Lite I2C controller Hanjun Guo
2020-02-03 1:36 ` [PATCH v2 2/2] i2c: designware: Add ACPI HID " Hanjun Guo
2020-02-03 9:01 ` Jarkko Nikula
2020-02-03 9:23 ` Andy Shevchenko
2020-02-03 9:00 ` [PATCH v2 1/2] ACPI / APD: Add clock frequency " Jarkko Nikula
2020-02-03 11:04 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).