From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91D4AC433E1 for ; Wed, 15 Jul 2020 13:05:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7334320658 for ; Wed, 15 Jul 2020 13:05:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594818311; bh=/JbnkKca9isth2Byqb4RT/WZLJphSaAVAFp0XT01uu0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=gqyZxiBJDbVZOtrAeAqVfRBQ8rdDMo+6RxH5fTRI+G4JEHIEucXqYK/804mtaAkZT 79q650zR/0V9qdV9MHQJkTthk+xdFNcsS92YTPcWsuxM4pW5wCB5f8wMQ1G/BEOQcG ZYmx8H3zrjwIUnrR5+w8hombEPqWZ303l1ps/bKM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731066AbgGONFK (ORCPT ); Wed, 15 Jul 2020 09:05:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:56456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729900AbgGONFK (ORCPT ); Wed, 15 Jul 2020 09:05:10 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 659CC20657; Wed, 15 Jul 2020 13:05:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594818309; bh=/JbnkKca9isth2Byqb4RT/WZLJphSaAVAFp0XT01uu0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=11WLdv3zamDVHmM6A7sD3vIrgCjWwh2+roNC+ngAh1r1bKzwRyZN5Hv+dK7odXwI5 Z96N6IXf1vw98heHULxcTXjVl85NZfzyR30Aywy25KKdwDK5SlEJumKgoTpN0pRPd3 3TcKkQHsxLcEAqtcWXhh1ufg29KGZjgEkTtjUSf0= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jvh5v-00BzoN-VJ; Wed, 15 Jul 2020 14:05:08 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 15 Jul 2020 14:05:07 +0100 From: Marc Zyngier To: Lorenzo Pieralisi Cc: linux-arm-kernel@lists.infradead.org, Diana Craciun , iommu@lists.linux-foundation.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, Rob Herring , "Rafael J. Wysocki" , Joerg Roedel , Hanjun Guo , Bjorn Helgaas , Sudeep Holla , Robin Murphy , Catalin Marinas , Will Deacon , Makarand Pawagi , Laurentiu Tudor Subject: Re: [PATCH v2 11/12] bus/fsl-mc: Refactor the MSI domain creation in the DPRC driver In-Reply-To: <20200619082013.13661-12-lorenzo.pieralisi@arm.com> References: <20200521130008.8266-1-lorenzo.pieralisi@arm.com> <20200619082013.13661-1-lorenzo.pieralisi@arm.com> <20200619082013.13661-12-lorenzo.pieralisi@arm.com> User-Agent: Roundcube Webmail/1.4.5 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: lorenzo.pieralisi@arm.com, linux-arm-kernel@lists.infradead.org, diana.craciun@oss.nxp.com, iommu@lists.linux-foundation.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, robh+dt@kernel.org, rjw@rjwysocki.net, joro@8bytes.org, guohanjun@huawei.com, bhelgaas@google.com, sudeep.holla@arm.com, robin.murphy@arm.com, catalin.marinas@arm.com, will@kernel.org, makarand.pawagi@nxp.com, laurentiu.tudor@nxp.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 2020-06-19 09:20, Lorenzo Pieralisi wrote: > From: Diana Craciun > > The DPRC driver is not taking into account the msi-map property > and assumes that the icid is the same as the stream ID. Although > this assumption is correct, generalize the code to include a > translation between icid and streamID. > > Furthermore do not just copy the MSI domain from parent (for child > containers), but use the information provided by the msi-map property. > > If the msi-map property is missing from the device tree retain the old > behaviour for backward compatibility ie the child DPRC objects > inherit the MSI domain from the parent. > > Signed-off-by: Diana Craciun > --- > drivers/bus/fsl-mc/dprc-driver.c | 31 ++++++--------------- > drivers/bus/fsl-mc/fsl-mc-bus.c | 4 +-- > drivers/bus/fsl-mc/fsl-mc-msi.c | 31 +++++++++++++-------- > drivers/bus/fsl-mc/fsl-mc-private.h | 6 ++-- > drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c | 15 +++++++++- > 5 files changed, 47 insertions(+), 40 deletions(-) For this patch and the following one: Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny...