From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH][next] pnpbios: pnpbios.h: Replace zero-length array with flexible-array member
Date: Tue, 24 Mar 2020 17:13:50 +0100 [thread overview]
Message-ID: <bd76497e-7d37-a38b-b12c-d6069714f2f0@intel.com> (raw)
In-Reply-To: <20200320231827.GA21969@embeddedor.com>
On 3/21/2020 12:18 AM, Gustavo A. R. Silva wrote:
> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array member[1][2],
> introduced in C99:
>
> struct foo {
> int stuff;
> struct boo array[];
> };
>
> By making use of the mechanism above, we will get a compiler warning
> in case the flexible array does not occur last in the structure, which
> will help us prevent some kind of undefined behavior bugs from being
> inadvertently introduced[3] to the codebase from now on.
>
> Also, notice that, dynamic memory allocations won't be affected by
> this change:
>
> "Flexible array members have incomplete type, and so the sizeof operator
> may not be applied. As a quirk of the original implementation of
> zero-length arrays, sizeof evaluates to zero."[1]
>
> This issue was found with the help of Coccinelle.
>
> [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> [2] https://github.com/KSPP/linux/issues/21
> [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/pnp/pnpbios/pnpbios.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pnp/pnpbios/pnpbios.h b/drivers/pnp/pnpbios/pnpbios.h
> index 37acb8378f39..2ce739ff9c1a 100644
> --- a/drivers/pnp/pnpbios/pnpbios.h
> +++ b/drivers/pnp/pnpbios/pnpbios.h
> @@ -107,7 +107,7 @@ struct pnp_bios_node {
> __u32 eisa_id;
> __u8 type_code[3];
> __u16 flags;
> - __u8 data[0];
> + __u8 data[];
> };
> #pragma pack()
>
Please resend this with a CC to linux-acpi, thanks!
parent reply other threads:[~2020-03-24 16:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200320231827.GA21969@embeddedor.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd76497e-7d37-a38b-b12c-d6069714f2f0@intel.com \
--to=rafael.j.wysocki@intel.com \
--cc=gustavo@embeddedor.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).