linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Jeremy Linton <jeremy.linton@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>
Cc: "Guohanjun (Hanjun Guo)" <guohanjun@huawei.com>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	"liuqi (BA)" <liuqi115@huawei.com>,
	wanghuiqiang <wanghuiqiang@huawei.com>,
	"wangxiongfeng (C)" <wangxiongfeng2@huawei.com>
Subject: Re: About PPTT find_acpi_cpu_topology_package()
Date: Fri, 14 Feb 2020 10:35:03 +0000	[thread overview]
Message-ID: <bf130dcb-73b5-7173-7111-f513e73fd12b@huawei.com> (raw)
In-Reply-To: <2feeb7aa-465c-6d40-920b-2c1aa25fbed6@arm.com>

>>>
>>
>> ACPI Processor ID valid just means that there is an associated 
>> processor container entry which has a UID which matches the ACPI 
>> Processor ID for this node.
>>
>> I can't see anything to say that if the ACPI Processor ID valid flag 
>> is unset then the ACPI processor ID itself is not still a valid 
>> identifier. As such, it's implied that it is still valid. But the spec 
>> should be clarified here.
> 
> I see what your saying here, but I think the implication is that no 
> useful information is contained in the field when its not marked valid.
> "The flags field (...) includes a bit to describe whether (this field) 
> is valid"

OK, right. So I think that the wording can be improved in the spec, 
specifically around the meaning in ACPI Processor ID valid.

> 
> Make sure your looking at ACPI 6.3+ because its a lot cleaner than the 
> earlier revisions, particularly around the leaf node case.

So you have something newer than 
https://uefi.org/sites/default/files/resources/ACPI_6_3_final_Jan30.pdf?

> .

So my FW colleague tells me that they tried adding processor containers 
for hierarchy components, but the kernel complained. I don't know the 
specifics. I need to follow up on that.

Do I see this, which we could refer to:

https://github.com/tianocore/edk2-platforms/blob/master/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl#L36

Any more pointers as references would be appreciated.

Thanks,
John

  reply	other threads:[~2020-02-14 10:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12 11:20 About PPTT find_acpi_cpu_topology_package() John Garry
2020-02-12 11:59 ` Sudeep Holla
2020-02-12 12:48   ` John Garry
2020-02-12 13:55     ` Sudeep Holla
2020-02-11 18:49       ` Jeremy Linton
2020-02-12 15:36         ` Sudeep Holla
2020-02-12 14:41       ` John Garry
2020-02-11 19:01         ` Jeremy Linton
2020-03-25 11:43           ` John Garry
2020-02-11 19:31         ` Jeremy Linton
2020-02-12 16:41           ` John Garry
2020-02-11 21:12             ` Jeremy Linton
2020-02-13 11:52               ` John Garry
2020-02-13 14:00                 ` Sudeep Holla
2020-02-13 14:33                   ` John Garry
2020-02-13 16:52                     ` Jeremy Linton
2020-02-14 10:35                       ` John Garry [this message]
2020-02-14 11:22                         ` Sudeep Holla
2020-02-12 15:32         ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf130dcb-73b5-7173-7111-f513e73fd12b@huawei.com \
    --to=john.garry@huawei.com \
    --cc=guohanjun@huawei.com \
    --cc=jeremy.linton@arm.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=liuqi115@huawei.com \
    --cc=sudeep.holla@arm.com \
    --cc=wanghuiqiang@huawei.com \
    --cc=wangxiongfeng2@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).