From: Marc Zyngier <maz@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v1 3/3] irqdomain: Allow software node to be correct one for IRQ domain
Date: Thu, 21 May 2020 09:59:57 +0100 [thread overview]
Message-ID: <c7432ac8e2564c1c2177ef6e71f252ac@kernel.org> (raw)
In-Reply-To: <20200520164927.39090-3-andriy.shevchenko@linux.intel.com>
Hi Andy,
On 2020-05-20 17:49, Andy Shevchenko wrote:
> In some cases we might need to have an IRQ domain created out of
> software node.
> One of such cases is DesignWare GPIO driver when it's instantiated from
> half-baked ACPI table (alas, we can't fix it for devices which are few
> years
> on market) and thus using software nodes to quirk this up. But the
> driver
> is using IRQ domains based on per GPIO port firmware nodes, which are
> in
> the above case software ones. This brings a warning message to be
> printed
>
> [ 73.957183] irq: Invalid fwnode type for irqdomain
>
> and creates an unknown IRQ domain.
>
> When we allow software node to be correct one for IRQ domain we will
> get rid of the warning message and nice domain name at the same time:
>
> % ls -1 /sys/kernel/debug/irq/domains/
> ...
> intel-quark-dw-apb-gpio:portA
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> kernel/irq/irqdomain.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index c6204bc606a2..e4ebc5398ef5 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -161,7 +161,8 @@ struct irq_domain *__irq_domain_add(struct
> fwnode_handle *fwnode, int size,
> domain->name = fwid->name;
> break;
> }
> - } else if (is_of_node(fwnode) || is_acpi_device_node(fwnode)) {
> + } else if (is_of_node(fwnode) || is_acpi_device_node(fwnode) ||
> + is_software_node(fwnode)) {
> char *name;
>
> /*
Thanks for this. I've applied it to irqchip-next. In the future,
please consider adding a cover letter describing the overall
goal of the series.
Cheers,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-05-21 9:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 16:49 [PATCH v1 1/3] irqdomain: Make __irq_domain_add() less OF-dependent Andy Shevchenko
2020-05-20 16:49 ` [PATCH v1 2/3] irqdomain: Get rid of special treatment for ACPI in __irq_domain_add() Andy Shevchenko
2020-05-20 16:49 ` [PATCH v1 3/3] irqdomain: Allow software node to be correct one for IRQ domain Andy Shevchenko
2020-05-21 8:59 ` Marc Zyngier [this message]
2020-05-21 9:43 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7432ac8e2564c1c2177ef6e71f252ac@kernel.org \
--to=maz@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).