From: Mark Kettenis <mark.kettenis@xs4all.nl> To: Hector Martin <marcan@marcan.st> Cc: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org, rafael@kernel.org, lenb@kernel.org, aspriel@gmail.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chi-hsien.lin@infineon.com, wright.feng@infineon.com, chung-hsien.hsu@infineon.com, marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io, kettenis@openbsd.org, zajec5@gmail.com, pieter-paul.giesberts@broadcom.com, linus.walleij@linaro.org, hdegoede@redhat.com, linville@tuxdriver.com, dekim@broadcom.com, sandals@crustytoothpaste.net, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com Subject: Re: [PATCH 01/34] dt-bindings: net: bcm4329-fmac: Add Apple properties & chips Date: Wed, 29 Dec 2021 17:42:17 +0100 (CET) [thread overview] Message-ID: <d3cb7b3782b16029@bloch.sibelius.xs4all.nl> (raw) In-Reply-To: <20211226153624.162281-2-marcan@marcan.st> (message from Hector Martin on Mon, 27 Dec 2021 00:35:51 +0900) > From: Hector Martin <marcan@marcan.st> > Cc: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>, > Alyssa Rosenzweig <alyssa@rosenzweig.io>, > Mark Kettenis <kettenis@openbsd.org>, > Rafał Miłecki <zajec5@gmail.com>, > Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>, > Linus Walleij <linus.walleij@linaro.org>, > Hans de Goede <hdegoede@redhat.com>, > "John W. Linville" <linville@tuxdriver.com>, > "Daniel (Deognyoun) Kim" <dekim@broadcom.com>, > "brian m. carlson" <sandals@crustytoothpaste.net>, > linux-wireless@vger.kernel.org, netdev@vger.kernel.org, > devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, > linux-acpi@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, > SHA-cyfmac-dev-list@infineon.com > Date: Mon, 27 Dec 2021 00:35:51 +0900 > > This binding is currently used for SDIO devices, but these chips are > also used as PCIe devices on DT platforms and may be represented in the > DT. Re-use the existing binding and add chip compatibles used by Apple > T2 and M1 platforms (the T2 ones are not known to be used in DT > platforms, but we might as well document them). > > Then, add properties required for firmware selection and calibration on > M1 machines. > > Signed-off-by: Hector Martin <marcan@marcan.st> > --- > .../net/wireless/brcm,bcm4329-fmac.yaml | 32 +++++++++++++++++-- > 1 file changed, 29 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > index c11f23b20c4c..2530ff3e7b90 100644 > --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Broadcom BCM4329 family fullmac wireless SDIO devices > +title: Broadcom BCM4329 family fullmac wireless SDIO/PCIE devices > > maintainers: > - Arend van Spriel <arend@broadcom.com> > @@ -36,16 +36,22 @@ properties: > - brcm,bcm43455-fmac > - brcm,bcm43456-fmac > - brcm,bcm4354-fmac > + - brcm,bcm4355c1-fmac > - brcm,bcm4356-fmac > - brcm,bcm4359-fmac > + - brcm,bcm4364b2-fmac > + - brcm,bcm4364b3-fmac > + - brcm,bcm4377b3-fmac > + - brcm,bcm4378b1-fmac > + - brcm,bcm4387c2-fmac > - cypress,cyw4373-fmac > - cypress,cyw43012-fmac > - const: brcm,bcm4329-fmac > - const: brcm,bcm4329-fmac I suppose this helps with validation of device trees. However, nodes for PCI devices are not supposed to have a "compatible" property as the PCI vendor and device IDs are supposed to be used to identify a device. That does raise the question how a schema for additional properties for PCI device nodes is supposed to be defined... > reg: > - description: SDIO function number for the device, for most cases > - this will be 1. > + description: SDIO function number for the device (for most cases > + this will be 1) or PCI device identifier. > > interrupts: > maxItems: 1 > @@ -75,6 +81,26 @@ properties: > items: > pattern: '^[A-Z][A-Z]-[A-Z][0-9A-Z]-[0-9]+$' > > + brcm,cal-blob: > + $ref: /schemas/types.yaml#/definitions/uint8-array > + description: A per-device calibration blob for the Wi-Fi radio. This > + should be filled in by the bootloader from platform configuration > + data, if necessary, and will be uploaded to the device if present. > + > + apple,module-instance: > + $ref: /schemas/types.yaml#/definitions/string > + description: Module codename used to identify a specific board on > + Apple platforms. This is used to build the firmware filenames, to allow > + different platforms to have different firmware and/or NVRAM config. > + > + apple,antenna-sku: > + $def: /schemas/types.yaml#/definitions/string > + description: Antenna SKU used to identify a specific antenna configuration > + on Apple platforms. This is use to build firmware filenames, to allow > + platforms with different antenna configs to have different firmware and/or > + NVRAM. This would normally be filled in by the bootloader from platform > + configuration data. > + > required: > - compatible > - reg > -- > 2.33.0 > >
next prev parent reply other threads:[~2021-12-29 16:42 UTC|newest] Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-26 15:35 [RFC PATCH 00/34] brcmfmac: Support Apple T2 and M1 platforms Hector Martin 2021-12-26 15:35 ` [PATCH 01/34] dt-bindings: net: bcm4329-fmac: Add Apple properties & chips Hector Martin 2021-12-26 21:02 ` Linus Walleij 2021-12-26 23:34 ` Rob Herring 2021-12-27 16:36 ` Rob Herring 2021-12-27 17:23 ` Hector Martin 2021-12-29 16:38 ` Mark Kettenis 2022-01-02 14:12 ` Hector Martin 2021-12-29 16:42 ` Mark Kettenis [this message] 2022-01-04 5:47 ` Hector Martin 2021-12-26 15:35 ` [PATCH 02/34] brcmfmac: pcie: Declare missing firmware files in pcie.c Hector Martin 2021-12-26 21:04 ` Linus Walleij 2021-12-26 15:35 ` [PATCH 03/34] brcmfmac: firmware: Support having multiple alt paths Hector Martin 2022-01-02 5:31 ` Linus Walleij 2022-01-02 7:10 ` Dmitry Osipenko 2022-01-02 6:38 ` Dmitry Osipenko 2022-01-02 6:45 ` Dmitry Osipenko 2022-01-02 14:18 ` Hector Martin 2022-01-02 20:11 ` Dmitry Osipenko 2022-01-03 0:41 ` Hector Martin 2022-01-03 1:26 ` Dmitry Osipenko 2022-01-03 6:17 ` Hector Martin 2022-01-02 6:55 ` Dmitry Osipenko 2022-01-03 6:18 ` Hector Martin 2022-01-02 7:08 ` Dmitry Osipenko 2022-01-02 7:20 ` Dmitry Osipenko 2022-01-02 14:25 ` Hector Martin 2022-01-02 20:12 ` Dmitry Osipenko 2021-12-26 15:35 ` [PATCH 04/34] brcmfmac: firmware: Handle per-board clm_blob files Hector Martin 2022-01-02 6:21 ` Linus Walleij 2021-12-26 15:35 ` [PATCH 05/34] brcmfmac: pcie/sdio/usb: Get CLM blob via standard firmware mechanism Hector Martin 2022-01-02 6:22 ` Linus Walleij 2021-12-26 15:35 ` [PATCH 06/34] brcmfmac: firmware: Support passing in multiple board_types Hector Martin 2022-01-02 5:34 ` Linus Walleij 2021-12-26 15:35 ` [PATCH 07/34] brcmfmac: pcie: Read Apple OTP information Hector Martin 2022-01-02 5:38 ` Linus Walleij 2022-01-03 5:51 ` Hector Martin 2022-01-03 11:13 ` Linus Walleij 2021-12-26 15:35 ` [PATCH 08/34] brcmfmac: of: Fetch Apple properties Hector Martin 2022-01-02 5:40 ` Linus Walleij 2021-12-26 15:35 ` [PATCH 09/34] brcmfmac: pcie: Perform firmware selection for Apple platforms Hector Martin 2022-01-02 5:44 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 10/34] brcmfmac: firmware: Allow platform to override macaddr Hector Martin 2022-01-02 5:50 ` Linus Walleij 2022-01-03 5:42 ` Hector Martin 2021-12-26 15:36 ` [PATCH 11/34] brcmfmac: msgbuf: Increase RX ring sizes to 1024 Hector Martin 2022-01-02 5:50 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 12/34] brcmfmac: pcie: Fix crashes due to early IRQs Hector Martin 2022-01-02 5:51 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 13/34] brcmfmac: pcie: Support PCIe core revisions >= 64 Hector Martin 2022-01-02 5:53 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 14/34] brcmfmac: pcie: Add IDs/properties for BCM4378 Hector Martin 2022-01-02 5:53 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 15/34] ACPI / property: Support strings in Apple _DSM props Hector Martin 2021-12-26 18:20 ` Lukas Wunner 2022-01-02 6:20 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 16/34] brcmfmac: acpi: Add support for fetching Apple ACPI properties Hector Martin 2022-01-02 5:58 ` Linus Walleij 2022-01-03 6:03 ` Hector Martin 2022-01-03 11:14 ` Linus Walleij [not found] ` <CAHp75VcZcJ+zCDL-J+w8gEeKXGYdJajjLoa1JTj_kkJixrV12Q@mail.gmail.com> 2022-01-03 17:22 ` Hector Martin [not found] ` <CAHp75Vedgs_zTH2O120jtUuQiuseA0VN62TJiJ7kAi1f5nDQ6Q@mail.gmail.com> 2022-01-04 5:22 ` Hector Martin 2022-01-10 9:59 ` Kalle Valo 2021-12-26 15:36 ` [PATCH 17/34] brcmfmac: pcie: Provide a buffer of random bytes to the device Hector Martin 2022-01-02 5:59 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 18/34] brcmfmac: pcie: Add IDs/properties for BCM4355 Hector Martin 2022-01-02 6:00 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 19/34] brcmfmac: pcie: Add IDs/properties for BCM4377 Hector Martin 2022-01-02 6:01 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 20/34] brcmfmac: pcie: Perform correct BCM4364 firmware selection Hector Martin 2022-01-02 6:02 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 21/34] brcmfmac: chip: Only disable D11 cores; handle an arbitrary number Hector Martin 2022-01-02 6:03 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 22/34] brcmfmac: chip: Handle 1024-unit sizes for TCM blocks Hector Martin 2022-01-02 6:09 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 23/34] brcmfmac: cfg80211: Add support for scan params v2 Hector Martin 2022-01-02 6:23 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 24/34] brcmfmac: feature: Add support for setting feats based on WLC version Hector Martin 2022-01-02 6:11 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 25/34] brcmfmac: cfg80211: Add support for PMKID_V3 operations Hector Martin 2022-01-02 6:12 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 26/34] brcmfmac: cfg80211: Pass the PMK in binary instead of hex Hector Martin 2022-01-02 6:13 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 27/34] brcmfmac: pcie: Add IDs/properties for BCM4387 Hector Martin 2022-01-02 6:13 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 28/34] brcmfmac: pcie: Replace brcmf_pcie_copy_mem_todev with memcpy_toio Hector Martin 2022-01-02 6:15 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 29/34] brcmfmac: pcie: Read the console on init and shutdown Hector Martin 2022-01-02 6:16 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 30/34] brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path Hector Martin 2022-01-02 6:16 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 31/34] brcmfmac: fwil: Constify iovar name arguments Hector Martin 2022-01-02 6:17 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 32/34] brcmfmac: common: Add support for downloading TxCap blobs Hector Martin 2022-01-02 6:18 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 33/34] brcmfmac: pcie: Load and provide " Hector Martin 2022-01-02 6:19 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 34/34] brcmfmac: common: Add support for external calibration blobs Hector Martin 2022-01-02 6:19 ` Linus Walleij 2021-12-26 19:17 ` [RFC PATCH 00/34] brcmfmac: Support Apple T2 and M1 platforms Lukas Wunner 2021-12-26 21:42 ` Hans de Goede 2021-12-27 11:53 ` Hector Martin 2022-01-02 6:25 ` Linus Walleij 2022-01-03 6:27 ` Hector Martin 2022-01-03 10:20 ` Arend van Spriel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d3cb7b3782b16029@bloch.sibelius.xs4all.nl \ --to=mark.kettenis@xs4all.nl \ --cc=SHA-cyfmac-dev-list@infineon.com \ --cc=alyssa@rosenzweig.io \ --cc=aspriel@gmail.com \ --cc=brcm80211-dev-list.pdl@broadcom.com \ --cc=chi-hsien.lin@infineon.com \ --cc=chung-hsien.hsu@infineon.com \ --cc=davem@davemloft.net \ --cc=dekim@broadcom.com \ --cc=devicetree@vger.kernel.org \ --cc=franky.lin@broadcom.com \ --cc=hante.meuleman@broadcom.com \ --cc=hdegoede@redhat.com \ --cc=kettenis@openbsd.org \ --cc=kuba@kernel.org \ --cc=kvalo@codeaurora.org \ --cc=lenb@kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=linville@tuxdriver.com \ --cc=marcan@marcan.st \ --cc=netdev@vger.kernel.org \ --cc=pieter-paul.giesberts@broadcom.com \ --cc=rafael@kernel.org \ --cc=robh+dt@kernel.org \ --cc=sandals@crustytoothpaste.net \ --cc=sven@svenpeter.dev \ --cc=wright.feng@infineon.com \ --cc=zajec5@gmail.com \ --subject='Re: [PATCH 01/34] dt-bindings: net: bcm4329-fmac: Add Apple properties & chips' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).