From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EEB8C388F7 for ; Wed, 28 Oct 2020 21:47:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F5DB24796 for ; Wed, 28 Oct 2020 21:47:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725355AbgJ1VrD (ORCPT ); Wed, 28 Oct 2020 17:47:03 -0400 Received: from mga01.intel.com ([192.55.52.88]:61793 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727591AbgJ1VrB (ORCPT ); Wed, 28 Oct 2020 17:47:01 -0400 IronPort-SDR: s1NM/Jv5ojKDC+Wzab97EKT137XzPZmqS8BfMX0K7QK+aqCnOiLlPx7NMCh4O7eipzdqpQ73+d GPVs3SwKAZsg== X-IronPort-AV: E=McAfee;i="6000,8403,9788"; a="186082457" X-IronPort-AV: E=Sophos;i="5.77,427,1596524400"; d="scan'208";a="186082457" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2020 11:43:48 -0700 IronPort-SDR: z73T4VYYFT8e/7DDXn39yXFeEnTXnAf5KaKtE9AS9Pb5mkBEEBd5DLuJxvDFbuThfJdpmDbnDG C6BaGsiPU8pw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,427,1596524400"; d="scan'208";a="424809030" Received: from linux.intel.com ([10.54.29.200]) by fmsmga001.fm.intel.com with ESMTP; 28 Oct 2020 11:43:48 -0700 Received: from debox1-desk1.jf.intel.com (debox1-desk1.jf.intel.com [10.7.201.137]) by linux.intel.com (Postfix) with ESMTP id 8C97A580713; Wed, 28 Oct 2020 11:43:48 -0700 (PDT) Message-ID: Subject: Re: [Devel] [RFC PATCH 2/4] ACPI/IORT: Add support for RMR node parsing From: "David E. Box" Reply-To: david.e.box@linux.intel.com To: Shameer Kolothum , linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, devel@acpica.org Cc: linuxarm@huawei.com, lorenzo.pieralisi@arm.com, joro@8bytes.org, robin.murphy@arm.com, wanghuiqiang@huawei.com, jonathan.cameron@huawei.com Date: Wed, 28 Oct 2020 11:43:48 -0700 In-Reply-To: <20201027112646.44680-3-shameerali.kolothum.thodi@huawei.com> References: <20201027112646.44680-1-shameerali.kolothum.thodi@huawei.com> <20201027112646.44680-3-shameerali.kolothum.thodi@huawei.com> Organization: David E. Box Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, On Tue, 2020-10-27 at 11:26 +0000, Shameer Kolothum wrote: ... > @@ -1647,6 +1667,100 @@ static void __init iort_enable_acs(struct > acpi_iort_node *iort_node) > #else > static inline void iort_enable_acs(struct acpi_iort_node *iort_node) > { } > #endif > +static int iort_rmr_desc_valid(struct acpi_iort_rmr_desc *desc) > +{ > + struct iort_rmr_entry *e; > + u64 end, start = desc->base_address, length = desc->length; > + > + if ((!IS_ALIGNED(start, SZ_64K)) || (length % SZ_64K != 0)) You could just do: if ((!IS_ALIGNED(start, SZ_64K)) || (length % SZ_64K)) David