From: Maximilian Luz <luzmaximilian@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Rob Herring <robh@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Johan Hovold <johan@kernel.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-serial@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serdev: Add ACPI devices by ResourceSource field
Date: Fri, 20 Sep 2019 22:15:10 +0200 [thread overview]
Message-ID: <d5e07b37-c295-91d0-30b4-b12065d2d302@gmail.com> (raw)
In-Reply-To: <79c9533f-882d-f2b2-b6f3-b94fa49b4367@redhat.com>
Hi,
On 9/20/19 10:50 AM, Hans de Goede wrote:
> Also I will give this a test-run on some of the existing devices
> which rely on the instantiation of serdev devices for ACPI
> devices which are childs of the uart device.
Thank you for testing! Will get to your other mail shortly.
> Given the above I think you may want to also limit your patch to
> only instantiate a "struct device" for the first UARTSerialBusV2
> in an ACPI "Device()"'s .
Right, I will change this for a v2 once the issue revealed by your
testing has been resolved.
> I hope this sheds some clarity on the (muddy) situation wrt
> I2cSerialBusV2 handling.
Thank you again, this has definitely helped clear things up for me and
your write-up is much appreciated!
Maximilian
next prev parent reply other threads:[~2019-09-20 20:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 19:56 [PATCH] serdev: Add ACPI devices by ResourceSource field Maximilian Luz
2019-09-20 8:50 ` Hans de Goede
2019-09-20 20:15 ` Maximilian Luz [this message]
2019-09-20 15:00 ` Hans de Goede
2019-09-20 20:43 ` Maximilian Luz
2019-09-22 22:29 ` Maximilian Luz
2019-09-23 8:14 ` Hans de Goede
2019-09-23 19:31 ` Maximilian Luz
2019-09-24 16:25 ` Maximilian Luz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5e07b37-c295-91d0-30b4-b12065d2d302@gmail.com \
--to=luzmaximilian@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=johan@kernel.org \
--cc=jslaby@suse.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).