From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDF13C43460 for ; Tue, 13 Apr 2021 17:43:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE9A460FEA for ; Tue, 13 Apr 2021 17:43:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345074AbhDMRn2 (ORCPT ); Tue, 13 Apr 2021 13:43:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34058 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232398AbhDMRn2 (ORCPT ); Tue, 13 Apr 2021 13:43:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618335788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=beOkS0kcTwMmsNGMKh0unRk5anjh46vtYQDhAjaR480=; b=I77DpvM+2MycF2GPyos+9VTPHxt7pMwSxqFQw9RWLlaSCHFUKAlSEldDqn066v4T82InDN diDo0xRJpkIAvlCUAS0HdtEvfceqQc6QAQLHxmWBLjyUxNem44XSt93+up7nVrM+24HgVy PgCesWpGT5UMSTc7zDnxDz7KtbUvV/s= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-101-TvPZcA5uO6i2X6s7NM9C1w-1; Tue, 13 Apr 2021 13:43:06 -0400 X-MC-Unique: TvPZcA5uO6i2X6s7NM9C1w-1 Received: by mail-ed1-f69.google.com with SMTP id b9-20020a05640202c9b029038276b571ddso1664884edx.11 for ; Tue, 13 Apr 2021 10:43:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=beOkS0kcTwMmsNGMKh0unRk5anjh46vtYQDhAjaR480=; b=cAA76THjHsD5gFtEK1xAfWh+CeyHNp6ahwq3okRenWQ09eXb5C9ssjJXpC8f9VRWOS kXukU7WCZ7VsTbh5Pk/3+XIc3UW6zUEAhpqpfGcI2OiwwDCTSkwnECQS3YM6jjRCQ+pG /kJP9ZuFBBwxlT6meDpCS0KiEkb2GRS03x0RiNGflSUEGj0h7J9t2FIWjqbqrdOlvm/7 ymBFXlCunoojkmhdcVnSE03sdAKeDnFmA201M2Ch4vUl/x0MXBc1T5ypWLH0RUtMONQf zeJCvHxQ4lxb8O8ALwVBbCjgAAL1oorhSQtcogK1nX+0rJenQ4zJ/uUzYbizIMMEgDZm qu4g== X-Gm-Message-State: AOAM532PqmjiywMQsa+8LiqEASm1ic8/kNm0ByrjFnd0pmJEG8JXhYDC 9AoKigHVIGI0qXjtYSZzUzotCVTQZ7ekPAbBb7U8ygH9by7uHIVOh/jv6MYxKvSW73h1boo7MwJ QmsKooiuuGqWAPkF6h2Vs7w== X-Received: by 2002:a17:907:2d0c:: with SMTP id gs12mr19768979ejc.443.1618335785199; Tue, 13 Apr 2021 10:43:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzpgzFux6nkdNqUfv6qkAT92npTNxVvR1HWogGtm6C9PrwyY9ABfw/Itc31fSMl8+qAFyaJJQ== X-Received: by 2002:a17:907:2d0c:: with SMTP id gs12mr19768968ejc.443.1618335784976; Tue, 13 Apr 2021 10:43:04 -0700 (PDT) Received: from [192.168.3.132] (p5b0c62e9.dip0.t-ipconnect.de. [91.12.98.233]) by smtp.gmail.com with ESMTPSA id s5sm5243051ejq.52.2021.04.13.10.43.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Apr 2021 10:43:04 -0700 (PDT) Subject: Re: [PATCH] ACPI: x86: Call acpi_boot_table_init() after acpi_table_upgrade() To: "Rafael J. Wysocki" , Linux ACPI , George Kennedy Cc: LKML , x86 Maintainers , Hans de Goede , Mike Rapoport References: <11752259.O9o76ZdvQC@kreacher> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Tue, 13 Apr 2021 19:43:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <11752259.O9o76ZdvQC@kreacher> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 13.04.21 16:01, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Commit 1a1c130ab757 ("ACPI: tables: x86: Reserve memory occupied by > ACPI tables") attempted to address an issue with reserving the memory > occupied by ACPI tables, but it broke the initrd-based table override > mechanism relied on by multiple users. > > To restore the initrd-based ACPI table override functionality, move > the acpi_boot_table_init() invocation in setup_arch() on x86 after > the acpi_table_upgrade() one. > > Fixes: 1a1c130ab757 ("ACPI: tables: x86: Reserve memory occupied by ACPI tables") > Reported-by: Hans de Goede > Tested-by: Hans de Goede > Signed-off-by: Rafael J. Wysocki > --- > > George, can you please check if this reintroduces the issue addressed by > the above commit for you? > > --- > arch/x86/kernel/setup.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > Index: linux-pm/arch/x86/kernel/setup.c > =================================================================== > --- linux-pm.orig/arch/x86/kernel/setup.c > +++ linux-pm/arch/x86/kernel/setup.c > @@ -1045,9 +1045,6 @@ void __init setup_arch(char **cmdline_p) > > cleanup_highmap(); > > - /* Look for ACPI tables and reserve memory occupied by them. */ > - acpi_boot_table_init(); > - > memblock_set_current_limit(ISA_END_ADDRESS); > e820__memblock_setup(); > > @@ -1132,6 +1129,8 @@ void __init setup_arch(char **cmdline_p) > reserve_initrd(); > > acpi_table_upgrade(); > + /* Look for ACPI tables and reserve memory occupied by them. */ > + acpi_boot_table_init(); > > vsmp_init(); This is fairly late; especially, it's after actual allocations -- see e820__memblock_alloc_reserved_mpc_new(). Can't the table upgrade mechanism fix up when adjusting something? Some details on what actually breaks would be helpful. -- Thanks, David / dhildenb