From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>
Cc: "Schofield, Alison" <alison.schofield@intel.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] ACPI: NUMA: Add CXL CFMWS 'nodes' to the possible nodes set
Date: Fri, 21 Oct 2022 03:18:30 +0000 [thread overview]
Message-ID: <e8576cfeb90df3a977626e5c56c37156379fa727.camel@intel.com> (raw)
In-Reply-To: <166631003537.1167078.9373680312035292395.stgit@dwillia2-xfh.jf.intel.com>
On Thu, 2022-10-20 at 16:54 -0700, Dan Williams wrote:
> The ACPI CEDT.CFMWS indicates a range of possible address where new CXL
> regions can appear. Each range is associated with a QTG id (QoS
> Throttling Group id). For each range + QTG pair that is not covered by a proximity
> domain in the SRAT, Linux creates a new NUMA node. However, the commit
> that added the new ranges missed updating the node_possible mask which
> causes memory_group_register() to fail. Add the new nodes to the
> nodes_possible mask.
>
> Cc: <stable@vger.kernel.org>
> Fixes: fd49f99c1809 ("ACPI: NUMA: Add a node and memblk for each CFMWS not in SRAT")
> Cc: Alison Schofield <alison.schofield@intel.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Reported-by: Vishal Verma <vishal.l.verma@intel.com>
> Tested-by: Vishal Verma <vishal.l.verma@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> Rafael, I can take this through the CXL tree with some other pending
> fixes.
>
> drivers/acpi/numa/srat.c | 1 +
> 1 file changed, 1 insertion(+)
Looks good,
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
>
> diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c
> index 3b818ab186be..1f4fc5f8a819 100644
> --- a/drivers/acpi/numa/srat.c
> +++ b/drivers/acpi/numa/srat.c
> @@ -327,6 +327,7 @@ static int __init acpi_parse_cfmws(union acpi_subtable_headers *header,
> pr_warn("ACPI NUMA: Failed to add memblk for CFMWS node %d [mem %#llx-%#llx]\n",
> node, start, end);
> }
> + node_set(node, numa_nodes_parsed);
>
> /* Set the next available fake_pxm value */
> (*fake_pxm)++;
>
next prev parent reply other threads:[~2022-10-21 3:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 23:54 [PATCH] ACPI: NUMA: Add CXL CFMWS 'nodes' to the possible nodes set Dan Williams
2022-10-21 3:18 ` Verma, Vishal L [this message]
2022-10-21 17:56 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8576cfeb90df3a977626e5c56c37156379fa727.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).