From: David Hildenbrand <david@redhat.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: George Kennedy <george.kennedy@oracle.com>,
Robert Moore <robert.moore@intel.com>,
Erik Kaneda <erik.kaneda@intel.com>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"open list:ACPI COMPONENT ARCHITECTURE (ACPICA)"
<devel@acpica.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Dhaval Giani <dhaval.giani@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Oscar Salvador <osalvador@suse.de>,
Wei Yang <richard.weiyang@linux.alibaba.com>,
Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH 1/1] ACPI: fix acpi table use after free
Date: Wed, 10 Mar 2021 20:10:42 +0100 [thread overview]
Message-ID: <e8593eae-40b8-bc9a-78db-529d28d2be88@redhat.com> (raw)
In-Reply-To: <CAJZ5v0g_ztenDY-ER6A0fKD-ZHhLfF3zQdRYYxQb5jSXudd8xQ@mail.gmail.com>
>>> Memory gets allocated and used in a different order, which seems to have
>>> exposed (yet another) latent BUG.
>>
>> Well, you can call it that, or you can say that things worked under
>> certain assumptions regarding the memory allocation order which are
>> not met any more.
>>
>>> The same could be reproduced via zone shuffling with a little luck.
>>
>> But nobody does that in practice.
>>
Dan will most certainly object. And I don't know what makes you speak in
absolute words here.
>> This would be relatively straightforward to address if ACPICA was not
>> involved in it, but unfortunately that's not the case.
>>
>> Changing this part of ACPICA is risky, because such changes may affect
>> other OSes using it, so that requires some serious consideration.
>> Alternatively, the previous memory allocation order in Linux could be
>> restored.
>
> Of course, long-term this needs to be addressed in the ACPI
> initialization code, because it clearly is not robust enough, but in
> the meantime there's practical breakage observable in the field, so
> what can be done about that?
*joke* enable zone shuffling.
No seriously, fix the latent BUG. What again is problematic about
excluding these pages from the page allcoator, for example, via
memblock_reserve()?
@Mike?
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-03-10 19:11 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 20:09 [PATCH 1/1] ACPI: fix acpi table use after free George Kennedy
2021-03-04 12:14 ` Rafael J. Wysocki
2021-03-04 23:14 ` George Kennedy
2021-03-05 13:30 ` Rafael J. Wysocki
2021-03-05 13:40 ` David Hildenbrand
2021-03-05 15:24 ` George Kennedy
2021-03-10 18:39 ` Rafael J. Wysocki
2021-03-10 18:54 ` Rafael J. Wysocki
2021-03-10 19:10 ` David Hildenbrand [this message]
2021-03-10 19:38 ` Mike Rapoport
2021-03-10 19:47 ` David Hildenbrand
2021-03-11 15:36 ` Rafael J. Wysocki
2021-03-14 18:59 ` Mike Rapoport
2021-03-15 16:19 ` Rafael J. Wysocki
2021-03-15 18:05 ` Rafael J. Wysocki
2021-03-17 20:14 ` Rafael J. Wysocki
2021-03-17 22:28 ` George Kennedy
2021-03-18 15:42 ` Rafael J. Wysocki
2021-03-18 7:25 ` Mike Rapoport
2021-03-18 10:50 ` Rafael J. Wysocki
2021-03-18 15:22 ` Rafael J. Wysocki
2021-03-20 8:25 ` Mike Rapoport
2021-03-22 16:57 ` Rafael J. Wysocki
2021-03-23 19:26 ` [PATCH] ACPI: tables: x86: Reserve memory occupied by ACPI tables Rafael J. Wysocki
2021-03-24 8:24 ` Mike Rapoport
2021-03-24 13:27 ` Rafael J. Wysocki
2021-03-24 13:49 ` George Kennedy
2021-03-24 15:42 ` George Kennedy
2021-03-24 15:44 ` Rafael J. Wysocki
2021-03-07 7:46 ` [PATCH 1/1] ACPI: fix acpi table use after free Mike Rapoport
2021-03-09 17:54 ` Mike Rapoport
2021-03-09 18:29 ` Rafael J. Wysocki
2021-03-09 20:16 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8593eae-40b8-bc9a-78db-529d28d2be88@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@acpica.org \
--cc=dhaval.giani@oracle.com \
--cc=erik.kaneda@intel.com \
--cc=george.kennedy@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=pankaj.gupta.linux@gmail.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=richard.weiyang@linux.alibaba.com \
--cc=robert.moore@intel.com \
--cc=rppt@linux.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).