From: Terry Bowman <Terry.Bowman@amd.com>
To: Dan Williams <dan.j.williams@intel.com>,
alison.schofield@intel.com, vishal.l.verma@intel.com,
dave.jiang@intel.com, ira.weiny@intel.com, bwidawsk@kernel.org
Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
bhelgaas@google.com, rafael@kernel.org, lenb@kernel.org,
Jonathan.Cameron@huawei.com, dave@stgolabs.net, rrichter@amd.com,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 1/5] cxl/acpi: Set ACPI's CXL _OSC to indicate CXL1.1 support
Date: Tue, 25 Oct 2022 11:23:21 -0500 [thread overview]
Message-ID: <ee923e4d-c2c7-a9a5-5b83-64138d052ce1@amd.com> (raw)
In-Reply-To: <63531fad96dcd_6be129496@dwillia2-xfh.jf.intel.com.notmuch>
On 10/21/22 17:39, Dan Williams wrote:
> Terry Bowman wrote:
>> ACPI includes a CXL _OSC support method to communicate the available
>> CXL support to FW. The CXL support _OSC includes a field to indicate
>> CXL1.1 RCH RCD support. The OS sets this bit to 1 if it supports access
>> to RCD and RCH Port registers.[1] FW can potentially change it's operation
>> depending on the _OSC support setting reported by the OS.
>>
>> The ACPI driver does not currently set the ACPI _OSC support to indicate
>> CXL1.1 RCD RCH support. Change the capability reported to include CXL1.1.
>>
>> [1] CXL3.0 Table 9-26 'Interpretation of CXL _OSC Support Field'
>>
>> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
>> ---
>> drivers/acpi/pci_root.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
>> index c8385ef54c37..094a59b216ae 100644
>> --- a/drivers/acpi/pci_root.c
>> +++ b/drivers/acpi/pci_root.c
>
> Be sure to copy linux-acpi@vger.kernel.org on patches that touch
> drivers/acpi/
>
Ok, I will.
Regards,
Terry
>> @@ -492,6 +492,7 @@ static u32 calculate_cxl_support(void)
>> u32 support;
>>
>> support = OSC_CXL_2_0_PORT_DEV_REG_ACCESS_SUPPORT;
>> + support |= OSC_CXL_1_1_PORT_REG_ACCESS_SUPPORT;
>> if (pci_aer_available())
>> support |= OSC_CXL_PROTOCOL_ERR_REPORTING_SUPPORT;
>> if (IS_ENABLED(CONFIG_HOTPLUG_PCI_PCIE))
>
> This looks good to me though.
prev parent reply other threads:[~2022-10-25 16:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221021185615.605233-1-terry.bowman@amd.com>
[not found] ` <20221021185615.605233-2-terry.bowman@amd.com>
2022-10-21 22:39 ` [PATCH 1/5] cxl/acpi: Set ACPI's CXL _OSC to indicate CXL1.1 support Dan Williams
2022-10-25 16:23 ` Terry Bowman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee923e4d-c2c7-a9a5-5b83-64138d052ce1@amd.com \
--to=terry.bowman@amd.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=bhelgaas@google.com \
--cc=bwidawsk@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rrichter@amd.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).