From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AC76C43613 for ; Thu, 20 Jun 2019 12:21:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3BFD2080C for ; Thu, 20 Jun 2019 12:21:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726874AbfFTMVI (ORCPT ); Thu, 20 Jun 2019 08:21:08 -0400 Received: from mga05.intel.com ([192.55.52.43]:37409 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726551AbfFTMVI (ORCPT ); Thu, 20 Jun 2019 08:21:08 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2019 05:21:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,396,1557212400"; d="scan'208";a="165303530" Received: from mylly.fi.intel.com (HELO [10.237.72.61]) ([10.237.72.61]) by orsmga006.jf.intel.com with ESMTP; 20 Jun 2019 05:21:03 -0700 Subject: Re: [PATCH] spi/acpi: fix incorrect ACPI parent check To: Ard Biesheuvel , Mika Westerberg Cc: linux-spi@vger.kernel.org, Mark Brown , kbuild test robot , Dan Carpenter , Andy Shevchenko , Masahisa Kojima , "Rafael J. Wysocki" , ACPI Devel Maling List , Lukas Wunner References: <20190619095254.19559-1-ard.biesheuvel@linaro.org> <20190619101604.GR2640@lahna.fi.intel.com> <54ede1d8-0e6b-e7d9-5e61-a7d057abbd2b@linux.intel.com> <08e498d6-1ff8-771f-7d4f-6ea5f705d386@linux.intel.com> <20190619144255.GG2640@lahna.fi.intel.com> From: Jarkko Nikula Message-ID: Date: Thu, 20 Jun 2019 15:21:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 6/20/19 1:33 PM, Ard Biesheuvel wrote: > Jarkko, does this help? > > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index 50d230b33c42..d072efdd65ba 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -1914,6 +1914,7 @@ static acpi_status > acpi_register_spi_device(struct spi_controller *ctlr, > return AE_OK; > > lookup.ctlr = ctlr; > + lookup.max_speed_hz = 0; > lookup.mode = 0; > lookup.bits_per_word = 0; > lookup.irq = -1; > Yes it does. I guess you have some cleanups or changes on top of your b5e3cf410b48 ("spi/acpi: fix incorrect ACPI parent check") since for me change go around lines @@ -1981,6 +1981,7 @@ ? -- Jarkko