From: "Jackie Liu" <liu.yun@linux.dev>
To: lorenzo.pieralisi@arm.com
Cc: linux-acpi@vger.kernel.org, liuyun01@kylinos.cn,
"Hanjun Guo" <guohanjun@huawei.com>
Subject: Re: [PATCH] acpi/arm64: fix next_platform_timer() section mismatch error
Date: Tue, 31 Aug 2021 10:11:34 +0000 [thread overview]
Message-ID: <fc62139f5128ee8d0de0bc39030ca80f@linux.dev> (raw)
In-Reply-To: <7f29a149-e005-f13f-2cc4-a9eb737107e1@huawei.com>
Friendly ping...
August 23, 2021 9:33 PM, "Hanjun Guo" <guohanjun@huawei.com> 写到:
> On 2021/8/23 17:25, Jackie Liu wrote:
>
>> From: Jackie Liu <liuyun01@kylinos.cn>
>> Fix modpost Section mismatch error in next_platform_timer().
>> [...]
>> WARNING: modpost: vmlinux.o(.text.unlikely+0x26e60): Section mismatch in reference from the
>> function next_platform_timer() to the variable .init.data:acpi_gtdt_desc
>> The function next_platform_timer() references
>> the variable __initdata acpi_gtdt_desc.
>> This is often because next_platform_timer lacks a __initdata
>> annotation or the annotation of acpi_gtdt_desc is wrong.
>> WARNING: modpost: vmlinux.o(.text.unlikely+0x26e64): Section mismatch in reference from the
>> function next_platform_timer() to the variable .init.data:acpi_gtdt_desc
>> The function next_platform_timer() references
>> the variable __initdata acpi_gtdt_desc.
>> This is often because next_platform_timer lacks a __initdata
>> annotation or the annotation of acpi_gtdt_desc is wrong.
>> ERROR: modpost: Section mismatches detected.
>> Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them.
>> make[1]: *** [scripts/Makefile.modpost:59: vmlinux.symvers] Error 1
>> make[1]: *** Deleting file 'vmlinux.symvers'
>> make: *** [Makefile:1176: vmlinux] Error 2
>> [...]
>> Fixes: a712c3ed9b8a ("acpi/arm64: Add memory-mapped timer support in GTDT driver")
>> Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
>> ---
>> drivers/acpi/arm64/gtdt.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
>> index 0a0a982f9c28..c0e77c1c8e09 100644
>> --- a/drivers/acpi/arm64/gtdt.c
>> +++ b/drivers/acpi/arm64/gtdt.c
>> @@ -36,7 +36,7 @@ struct acpi_gtdt_descriptor {
>>> static struct acpi_gtdt_descriptor acpi_gtdt_desc __initdata;
>>> -static inline void *next_platform_timer(void *platform_timer)
>> +static inline __init void *next_platform_timer(void *platform_timer)
>> {
>> struct acpi_gtdt_header *gh = platform_timer;
>
> Looks good to me,
>
> Acked-by: Hanjun Guo <guohanjun@huawei.com>
>
> Thanks
> Hanjun
next prev parent reply other threads:[~2021-08-31 10:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 9:25 [PATCH] acpi/arm64: fix next_platform_timer() section mismatch error Jackie Liu
2021-08-23 13:33 ` Hanjun Guo
2021-08-31 10:11 ` Jackie Liu [this message]
2021-09-01 2:27 ` Hanjun Guo
2021-10-12 16:44 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc62139f5128ee8d0de0bc39030ca80f@linux.dev \
--to=liu.yun@linux.dev \
--cc=guohanjun@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=liuyun01@kylinos.cn \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).