From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1A6BC04AB3 for ; Mon, 27 May 2019 10:04:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89B3D208CA for ; Mon, 27 May 2019 10:04:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aBFIYSEC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89B3D208CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xs4all.nl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yeJyAkdY/auTArV1ZUVsGplbixYl3LP84RjrV8CBLi4=; b=aBFIYSECsCweeQ peA1+XOEcug0E8XOp2xXzIuIYT1FfJ39L8BgJNPZ7hubBRxl9egglax4dQAH/G/6qk9Yufdz3gXPN pF3GvVNi1QW7XrJTT9GWHKzeKbG9FNM8wmTScMo5RemkZF8YnbS62M2bpWt6glVgCvf7koCSSKCzn Kfwm13BuXQaxF6ghcLIWcpzhuRMUekNWM1QpzDvJXMSR6pQKnQY1gj0mlXWO4fCgS8eS/XlFAx5aj omJuCjf0DYOL8E2wBnX3NFjrwUVeDtwd8k7ZYr9z3nZfGjjIcDK8QO6JFRvkGIc4OvvdxbUh1wugY wgW1R3yyhArI40lBTUTA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVCUq-0007Hb-Kn; Mon, 27 May 2019 10:04:48 +0000 Received: from lb1-smtp-cloud9.xs4all.net ([194.109.24.22]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVCUn-0007Gy-7i; Mon, 27 May 2019 10:04:47 +0000 Received: from [IPv6:2001:983:e9a7:1:f4bd:6355:63eb:2e52] ([IPv6:2001:983:e9a7:1:f4bd:6355:63eb:2e52]) by smtp-cloud9.xs4all.net with ESMTPA id VCUjha9zasDWyVCUkhYa6r; Mon, 27 May 2019 12:04:43 +0200 Subject: Re: [PATCH v6 3/4] media: meson: add v4l2 m2m video decoder driver To: Maxime Jourdan , Mauro Carvalho Chehab References: <20190514135612.30822-1-mjourdan@baylibre.com> <20190514135612.30822-4-mjourdan@baylibre.com> From: Hans Verkuil Message-ID: <07af1a22-d57c-aff6-b476-98fbf72135c1@xs4all.nl> Date: Mon, 27 May 2019 12:04:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190514135612.30822-4-mjourdan@baylibre.com> Content-Language: en-US X-CMAE-Envelope: MS4wfAPUbd4gijip9ltc6qVw2YEjOF0VIgfB18qKQs3YdT8omNplMAt5egnMNAw3XdidYdjEBlmH04PQ1ljmVzJug/BCTYRoHjk/jEOeP5p4/ko40rneX8r/ kZrBaQuTbkRY7Z3ce5qv1ALfpan9mfio53vmqQICqw3kYpLmuwL58u3vVg2qoOQUv8Q8VFEiI3FLzF+pvSL3cBLc4mSJAY9ni5NoOH1nrVK5jrhjEHNlssua 9uUc4NXWho+Q28lFs2SfLUDSH8BCkeF4Vghgbd51E3Uv9RPGTgfI0RuCT3YCa5kNWErG3+r5p4xTlE5T+LA5bOVs4P/hhoA4I8oUKEWo1+h352FDMQjABkCk 1PefiX2S62LqbA+e8aL+yBscJqB1hyoqz2lsC80AiOkJTP8qQZz1TTQ54k9i3BdouWOjfRvKbrxYxDbUVetxus9ytZS8EI3GK7axkhW50t9sca2TJj6FQWRL cSKtvMjk1LinxBFDaeFIc+yqBSdV/pcp8YbSaoSHwrveh1Rbhijy6zdKG3t/jxf9DavNnVKuuZJyF/qCM/rMjbsdDhdV2TOByc05dlakGs4jhelHMWMooNsV iSyFD0y9vHa3tQY5AmHFiqdZoFs8om1JsAlu1KQmZMj4cw557CBpNoErHL6b82IBwygpaCpDWUYpTQ4qoRhyDe8P X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190527_030445_593353_C88A88FD X-CRM114-Status: GOOD ( 21.94 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Martin Blumenstingl , Kevin Hilman , linux-kernel@vger.kernel.org, Hans Verkuil , linux-amlogic@lists.infradead.org, Jerome Brunet , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Maxime, First a high-level comment: I think this driver should go to staging. Once we finalize the stateful decoder spec, and we've updated the v4l2-compliance test, then this needs to be tested against that and only if it passes can it be moved out of staging. It is just a bit too soon to have this in mainline at this time. One other comment below: On 5/14/19 3:56 PM, Maxime Jourdan wrote: > Amlogic SoCs feature a powerful video decoder unit able to > decode many formats, with a performance of usually up to 4k60. > > This is a driver for this IP that is based around the v4l2 m2m framework. > > It features decoding for: > - MPEG 1 > - MPEG 2 > > Supported SoCs are: GXBB (S905), GXL (S905X/W/D), GXM (S912) > > There is also a hardware bitstream parser (ESPARSER) that is handled here. > > Tested-by: Neil Armstrong > Signed-off-by: Maxime Jourdan > --- > drivers/media/platform/Kconfig | 10 + > drivers/media/platform/meson/Makefile | 1 + > drivers/media/platform/meson/vdec/Makefile | 8 + > .../media/platform/meson/vdec/codec_mpeg12.c | 209 ++++ > .../media/platform/meson/vdec/codec_mpeg12.h | 14 + > drivers/media/platform/meson/vdec/dos_regs.h | 98 ++ > drivers/media/platform/meson/vdec/esparser.c | 323 +++++ > drivers/media/platform/meson/vdec/esparser.h | 32 + > drivers/media/platform/meson/vdec/vdec.c | 1071 +++++++++++++++++ > drivers/media/platform/meson/vdec/vdec.h | 265 ++++ > drivers/media/platform/meson/vdec/vdec_1.c | 229 ++++ > drivers/media/platform/meson/vdec/vdec_1.h | 14 + > .../media/platform/meson/vdec/vdec_ctrls.c | 51 + > .../media/platform/meson/vdec/vdec_ctrls.h | 14 + > .../media/platform/meson/vdec/vdec_helpers.c | 441 +++++++ > .../media/platform/meson/vdec/vdec_helpers.h | 80 ++ > .../media/platform/meson/vdec/vdec_platform.c | 107 ++ > .../media/platform/meson/vdec/vdec_platform.h | 30 + > 18 files changed, 2997 insertions(+) > create mode 100644 drivers/media/platform/meson/vdec/Makefile > create mode 100644 drivers/media/platform/meson/vdec/codec_mpeg12.c > create mode 100644 drivers/media/platform/meson/vdec/codec_mpeg12.h > create mode 100644 drivers/media/platform/meson/vdec/dos_regs.h > create mode 100644 drivers/media/platform/meson/vdec/esparser.c > create mode 100644 drivers/media/platform/meson/vdec/esparser.h > create mode 100644 drivers/media/platform/meson/vdec/vdec.c > create mode 100644 drivers/media/platform/meson/vdec/vdec.h > create mode 100644 drivers/media/platform/meson/vdec/vdec_1.c > create mode 100644 drivers/media/platform/meson/vdec/vdec_1.h > create mode 100644 drivers/media/platform/meson/vdec/vdec_ctrls.c > create mode 100644 drivers/media/platform/meson/vdec/vdec_ctrls.h > create mode 100644 drivers/media/platform/meson/vdec/vdec_helpers.c > create mode 100644 drivers/media/platform/meson/vdec/vdec_helpers.h > create mode 100644 drivers/media/platform/meson/vdec/vdec_platform.c > create mode 100644 drivers/media/platform/meson/vdec/vdec_platform.h > > diff --git a/drivers/media/platform/meson/vdec/vdec_ctrls.c b/drivers/media/platform/meson/vdec/vdec_ctrls.c > new file mode 100644 > index 000000000000..d5d6b1b97aa5 > --- /dev/null > +++ b/drivers/media/platform/meson/vdec/vdec_ctrls.c > @@ -0,0 +1,51 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (C) 2018 BayLibre, SAS > + * Author: Maxime Jourdan > + */ > + > +#include "vdec_ctrls.h" > + > +static int vdec_op_g_volatile_ctrl(struct v4l2_ctrl *ctrl) > +{ > + struct amvdec_session *sess = > + container_of(ctrl->handler, struct amvdec_session, ctrl_handler); > + > + switch (ctrl->id) { > + case V4L2_CID_MIN_BUFFERS_FOR_CAPTURE: > + ctrl->val = sess->dpb_size; > + break; > + default: > + return -EINVAL; > + }; > + > + return 0; > +} > + > +static const struct v4l2_ctrl_ops vdec_ctrl_ops = { > + .g_volatile_ctrl = vdec_op_g_volatile_ctrl, > +}; > + > +int amvdec_init_ctrls(struct v4l2_ctrl_handler *ctrl_handler) > +{ > + int ret; > + struct v4l2_ctrl *ctrl; > + > + ret = v4l2_ctrl_handler_init(ctrl_handler, 1); > + if (ret) > + return ret; > + > + ctrl = v4l2_ctrl_new_std(ctrl_handler, &vdec_ctrl_ops, > + V4L2_CID_MIN_BUFFERS_FOR_CAPTURE, 1, 32, 1, 1); > + if (ctrl) > + ctrl->flags |= V4L2_CTRL_FLAG_VOLATILE; Why is this volatile? That makes little sense. > + > + ret = ctrl_handler->error; > + if (ret) { > + v4l2_ctrl_handler_free(ctrl_handler); > + return ret; > + } > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(amvdec_init_ctrls); Regards, Hans _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic