From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 390B8C1B0F7 for ; Fri, 18 Jan 2019 21:06:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06FDC20449 for ; Fri, 18 Jan 2019 21:06:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sjp4MOsO"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="QMMdtyx2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06FDC20449 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=03ncCW494MfxPJe5UtfSWMUXWyzJFQMXybchq4CMVFo=; b=sjp4MOsOPAeEvy ojXdHU/7Zr7bVrDTyRkqzyoaaYaEJBBp9UmYmAnLMNoSMje017E07oWyHa7CzvIg5dQbi4puKzebQ tadyRxTGrls0OQzsWBqY8Tt/6YiA7g0yTS68w86JZ/wJxaFus84Dr4Ia1lOCElIFuCFC8tYgL5si0 RHEBrU+ADem8W5k9JtJabkvO3beb95ULX1MJ9m1O+3msdWPqolvMXW5/XrIRbuMqaHLcQsQwFpX3C JOq+IoUSoM9BTpLQ6SB5Zp2VDPvKgK2NeDCGYKcSz3C2SRJbKVVJOCe0j06VoReCBZjzul7x8UhZ2 hwo6JRrK0roN8IkXmkTg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkbLh-0005Sz-At; Fri, 18 Jan 2019 21:06:45 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkbLP-0005AC-1v for linux-amlogic@lists.infradead.org; Fri, 18 Jan 2019 21:06:37 +0000 Received: by mail-wr1-x442.google.com with SMTP id z5so16673620wrt.11 for ; Fri, 18 Jan 2019 13:06:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=fIPuQo45ozsSJ6dAGKPJwbGMqPWQ/JDqMzTlwh+7PyA=; b=QMMdtyx2FlKw8KVIIupz+wVJLEtjrrVQX85iwMvMW/UZ1qWrD6ECv522qGHbEB6Uav yxTMEyAtyeyk0DCYRUGCK1BHyNteqej8X6YFRYSLYHa7Uy8PcAgJDRnvgSZ3EZ/7osP6 N/B/1d/MtcdijAQaKFEqIQcYQmRcZ10BDhu5nD4Kb9DlDlPgyMMLgtCm6AApcsEm36SI CC++i/E/vPrpaFn5yfyPo1oza6/FAbNiaK3IItOLhoP2Q9ekitLdheBxIUT6sGhvBiNa ++sR6/hmEwfvHHOnTqheaKcEBn1EbE+8a0M+bHzm79i7nHXScgRHV8aD/V61URzRlQpJ c8pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=fIPuQo45ozsSJ6dAGKPJwbGMqPWQ/JDqMzTlwh+7PyA=; b=U5WtkWHfbEZJxVyRi7o23GK4RepxVg3wRGwf+MG99sKbaNLe4qXR/nWrDVvtOKMCnj LBbmZDKVeFLtI5vJBP1dFNLxLzTQDIGoIF9tae9qvMlZqqCBWecFI2y2/VI3oRz9+lyO W4QvflH8kkwSKAqjIepisxTXfHDkKkBBye8WNm49UPqQI67XsxZg7/zBYAinDbfFs9em 2ciZJ1MEIPRTrg21rjDKyE5tiN5hJiax04zGUAVgQcgMGicE2vXBXNW7N9gAeRi5d5eH yn2ad6kPuUo/HknzEw5riocbtf4hck+SOzwXegvdBCWmw6P+jcI6w23Nc3uyuif/KSQu f2Gw== X-Gm-Message-State: AJcUukca7cGeQ9pdKV73cFgiIoD2Pp8/YSAq+OVFvKrzrPy7P12WJCJB S3QS49UPQ6D73SgWlbfZ8LLcQQ== X-Google-Smtp-Source: ALg8bN47+f99H8S2NATk3lSondS8WiFxqsEu8sdmYllwZfJIb+V1xtyzT6EXgT7rOiberXag+zZczA== X-Received: by 2002:adf:f390:: with SMTP id m16mr17477949wro.71.1547845584522; Fri, 18 Jan 2019 13:06:24 -0800 (PST) Received: from boomer.baylibre.com (cag06-3-82-243-161-21.fbx.proxad.net. [82.243.161.21]) by smtp.gmail.com with ESMTPSA id n6sm42836118wmk.9.2019.01.18.13.06.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 Jan 2019 13:06:23 -0800 (PST) Message-ID: <09d31d456e727a27bab66c89004f1d6c42588fd9.camel@baylibre.com> Subject: Re: [PATCH] arm64: dts: meson: fix g12a buses From: Jerome Brunet To: Jianxin Pan , Martin Blumenstingl Date: Fri, 18 Jan 2019 22:06:21 +0100 In-Reply-To: <98166e2c-f5f8-55b9-6acb-7374bf10d80c@amlogic.com> References: <20190116165236.8330-1-jbrunet@baylibre.com> <98166e2c-f5f8-55b9-6acb-7374bf10d80c@amlogic.com> User-Agent: Evolution 3.30.4 (3.30.4-1.fc29) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190118_130627_498705_5E22EB53 X-CRM114-Status: GOOD ( 22.50 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Hilman , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Victor Wan , linux-amlogic@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Sat, 2019-01-19 at 02:09 +0800, Jianxin Pan wrote: > Hi Martin and Jerome, > > On 2019/1/18 5:20, Martin Blumenstingl wrote: > > On Thu, Jan 17, 2019 at 9:39 PM Jerome Brunet > > wrote: > > > On Thu, 2019-01-17 at 21:27 +0100, Martin Blumenstingl wrote: > > > > OK, but we had incorrect documentation in the past. did you check this > > > > with someone from Amlogic? > > > > > > > > I'm curious because there seem to be two different approaches here: > > > > 1) hiubus name and offsets are being fixed within this patch > > > > 2) aobus is being dropped here and re-introduced with a different name > > > > later > > > > on > > > > > > > > > > because hiu exist and aobus does not, for which both the name and size > > > was > > > wrong > > > > > > > approach 1) can also be used for the "rti" region (at least in my > > > > opinion, the patch doesn't explain why it can't be done): > > > > > > THe patch remove aobus (instead of fixing name and size) because, of the > > > multiple region documented covered by this 'made region', I did not > > > anticipate > > > which one will be required and I did not want to add them all. > > > > > > Better to add them as needed, which is want I done for pinctrl as you > > > pointed > > > out > > > > > > > rename "aobus" to "rti" and change the size to either 0x1000 or 0xb000 > > > > (both values can be found in mesong12a.dtsi from > > > > buildroot_openlinux_kernel_4.9_fbdev_20180706) > > > > > > RTI is added here: > > > https://lkml.kernel.org/r/20190117103151.3349-1-jbrunet@baylibre.com > > > > > > I don't really understand the problem ? result is the same > > the actual problem is "me" as I have conflicting information: > > - Amlogic's buildroot kernel (for G12A) uses similar bus definitions > > as the GX SoCs (for which there are public datasheets) - this is how > > Jianxin added it to meson-g12a.dtsi originally > > - this patch does it different - but cannot check if this is correct > > (no public datasheet is available for G12A or AXG) nor do I have a > > "big picture" of upcoming changes > > > > Cc'ing Jianxin: can you please review Jerome's patch and give some > > more details on the memory map on G12A so further contributions can be > > reviewed easier? > > > 1. "aobus: bus@ff800000" describes the following registers: > ahb ao_reg reserved 980 FF80B000 > ahb ao_reg ao_mailbox 4 FF80A000 > ahb ao_reg sar_adc 4 FF809000 > ahb ao_reg ir_dec 4 FF808000 > ahb ao_reg pwm_ab 4 FF807000 > ahb ao_reg i2c_s 4 FF806000 > ahb ao_reg i2c_m 4 FF805000 > ahb ao_reg uart2 4 FF804000 > ahb ao_reg uart 4 FF803000 > ahb ao_reg pwm_cd 4 FF802000 > ahb ao_reg reserved 4 FF801000 > ahb ao_reg rti 4 FF800000 > > > 2. "cbus: bus@ffd00000" describes the following registers: > capb3 cbus reserved 872 FFD26000 FFDFFFFF > capb3 cbus sc 4 FFD25000 FFD25FFF > capb3 cbus uart0 4 FFD24000 FFD24FFF > capb3 cbus uart1 4 FFD23000 FFD23FFF > capb3 cbus uart2 4 FFD22000 FFD22FFF > capb3 cbus reserved 4 FFD21000 FFD21FFF > capb3 cbus reserved 4 FFD20000 FFD20FFF > capb3 cbus i2c_m0 4 FFD1F000 FFD1FFFF > capb3 cbus i2c_m1 4 FFD1E000 FFD1EFFF > capb3 cbus i2c_m2 4 FFD1D000 FFD1DFFF > capb3 cbus i2c_m3 4 FFD1C000 FFD1CFFF > capb3 cbus pwm_ab 4 FFD1B000 FFD1BFFF > capb3 cbus pwm_cd 4 FFD1A000 FFD1AFFF > capb3 cbus pwm_ef 4 FFD19000 FFD19FFF > capb3 cbus msr_clk 4 FFD18000 FFD18FFF > capb3 cbus reserved 4 FFD17000 FFD17FFF > capb3 cbus reserved 4 FFD16000 FFD16FFF > capb3 cbus spicc_1 4 FFD15000 FFD15FFF > capb3 cbus spifc 4 FFD14000 FFD14FFF > capb3 cbus spicc_0 4 FFD13000 FFD13FFF > capb3 cbus reserved 4 FFD12000 FFD12FFF > capb3 cbus reserved 4 FFD11000 FFD11FFF > capb3 cbus reserved 4 FFD10000 FFD10FFF > capb3 cbus isa 4 FFD0F000 FFD0FFFF > capb3 cbus parser 4 FFD0E000 FFD0EFFF > capb3 cbus reserved 4 FFD0D000 FFD0DFFF > capb3 cbus sana 4 FFD0C000 FFD0CFFF > capb3 cbus stream 4 FFD0B000 FFD0BFFF > capb3 cbus async_fifo 4 FFD0A000 FFD0AFFF > capb3 cbus async_fifo2 4 FFD09000 FFD09FFF > capb3 cbus assist 4 FFD08000 FFD08FFF > capb3 cbus mipi_dsi_host 4 FFD07000 FFD07FFF > capb3 cbus stb 4 FFD06000 FFD06FFF > capb3 cbus aififo 4 FFD05000 FFD05FFF > capb3 cbus reserved 4 FFD04000 FFD04FFF > capb3 cbus reserved 4 FFD03000 FFD03FFF > capb3 cbus reserved 4 FFD02000 FFD02FFF > capb3 cbus reset 4 FFD01000 FFD01FFF > capb3 cbus reserved 4 FFD00000 FFD00FFF Hu Jianxin, Thanks for sharing this. Any other region we should know about ? what about the apb region that isn't documented either ? > > 3. In public data sheet, I can only found memory map about sub-regions of > each bus. > And no information about the bus itself. > > > Regards > > Martin > > > > . > > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic