Linux-Amlogic Archive on lore.kernel.org
 help / color / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Carlo Caione <ccaione@baylibre.com>,
	khilman@baylibre.com, narmstrong@baylibre.com,
	robh+dt@kernel.org, tglx@linutronix.de, jbrunet@baylibre.com,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 4/4] firmware: meson_sm: Rework driver as a proper platform driver
Date: Tue, 6 Aug 2019 09:23:24 +0100
Message-ID: <0a4f48fa-0110-78b5-75d9-091849ab4691@linaro.org> (raw)
In-Reply-To: <20190731082339.20163-5-ccaione@baylibre.com>



On 31/07/2019 09:23, Carlo Caione wrote:
> The secure monitor driver is currently a frankenstein driver which is
> registered as a platform driver but its functionality goes through a
> global struct accessed by the consumer drivers using exported helper
> functions.
> 
> Try to tidy up the driver moving the firmware struct into the driver
> data and make the consumer drivers referencing the secure-monitor using
> a new property in the DT.
> 
> Currently only the nvmem driver is using this API so we can fix it in
> the same commit.
> 
> Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
> ---
>   drivers/firmware/meson/meson_sm.c       | 94 +++++++++++++++++--------
>   drivers/nvmem/meson-efuse.c             | 24 ++++++-

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>



_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply index

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-31  8:23 [PATCH v2 0/4] Rework secure-monitor driver Carlo Caione
2019-07-31  8:23 ` [PATCH v2 1/4] firmware: meson_sm: Mark chip struct as static const Carlo Caione
2019-07-31  8:23 ` [PATCH v2 2/4] nvmem: meson-efuse: bindings: Add secure-monitor phandle Carlo Caione
2019-08-06  8:25   ` Jerome Brunet
2019-08-15 21:20   ` Kevin Hilman
2019-08-21 18:14   ` Rob Herring
2019-08-22  8:36     ` Carlo Caione
2019-08-22  8:59     ` Jerome Brunet
2019-07-31  8:23 ` [PATCH v2 3/4] arm64: dts: meson: Link nvmem and secure-monitor nodes Carlo Caione
2019-08-06  8:26   ` Jerome Brunet
2019-07-31  8:23 ` [PATCH v2 4/4] firmware: meson_sm: Rework driver as a proper platform driver Carlo Caione
2019-08-06  8:23   ` Srinivas Kandagatla [this message]
2019-08-05 21:34 ` [PATCH v2 0/4] Rework secure-monitor driver Kevin Hilman
2019-08-06  8:25   ` Srinivas Kandagatla
2019-08-09 21:42     ` Kevin Hilman

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a4f48fa-0110-78b5-75d9-091849ab4691@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=ccaione@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=narmstrong@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Amlogic Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-amlogic/0 linux-amlogic/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-amlogic linux-amlogic/ https://lore.kernel.org/linux-amlogic \
		linux-amlogic@lists.infradead.org linux-amlogic@archiver.kernel.org
	public-inbox-index linux-amlogic


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-amlogic


AGPL code for this site: git clone https://public-inbox.org/ public-inbox